[DistroKit] [PATCH] v7a: images: stm32mp: remove cargo-culted partition-type in GPT config

[DistroKit] [PATCH] v7a: images: stm32mp: remove cargo-culted partition-type in GPT config

[Ahmad Fatoum]

partition-type is specific to DOS partitions. The counterpart for GPT
partitions would be partition-type-uuid, which already defaults to "L",
which is ok for our purposes.

So far, this didn't have an impact, but starting with genimage v13,
commit 013b22f26b73 ("Add support for Hybrid MBR partitions"), support
for a partition-type key in a GPT partition was introduced:

  Using this option with a GPT partition table will create a hybrid
  MBR partition  table with a maximum of 3 partition entries(this
  limit does not effect the maximum number of GPT partition entries
  in the same image).

The ARM TF-A can't cope with this new format and fails to boot barebox
with a "ERROR:   Partition ssbl not found" message. Drop partition-type
to prevent the ptxdist 2020.06.0 upgrade that includes host-genimage v13
from breaking the stm32mp157c-dk2 and lxa-mc1 images.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
Hello Robert,

please apply before the v2020.06.0 ptxdist upgrade sitting in next
to avoid intermittent breakage.

Thanks,
---
 configs/platform-v7a/config/images/stm32mp.config | 2 --
 1 file changed, 2 deletions(-)

diff --git a/configs/platform-v7a/config/images/stm32mp.config b/configs/platform-v7a/config/images/stm32mp.config
index 0b9cfe888791..c10632013127 100644
--- a/configs/platform-v7a/config/images/stm32mp.config
+++ b/configs/platform-v7a/config/images/stm32mp.config
@@ -20,11 +20,9 @@ image @IMAGE@ {
 	}
 	partition root {
 		image = root.ext2
-		partition-type = 0x83
 		size = 512M
 	}
 	partition data {
-		partition-type = 0x83
 		size = 100M
 	}
 }
-- 
2.27.0


_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de

Re: [DistroKit] [PATCH] v7a: images: stm32mp: remove cargo-culted partition-type in GPT config

[Robert Schwebel]

On Wed, Jun 10, 2020 at 01:32:08PM +0200, Ahmad Fatoum wrote:
> partition-type is specific to DOS partitions. The counterpart for GPT
> partitions would be partition-type-uuid, which already defaults to "L",
> which is ok for our purposes.
> 
> So far, this didn't have an impact, but starting with genimage v13,
> commit 013b22f26b73 ("Add support for Hybrid MBR partitions"), support
> for a partition-type key in a GPT partition was introduced:
> 
>   Using this option with a GPT partition table will create a hybrid
>   MBR partition  table with a maximum of 3 partition entries(this
>   limit does not effect the maximum number of GPT partition entries
>   in the same image).
> 
> The ARM TF-A can't cope with this new format and fails to boot barebox
> with a "ERROR:   Partition ssbl not found" message. Drop partition-type
> to prevent the ptxdist 2020.06.0 upgrade that includes host-genimage v13
> from breaking the stm32mp157c-dk2 and lxa-mc1 images.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> Hello Robert,
> 
> please apply before the v2020.06.0 ptxdist upgrade sitting in next
> to avoid intermittent breakage.

Applied to next and re-arranged.

rsc
-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |

_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de