DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: distrokit@pengutronix.de
Subject: [DistroKit] [PATCH 2/3] v7a: images: stm32mp: don't quote boolean in genimage
Date: Mon, 25 Jan 2021 20:37:04 +0100	[thread overview]
Message-ID: <20210125193705.27018-2-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20210125193705.27018-1-a.fatoum@pengutronix.de>

Both forms are accepted, but it looks more natural to not quote
non-string values. This is also what we do for the other genimage
configs (e.g. bootable = true).
---
 configs/platform-v7a/config/images/stm32mp.config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/platform-v7a/config/images/stm32mp.config b/configs/platform-v7a/config/images/stm32mp.config
index c10632013127..4095e9fc612b 100644
--- a/configs/platform-v7a/config/images/stm32mp.config
+++ b/configs/platform-v7a/config/images/stm32mp.config
@@ -1,7 +1,7 @@
 image @IMAGE@ {
 	hdimage {
 		align = 1M
-		gpt = "true"
+		gpt = true
 	}
 	partition fsbl1 {
 		image = "tf-a-@STM32MP_BOARD@.stm32"
-- 
2.30.0


_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de

  reply	other threads:[~2021-01-25 19:37 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-25 19:37 [DistroKit] [PATCH 1/3] genimage: update to v14 Ahmad Fatoum
2021-01-25 19:37 ` Ahmad Fatoum [this message]
2021-02-01 17:57   ` [DistroKit] [PATCH 2/3] v7a: images: stm32mp: don't quote boolean in genimage Robert Schwebel
2021-01-25 19:37 ` [DistroKit] [PATCH 3/3] v7a: images: stm32mp: don't place backup GPT table into image Ahmad Fatoum
2021-02-01 18:01   ` Robert Schwebel
2021-02-01 10:34 ` [DistroKit] [PATCH 1/3] genimage: update to v14 Ahmad Fatoum
2021-02-01 18:01   ` Robert Schwebel
2021-02-01 17:53 ` Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210125193705.27018-2-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox