From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Tue, 9 Feb 2021 10:06:31 +0100 From: Robert Schwebel Message-ID: <20210209090631.c6qpl5fufxxuzmrn@pengutronix.de> References: <20210207235543.11784-1-rhi@pengutronix.de> <20210207235543.11784-3-rhi@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210207235543.11784-3-rhi@pengutronix.de> Subject: Re: [DistroKit] [PATCH 3/3] image-rpi2, image-rpi3: remove no-op ptxd_replace_magic calls List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: distrokit-bounces@pengutronix.de Sender: "DistroKit" To: Roland Hieber Cc: distrokit@pengutronix.de On Mon, Feb 08, 2021 at 12:55:43AM +0100, Roland Hieber wrote: > The new 'ptxdist lint' feature complained about these lines: > > Undefined symbol PTXCONF_IMAGE_RPI2_GPU_MEM used in 'next/configs/platform-v7a/rules/image-rpi2.make'. > Undefined symbol PTXCONF_IMAGE_RPI3_GPU_MEM used in 'next/configs/platform-v7a/rules/image-rpi3.make'. > > Indeed, these complaints were caused by multiple issues, probably going > back to copy-and-paste from platform-rpi: > > * IMAGE_RPI2_GPU_MEM and IMAGE_RPI3_GPU_MEM were never defined in any > kconfig menu since these lines were added (but a similar kconfig item > exists in configs/platform-rpi) > * configs/platform-v7a/rpi-firmware/config.txt didn't have any magic > replacement markers anymore since commit 98626f8441add596486b > * the "replaced" config.txt was never used by anything after writing it > to PTXDIST_TEMPDIR (which is the case in configs/platform-rpi) > > Remove the call completely. > > Fixes: 1db122202276b9f343eb (2017-06-16, "platform-v7a: rpi2: add board support") > Fixes: 98626f8441add596486b (2018-11-29, "add RPI3 Support") > Signed-off-by: Roland Hieber > --- > configs/platform-v7a/rules/image-rpi2.make | 3 --- > configs/platform-v7a/rules/image-rpi3.make | 3 --- > 2 files changed, 6 deletions(-) Applied to next. rsc -- Pengutronix e.K. | Dipl.-Ing. Robert Schwebel | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 | _______________________________________________ DistroKit mailing list DistroKit@pengutronix.de