* [DistroKit] [PATCH] v8a/firmware-imx: Ensure PKGDIR exists
@ 2021-03-16 10:51 Uwe Kleine-König
2021-03-16 11:01 ` Robert Schwebel
2021-03-16 13:56 ` Roland Hieber
0 siblings, 2 replies; 4+ messages in thread
From: Uwe Kleine-König @ 2021-03-16 10:51 UTC (permalink / raw)
To: distrokit
This fixes:
tar: DistroKit/platform-v8a/packages: Cannot open: No such file or directory
tar: Error is not recoverable: exiting now
make: *** [DistroKit/configs/platform-v8a/rules/firmware-imx.make:36: DistroKit/platform-v8a/state/firmware-imx.extract] Error 2
e.g. when running
ptxdist extract firmware-imx
in an unbuilt tree.
Fixes: 2e2c4377dc08 ("i.MX8M: add firmware-imx 8.8")
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
configs/platform-v8a/rules/firmware-imx.make | 1 +
1 file changed, 1 insertion(+)
diff --git a/configs/platform-v8a/rules/firmware-imx.make b/configs/platform-v8a/rules/firmware-imx.make
index b0efdb400611..0eae43503966 100644
--- a/configs/platform-v8a/rules/firmware-imx.make
+++ b/configs/platform-v8a/rules/firmware-imx.make
@@ -33,6 +33,7 @@ FIRMWARE_IMX_SOURCE := $(SRCDIR)/$(FIRMWARE_IMX).$(FIRMWARE_IMX_SUFFIX)
$(STATEDIR)/firmware-imx.extract:
@$(call targetinfo)
+ @mkdir -p "$(PKGDIR)"
@dd if=$(FIRMWARE_IMX_SOURCE) bs=$(FIRMWARE_IMX_SKIP) skip=1 | tar xj -C $(PKGDIR)
@$(call touch)
--
2.29.2
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [DistroKit] [PATCH] v8a/firmware-imx: Ensure PKGDIR exists
2021-03-16 10:51 [DistroKit] [PATCH] v8a/firmware-imx: Ensure PKGDIR exists Uwe Kleine-König
@ 2021-03-16 11:01 ` Robert Schwebel
2021-03-16 13:56 ` Roland Hieber
1 sibling, 0 replies; 4+ messages in thread
From: Robert Schwebel @ 2021-03-16 11:01 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: distrokit
On Tue, Mar 16, 2021 at 11:51:45AM +0100, Uwe Kleine-König wrote:
> This fixes:
>
> tar: DistroKit/platform-v8a/packages: Cannot open: No such file or directory
> tar: Error is not recoverable: exiting now
> make: *** [DistroKit/configs/platform-v8a/rules/firmware-imx.make:36: DistroKit/platform-v8a/state/firmware-imx.extract] Error 2
>
> e.g. when running
>
> ptxdist extract firmware-imx
>
> in an unbuilt tree.
>
> Fixes: 2e2c4377dc08 ("i.MX8M: add firmware-imx 8.8")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> configs/platform-v8a/rules/firmware-imx.make | 1 +
> 1 file changed, 1 insertion(+)
Applied to next.
rsc
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [DistroKit] [PATCH] v8a/firmware-imx: Ensure PKGDIR exists
2021-03-16 10:51 [DistroKit] [PATCH] v8a/firmware-imx: Ensure PKGDIR exists Uwe Kleine-König
2021-03-16 11:01 ` Robert Schwebel
@ 2021-03-16 13:56 ` Roland Hieber
2021-03-16 14:03 ` Ladislav Michl
1 sibling, 1 reply; 4+ messages in thread
From: Roland Hieber @ 2021-03-16 13:56 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: distrokit
On Tue, Mar 16, 2021 at 11:51:45AM +0100, Uwe Kleine-König wrote:
> This fixes:
>
> tar: DistroKit/platform-v8a/packages: Cannot open: No such file or directory
> tar: Error is not recoverable: exiting now
> make: *** [DistroKit/configs/platform-v8a/rules/firmware-imx.make:36: DistroKit/platform-v8a/state/firmware-imx.extract] Error 2
>
> e.g. when running
>
> ptxdist extract firmware-imx
>
> in an unbuilt tree.
>
> Fixes: 2e2c4377dc08 ("i.MX8M: add firmware-imx 8.8")
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
> configs/platform-v8a/rules/firmware-imx.make | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configs/platform-v8a/rules/firmware-imx.make b/configs/platform-v8a/rules/firmware-imx.make
> index b0efdb400611..0eae43503966 100644
> --- a/configs/platform-v8a/rules/firmware-imx.make
> +++ b/configs/platform-v8a/rules/firmware-imx.make
> @@ -33,6 +33,7 @@ FIRMWARE_IMX_SOURCE := $(SRCDIR)/$(FIRMWARE_IMX).$(FIRMWARE_IMX_SUFFIX)
>
> $(STATEDIR)/firmware-imx.extract:
> @$(call targetinfo)
> + @mkdir -p "$(PKGDIR)"
> @dd if=$(FIRMWARE_IMX_SOURCE) bs=$(FIRMWARE_IMX_SKIP) skip=1 | tar xj -C $(PKGDIR)
This looks strange. PKGDIR is the location where the files are installed
in the install stage. The extract stage should extract the source into
$(FIRMWARE_IMX_DIR), which is usually $(BUILDDIR)/$(FIRMWARE_IMX), and
$(BUILDDIR) will also be created by PTXdist during startup.
The prepare stage also doesn't so the @$(call clean, $(<PKG>_DIR)) or
@$(call patchin, <PKG>) steps, so I guess this rule needs cleanup in
general.
- Roland
--
Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [DistroKit] [PATCH] v8a/firmware-imx: Ensure PKGDIR exists
2021-03-16 13:56 ` Roland Hieber
@ 2021-03-16 14:03 ` Ladislav Michl
0 siblings, 0 replies; 4+ messages in thread
From: Ladislav Michl @ 2021-03-16 14:03 UTC (permalink / raw)
To: Roland Hieber, Uwe Kleine-König; +Cc: distrokit
On Tue, 2021-03-16 at 14:56 +0100, Roland Hieber wrote:
> On Tue, Mar 16, 2021 at 11:51:45AM +0100, Uwe Kleine-König wrote:
> > This fixes:
> >
> > tar: DistroKit/platform-v8a/packages: Cannot open: No such file or
> > directory
> > tar: Error is not recoverable: exiting now
> > make: *** [DistroKit/configs/platform-v8a/rules/firmware-
> > imx.make:36: DistroKit/platform-v8a/state/firmware-imx.extract]
> > Error 2
> >
> > e.g. when running
> >
> > ptxdist extract firmware-imx
> >
> > in an unbuilt tree.
> >
> > Fixes: 2e2c4377dc08 ("i.MX8M: add firmware-imx 8.8")
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> > ---
> > configs/platform-v8a/rules/firmware-imx.make | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/configs/platform-v8a/rules/firmware-imx.make
> > b/configs/platform-v8a/rules/firmware-imx.make
> > index b0efdb400611..0eae43503966 100644
> > --- a/configs/platform-v8a/rules/firmware-imx.make
> > +++ b/configs/platform-v8a/rules/firmware-imx.make
> > @@ -33,6 +33,7 @@ FIRMWARE_IMX_SOURCE :=
> > $(SRCDIR)/$(FIRMWARE_IMX).$(FIRMWARE_IMX_SUFFIX)
> >
> > $(STATEDIR)/firmware-imx.extract:
> > @$(call targetinfo)
> > + @mkdir -p "$(PKGDIR)"
> > @dd if=$(FIRMWARE_IMX_SOURCE) bs=$(FIRMWARE_IMX_SKIP)
> > skip=1 | tar xj -C $(PKGDIR)
>
> This looks strange. PKGDIR is the location where the files are
> installed in the install stage. The extract stage should extract the
> source into $(FIRMWARE_IMX_DIR), which is usually
> $(BUILDDIR)/$(FIRMWARE_IMX), and $(BUILDDIR) will also be created by
> PTXdist during startup.
Hmm, here install stage installs from PKGDIR into SYSROOT_TARGET, so
all this rule is a bit suspicious :-)
> The prepare stage also doesn't so the @$(call clean, $(<PKG>_DIR)) or
> @$(call patchin, <PKG>) steps, so I guess this rule needs cleanup in
> general.
>
> - Roland
>
_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-16 14:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-16 10:51 [DistroKit] [PATCH] v8a/firmware-imx: Ensure PKGDIR exists Uwe Kleine-König
2021-03-16 11:01 ` Robert Schwebel
2021-03-16 13:56 ` Roland Hieber
2021-03-16 14:03 ` Ladislav Michl
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox