DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: distrokit@pengutronix.de
Cc: Roland Hieber <rhi@pengutronix.de>
Subject: [DistroKit] [PATCH 4/5] v7a: run: remove telnet port forwarding
Date: Mon, 26 Apr 2021 08:05:25 +0200	[thread overview]
Message-ID: <20210426060526.32029-4-rhi@pengutronix.de> (raw)
In-Reply-To: <20210426060526.32029-1-rhi@pengutronix.de>

Hopefully nobody uses telnet anymore these days. Our userland certainly
doesn't. Remove the outdated qemu port forwarding.

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 configs/platform-v7a/run | 10 +++-------
 1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/configs/platform-v7a/run b/configs/platform-v7a/run
index 1dc4fd645d88..d180ccfa890d 100755
--- a/configs/platform-v7a/run
+++ b/configs/platform-v7a/run
@@ -36,13 +36,9 @@ if [ ! -e "${QEMU_EXEC}" ]; then
 	exit 1
 fi
 
-# the port a 'telned' would connect to (in the emulated sysem)
-TELNET_INTERNAL_PORT=23
-# port QEMU opens at the host side to give access to the ${TELNET_INTERNAL_PORT}
-TELNET_EXTERNAL_PORT=4444
-
-# dito for ssh
+# the port to which an sshd would connect (in the emulated sysem)
 SSH_INTERNAL_PORT=22
+# the port which QEMU opens at the host side to give access to the ${SSH_INTERNAL_PORT}
 SSH_EXTERNAL_PORT=4445
 
 # check if vde is available for networking
@@ -62,7 +58,7 @@ fi
 
 # fall back to user network if necessary
 if [ -z "${QEMU_NET}" ]; then
-	QEMU_NET=(-netdev user,id=net1,hostfwd=tcp:127.0.0.1:${TELNET_EXTERNAL_PORT}-:${TELNET_INTERNAL_PORT},hostfwd=tcp:127.0.0.1:${SSH_EXTERNAL_PORT}-:${SSH_INTERNAL_PORT} )
+	QEMU_NET=(-netdev user,id=net1,hostfwd=tcp:127.0.0.1:${SSH_EXTERNAL_PORT}-:${SSH_INTERNAL_PORT} )
 fi
 
 BASE_CMDLINE="console=ttyAMA0,115200 loglevel=5 systemd.log_level=warning systemd.show_status=auto"
-- 
2.29.2


_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de


  parent reply	other threads:[~2021-04-26  6:05 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26  6:05 [DistroKit] [PATCH 1/5] v7a: image-vexpress: convert hex numbers to human-readable sizes Roland Hieber
2021-04-26  6:05 ` [DistroKit] [PATCH 2/5] v7a: images: remove redundant size specifications Roland Hieber
2021-04-26  6:35   ` Robert Schwebel
2021-04-26  6:05 ` [DistroKit] [PATCH 3/5] v7a: barebox: clean up defaultenvs Roland Hieber
2021-04-26  6:36   ` Robert Schwebel
2021-04-26  6:05 ` Roland Hieber [this message]
2021-04-26  6:36   ` [DistroKit] [PATCH 4/5] v7a: run: remove telnet port forwarding Robert Schwebel
2021-04-26  6:05 ` [DistroKit] [PATCH 5/5] v7a: run: randomise the SSH forwarding port Roland Hieber
2021-04-26  6:33   ` Michael Olbrich
2021-04-26  8:30     ` Roland Hieber
2021-04-26  8:35       ` [DistroKit] [PATCH v2] " Roland Hieber
2021-04-26  9:02         ` Robert Schwebel
2021-04-26  9:03           ` Robert Schwebel
2021-04-26 10:07   ` [DistroKit] [PATCH v3] v7a: run: make the SSH forwarding port multiprocess-compatible Roland Hieber
2021-04-26 10:09     ` Robert Schwebel
2021-04-26  6:35 ` [DistroKit] [PATCH 1/5] v7a: image-vexpress: convert hex numbers to human-readable sizes Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210426060526.32029-4-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox