Re: [DistroKit] [PATCH v2] v7a: run: randomise the SSH forwarding port

[Robert Schwebel <r.schwebel@pengutronix.de>]

On Mon, Apr 26, 2021 at 11:02:16AM +0200, Robert Schwebel wrote:
> On Mon, Apr 26, 2021 at 10:35:56AM +0200, Roland Hieber wrote:
> > When multiple ./configs/platform-v7a/run scripts are run at the same
> > time, the first qemu process will open port 4445, and following runs
> > will fail. To prevent that, first look at the environment variable
> > QEMU_SSH_PORT to determine the port to be used (so that users can set
> > this in their shell to keep the port static), or fall back to a port
> > between 1025 and 65025 using the shell's PID as a seed, which should
> > have a good chance of being unused. Also print the port forwarding
> > before starting qemu, so we don't have to bother with "ps -Af|grep
> > qemu".
> > 
> > Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> > 
> > ---
> > v2:
> >   * use PPID instead of RANDOM to make the port reproducable in the same
> >     shell session (Michael Olbrich)
> > ---
> >  configs/platform-v7a/run | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> Could you rebase the patch against next?

The subject could need some care as well, as it isn't "randomize" any
more with the PPID change.

rsc
-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |

_______________________________________________
DistroKit mailing list
DistroKit@pengutronix.de