Re: [DistroKit] [PATCH] blspec-rpi4: move rule file to platform-v7a/rules/

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Dec 12, 2022 at 06:06:59PM +0100, Ahmad Fatoum wrote:
> On 12.12.22 09:23, Michael Olbrich wrote:
> > The menu file and all other blspec packages are defined in the platform as
> > well. Without this "ptxdist lint" reports for all other platforms:
> 
> I placed it top-level, because I intended for the rule to be reused
> when 64-bit support for the Raspberry Pi 4b is added to DistroKit.
> 
> Is there a way to accommodate this without ptxdist lint complaining?

In that case, you should place the menu file into the toplevel platforms/
directory. You need it anyways to reuse it in other platforms.
Add a 'depends on ARCH_ARM || ARCH_ARM64' to hide it for other platforms.

Michael

> > [...]
> > Checking kconfig symbols in rule files ...
> > Undefined symbol PTXCONF_BLSPEC_RPI4 used in 'DistroKit/rules/blspec-rpi4.make'.
> > [...]
> > 
> > Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
> > ---
> >  {rules => configs/platform-v7a/rules}/blspec-rpi4.make | 0
> >  1 file changed, 0 insertions(+), 0 deletions(-)
> >  rename {rules => configs/platform-v7a/rules}/blspec-rpi4.make (100%)
> > 
> > diff --git a/rules/blspec-rpi4.make b/configs/platform-v7a/rules/blspec-rpi4.make
> > similarity index 100%
> > rename from rules/blspec-rpi4.make
> > rename to configs/platform-v7a/rules/blspec-rpi4.mak
> 
> -- 
> Pengutronix e.K.                           |                             |
> Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
> 31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
> Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |