From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 12 Dec 2022 20:06:15 +0100 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1p4o7y-001v8D-OI for lore@lore.pengutronix.de; Mon, 12 Dec 2022 20:06:15 +0100 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1p4o7y-0007Pq-5t; Mon, 12 Dec 2022 20:06:14 +0100 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4o7r-0007PK-4v; Mon, 12 Dec 2022 20:06:07 +0100 Received: from mol by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1p4o7q-00055D-UF; Mon, 12 Dec 2022 20:06:06 +0100 Date: Mon, 12 Dec 2022 20:06:06 +0100 From: Michael Olbrich To: Ahmad Fatoum Message-ID: <20221212190606.GG30335@pengutronix.de> Mail-Followup-To: Ahmad Fatoum , distrokit@pengutronix.de References: <20221212082318.3291073-1-m.olbrich@pengutronix.de> <19b5fa1c-cb99-8cc8-268e-71bb1f7d894f@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <19b5fa1c-cb99-8cc8-268e-71bb1f7d894f@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [DistroKit] [PATCH] blspec-rpi4: move rule file to platform-v7a/rules/ X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Mon, Dec 12, 2022 at 06:06:59PM +0100, Ahmad Fatoum wrote: > On 12.12.22 09:23, Michael Olbrich wrote: > > The menu file and all other blspec packages are defined in the platform as > > well. Without this "ptxdist lint" reports for all other platforms: > > I placed it top-level, because I intended for the rule to be reused > when 64-bit support for the Raspberry Pi 4b is added to DistroKit. > > Is there a way to accommodate this without ptxdist lint complaining? In that case, you should place the menu file into the toplevel platforms/ directory. You need it anyways to reuse it in other platforms. Add a 'depends on ARCH_ARM || ARCH_ARM64' to hide it for other platforms. Michael > > [...] > > Checking kconfig symbols in rule files ... > > Undefined symbol PTXCONF_BLSPEC_RPI4 used in 'DistroKit/rules/blspec-rpi4.make'. > > [...] > > > > Signed-off-by: Michael Olbrich > > --- > > {rules => configs/platform-v7a/rules}/blspec-rpi4.make | 0 > > 1 file changed, 0 insertions(+), 0 deletions(-) > > rename {rules => configs/platform-v7a/rules}/blspec-rpi4.make (100%) > > > > diff --git a/rules/blspec-rpi4.make b/configs/platform-v7a/rules/blspec-rpi4.make > > similarity index 100% > > rename from rules/blspec-rpi4.make > > rename to configs/platform-v7a/rules/blspec-rpi4.mak > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |