From: Michael Olbrich <m.olbrich@pengutronix.de>
To: distrokit@pengutronix.de
Subject: [DistroKit] [PATCH] blspec-rpi4: move menu file to platforms/
Date: Fri, 6 Jan 2023 12:39:46 +0100 [thread overview]
Message-ID: <20230106113946.1775158-1-m.olbrich@pengutronix.de> (raw)
In-Reply-To: <20221212190606.GG30335@pengutronix.de>
The rule file is toplevel in rules/ so without this "ptxdist lint" reports
for all other platforms:
[...]
Checking kconfig symbols in rule files ...
Undefined symbol PTXCONF_BLSPEC_RPI4 used in 'DistroKit/rules/blspec-rpi4.make'.
[...]
Add some dependencies so it can only be selected on platforms where it
makes sense and disable it on v8a for now.
Signed-off-by: Michael Olbrich <m.olbrich@pengutronix.de>
---
With this it can be enabled on v8a in the future but no other platform will
show it in the menu.
Michael
configs/platform-v7a/platforms/blspec-rpi4.in | 5 -----
configs/platform-v8a/platformconfig | 1 +
platforms/blspec-rpi4.in | 7 +++++++
3 files changed, 8 insertions(+), 5 deletions(-)
delete mode 100644 configs/platform-v7a/platforms/blspec-rpi4.in
create mode 100644 platforms/blspec-rpi4.in
diff --git a/configs/platform-v7a/platforms/blspec-rpi4.in b/configs/platform-v7a/platforms/blspec-rpi4.in
deleted file mode 100644
index 0c0ce14f47bf..000000000000
--- a/configs/platform-v7a/platforms/blspec-rpi4.in
+++ /dev/null
@@ -1,5 +0,0 @@
-## SECTION=blspec
-
-config BLSPEC_RPI4
- tristate
- prompt "/loader/entries/rpi4*.conf bootloader spec entries"
diff --git a/configs/platform-v8a/platformconfig b/configs/platform-v8a/platformconfig
index 36708d6aa47b..785a1a22e069 100644
--- a/configs/platform-v8a/platformconfig
+++ b/configs/platform-v8a/platformconfig
@@ -194,6 +194,7 @@ PTXCONF_BLSPEC_IMX8MM_EVK=y
PTXCONF_BLSPEC_IMX8MP_EVK=y
PTXCONF_BLSPEC_IMX8MQ_EVK=y
PTXCONF_BLSPEC_ROCK3A=y
+# PTXCONF_BLSPEC_RPI4 is not set
# end of bootloader spec entries
#
diff --git a/platforms/blspec-rpi4.in b/platforms/blspec-rpi4.in
new file mode 100644
index 000000000000..aa3e7aff5ae3
--- /dev/null
+++ b/platforms/blspec-rpi4.in
@@ -0,0 +1,7 @@
+## SECTION=blspec
+
+config BLSPEC_RPI4
+ tristate
+ # make sure it's only visible on platforms, where it makes sense
+ depends on ARCH_ARM && ARCH_ARMV7_NEON || ARCH_ARM64
+ prompt "/loader/entries/rpi4*.conf bootloader spec entries"
--
2.30.2
next prev parent reply other threads:[~2023-01-06 11:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 8:23 [DistroKit] [PATCH] blspec-rpi4: move rule file to platform-v7a/rules/ Michael Olbrich
2022-12-12 17:06 ` Ahmad Fatoum
2022-12-12 19:06 ` Michael Olbrich
2023-01-06 11:39 ` Michael Olbrich [this message]
2023-01-06 11:46 ` [DistroKit] [PATCH] blspec-rpi4: move menu file to platforms/ Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230106113946.1775158-1-m.olbrich@pengutronix.de \
--to=m.olbrich@pengutronix.de \
--cc=distrokit@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox