DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: distrokit@pengutronix.de
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [DistroKit] [PATCH] v8a: barebox: rockchip: disable CONFIG_MMCBLKDEV_ROOTARG
Date: Fri, 14 Apr 2023 18:34:29 +0200	[thread overview]
Message-ID: <20230414163429.602101-1-a.fatoum@pengutronix.de> (raw)

The help text of CONFIG_MMCBLKDEV_ROOTARG is pretty clear on that the
option should only be used when barebox and kernel aliases agree.
The upstream kernel DT aliases for all Radxa boards were recently
changed, so depending on whether we update kernel or barebox first,
we may experience breakage. Let's avoid this by using the default
PARTUUID-based root argument generation again until we have updated
both barebox and Linux to device tree revisions that agree.

[afa: It would be best if barebox' append_root feature could just
 use kernel aliases, but this is not totally trivial, as the root=
 entry is generated early at barebox mount time and kernel DT
 isn't known till boot]

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
This is required to boot currently used kernel with barebox-next.
---
 configs/platform-v8a/barebox-rockchip.config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/platform-v8a/barebox-rockchip.config b/configs/platform-v8a/barebox-rockchip.config
index 109f55c12aba..c063a97b6de9 100644
--- a/configs/platform-v8a/barebox-rockchip.config
+++ b/configs/platform-v8a/barebox-rockchip.config
@@ -179,7 +179,7 @@ CONFIG_BOOTM_OFTREE=y
 # CONFIG_BOOTM_FITIMAGE is not set
 CONFIG_BLSPEC=y
 CONFIG_FLEXIBLE_BOOTARGS=y
-CONFIG_MMCBLKDEV_ROOTARG=y
+# CONFIG_MMCBLKDEV_ROOTARG is not set
 CONFIG_BAREBOX_UPDATE=y
 CONFIG_SYSTEM_PARTITIONS=y
 CONFIG_IMD=y
-- 
2.39.2




             reply	other threads:[~2023-04-14 16:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-14 16:34 Ahmad Fatoum [this message]
2023-04-14 16:45 ` Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230414163429.602101-1-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox