From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 20 Jun 2023 15:29:38 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qBbQS-00EQ7n-7l for lore@lore.pengutronix.de; Tue, 20 Jun 2023 15:29:38 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qBbQP-00029Q-IK; Tue, 20 Jun 2023 15:29:37 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qBbQM-000216-OF; Tue, 20 Jun 2023 15:29:34 +0200 Received: from [2a0a:edc0:0:1101:1d::54] (helo=dude05.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1qBbQM-008no7-4U; Tue, 20 Jun 2023 15:29:34 +0200 Received: from mol by dude05.red.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1qBbQK-00998n-3D; Tue, 20 Jun 2023 15:29:32 +0200 From: Michael Olbrich To: distrokit@pengutronix.de Date: Tue, 20 Jun 2023 15:29:29 +0200 Message-Id: <20230620132931.2179983-6-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230620132931.2179983-1-m.olbrich@pengutronix.de> References: <20230620132931.2179983-1-m.olbrich@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [DistroKit] [PATCH v2 5/7] firmware-imx: use foreach and ptx/nl X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Olbrich Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Combining multiple commands with ';' hides errors. So use $(foreach ...) and $(ptx/nl) to create separate commands that are executed individually and all errors are caught. Signed-off-by: Michael Olbrich --- configs/platform-v8a/rules/firmware-imx.make | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/configs/platform-v8a/rules/firmware-imx.make b/configs/platform-v8a/rules/firmware-imx.make index 7bf1701b3ce1..56c8e24ecd69 100644 --- a/configs/platform-v8a/rules/firmware-imx.make +++ b/configs/platform-v8a/rules/firmware-imx.make @@ -59,11 +59,11 @@ ifdef PTXCONF_FIRMWARE_IMX_BOOTIMAGE_IMX8 @$(foreach f, lpddr4_pmu_train_1d_dmem.bin lpddr4_pmu_train_1d_imem.bin \ lpddr4_pmu_train_2d_dmem.bin lpddr4_pmu_train_2d_imem.bin, \ install -v -D -m644 $(FIRMWARE_IMX_PKGDIR)/firmware/ddr/synopsys/$(f) \ - $(PTXCONF_SYSROOT_TARGET)/usr/lib/firmware/ddr/synopsys/$(f);) + $(PTXCONF_SYSROOT_TARGET)/usr/lib/firmware/ddr/synopsys/$(f)$(ptx/nl)) @$(foreach f, signed_dp_imx8m.bin signed_hdmi_imx8m.bin, \ install -v -D -m644 $(FIRMWARE_IMX_PKGDIR)/firmware/hdmi/cadence/$(f) \ - $(PTXCONF_SYSROOT_TARGET)/usr/lib/firmware/hdmi/cadence/$(f);) + $(PTXCONF_SYSROOT_TARGET)/usr/lib/firmware/hdmi/cadence/$(f)$(ptx/nl)) endif @$(call touch) @@ -86,10 +86,10 @@ $(STATEDIR)/firmware-imx.targetinstall: @$(call install_fixup, firmware-imx,SECTION,base) @$(call install_fixup, firmware-imx,AUTHOR,"Philipp Zabel ") @$(call install_fixup, firmware-imx,DESCRIPTION,missing) - @for f in $(FIRMWARE_IMX_INSTALL-y); do \ + @$(foreach f,$(FIRMWARE_IMX_INSTALL-y), \ $(call install_copy, firmware-imx, 0, 0, 0644, \ - $(FIRMWARE_IMX_PKGDIR)/firmware/vpu/$$f, /usr/lib/firmware/$$f); \ - done + $(FIRMWARE_IMX_PKGDIR)/firmware/vpu/$(f), \ + /usr/lib/firmware/$(f))$(ptx/nl)) @$(call install_finish, firmware-imx) @$(call touch) -- 2.39.2