DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: rsc@pengutronix.de
Cc: distrokit@pengutronix.de, jbe@pengutronix.de, jlu@pengutronix.de,
	Roland Hieber <rhi@pengutronix.de>
Subject: [DistroKit] [PATCH] fixup! v7a: barebox: enable loading kernel, dtb and initrd via fastboot
Date: Mon, 28 Aug 2023 14:32:48 +0200	[thread overview]
Message-ID: <20230828123248.1366357-1-rhi@pengutronix.de> (raw)
In-Reply-To: <ZOw6enFv4KTyJJdI@pengutronix.de>

Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
On Mon, Aug 28, 2023 at 08:11:07AM +0200, Robert Schwebel wrote:         
> Jan, what's the best way to catch this in 'reason'? I tried to match on
> 'PLATFORM' and use value: 'v7a', but this doesn't work. Matching on ARCH_ARM
> isn't an option, as we have platform-rpi1.                             
                                                                         
I don't know how your condition looked, but the patch below works for    
me. A similar expression is already a few lines further above in the     
kernel_dtb_partitions check (although the .get() should not be needed    
here as PTXCONF_PLATFORM is always defined).  

 configs/bsp.ref | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/bsp.ref b/configs/bsp.ref
index cb91c780516f..d20eb70afd45 100644
--- a/configs/bsp.ref
+++ b/configs/bsp.ref
@@ -29,7 +29,7 @@ kernel_initrd:
     Initrd support is not needed on most embedded systems.
     For v8a, we use an initrd for the fastboot usecase.
   variants:
-    - condition: kconfig.PTXPlatformConfig()['ARCH_ARM64']
+    - condition: kconfig.PTXPlatformConfig().options['PLATFORM'] in ('v8a', 'v7a')
       value: True
     - value: False
 
-- 
2.39.2




  reply	other threads:[~2023-08-28 12:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-25 11:10 [DistroKit] [PATCH v2] " Juergen Borleis
2023-08-25 12:00 ` Robert Schwebel
2023-08-28  6:11   ` Robert Schwebel
2023-08-28 12:32     ` Roland Hieber [this message]
2023-09-15 14:00       ` [DistroKit] [PATCH] fixup! " Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230828123248.1366357-1-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    --cc=jbe@pengutronix.de \
    --cc=jlu@pengutronix.de \
    --cc=rsc@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox