Re: [DistroKit] [PATCH 2/2] v8a: barebox: env: fix boot for i.MX8M EVKs

[Roland Hieber <rhi@pengutronix.de>]

On Tue, Dec 05, 2023 at 10:59:30AM +0100, Ahmad Fatoum wrote:
> Rockchip RK35* and i.MX8M* share the same barebox environment, but RAUC
> and bootchooser were only configured for the Rockchip boards, rendering
> the i.MX boards unbootable. Fix this by adding bootchooser as boot
> target only for the radxa,rock3a.
> 
> While at it, we switch to using the new of_compatible command. This is
> likey more stable than the Model string and allows easy extension in
> future by additional compatibles.

Seems very reasonable to me.

> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Reviewed-by: Roland Hieber <rhi@pengutronix.de>

> ---
>  .../platform-v8a/barebox-common-defaultenv/init/bootsource   | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/configs/platform-v8a/barebox-common-defaultenv/init/bootsource b/configs/platform-v8a/barebox-common-defaultenv/init/bootsource
> index fe63bbbe099b..af47c82c1001 100644
> --- a/configs/platform-v8a/barebox-common-defaultenv/init/bootsource
> +++ b/configs/platform-v8a/barebox-common-defaultenv/init/bootsource
> @@ -7,10 +7,11 @@ fi
>  
>  if [ "$bootsource" = mmc ]; then
>  	detect mmc$bootsource_instance
> -	global.boot.default="bootchooser net"
> +	global.boot.default="mmc$bootsource_instance net"
>  fi
>  
> -if [ "${global.model}" = "Radxa ROCK3 Model A" ]; then
> +if of_compatible -k radxa,rock3a; then
> +	global.boot.default="bootchooser net"
>  	global bootchooser.state_prefix="state.bootstate"
>  	global bootchooser.targets="system0 system1"
>  	global bootchooser.system0.boot="mmc1.root-A"
> -- 
> 2.39.2
> 
> 
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |