From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 29 Jan 2024 12:38:10 +0100 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1rUPxp-009ygS-08 for lore@lore.pengutronix.de; Mon, 29 Jan 2024 12:38:10 +0100 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1rUPxp-0006bw-HM; Mon, 29 Jan 2024 12:38:09 +0100 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rUPxh-0006bY-Mg; Mon, 29 Jan 2024 12:38:01 +0100 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rUPxh-0039vV-9x; Mon, 29 Jan 2024 12:38:01 +0100 Received: from rsc by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1rUPxh-002R06-7G; Mon, 29 Jan 2024 12:38:01 +0100 Date: Mon, 29 Jan 2024 12:38:01 +0100 From: Robert Schwebel To: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , distrokit@pengutronix.de, Marc Kleine-Budde , Lucas Stach Message-ID: <20240129113801.GL176585@pengutronix.de> References: <20240126170432.740899-1-m.olbrich@pengutronix.de> <20240126184034.GA176585@pengutronix.de> <20240127105848.GC176585@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) Subject: Re: [DistroKit] [PATCH v4] platform-v8a: kernelconfig: cleanup X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On Mon, Jan 29, 2024 at 09:38:05AM +0100, Michael Olbrich wrote: > > - CONFIG_COMPACTION: You switched this off, but 'reason' claims that it > > should be on, and the help test for the option does also suggest that > > we better enable this. All of our other kernel configs for other > > platforms have it enabled. > > Lucas, Marc, I don't remember why we disabled this. Unless you know and > have a good reason, I'd say enable it. > > > - CONFIG_CRYPTO_AES is on, CONFIG_CRYPTO_AES_ARM64_CE_CCM is also on, > > but CONFIG_CRYPTO_CCM was switched from m to off. > > > > Was there a specific reason for that, or can we switch both back on? > > CONFIG_CRYPTO_CCM is no longer needed by any driver. The correct fix is to > disable CONFIG_CRYPTO_AES_ARM64_CE_CCM instead. A corresponding patch is now on next. rsc -- Pengutronix e.K. | Dipl.-Ing. Robert Schwebel | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |