From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 03 May 2024 13:53:39 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1s2rTu-00HGJE-36 for lore@lore.pengutronix.de; Fri, 03 May 2024 13:53:39 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1s2rTu-0006kF-Gj; Fri, 03 May 2024 13:53:38 +0200 Received: from mail.thorsis.com ([217.92.40.78]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s2rTo-0006ju-Mf; Fri, 03 May 2024 13:53:33 +0200 Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id AF0A81487AFC; Fri, 3 May 2024 13:53:31 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thorsis.com; s=dkim; t=1714737211; h=from:subject:date:message-id:to:cc:mime-version:content-type: in-reply-to:references; bh=mOqlbFYJC9LOQi2xHveORYGIjomuL0KAMnnu7QpcLpw=; b=YZcyqTGaMe2zSusi/1reSbEN4PsWzUi1PIsa61MZYn3LbwJDLBotBBCYs49lCYjvdt4nDz RVc3HJ2TKbwh8rIVr4mn6z6qwzEJYHvGeYhcmNLCn12YF23Pn48sSfNXzoPg1X3okY8mqO Jc4kZt1TxSlvZLtrsAeed0f5Uq7urg97Mchn4TlghKGuBz9m4p6QJRx3rX32Db8qpfQ1eg XfPnLr1ZeE5st4/cQZtPjBp1xkmho3fM6see70SfPn8Twpa0pBlOCobuScosRHGs3KE10j 7CX+ACNp6IyA/Jtod/MxJzjz5HfUOQNrcJk53FjEMSdrvDaz17qOsDryi8n5Jw== Date: Fri, 3 May 2024 13:53:30 +0200 From: Alexander Dahl To: Michael Olbrich Message-ID: <20240503-spotty-pesticide-f533094e5e02@thorsis.com> Mail-Followup-To: Michael Olbrich , distrokit@pengutronix.de, Ahmad Fatoum References: <20240503105844.2621419-1-m.olbrich@pengutronix.de> <20240503105844.2621419-3-m.olbrich@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240503105844.2621419-3-m.olbrich@pengutronix.de> User-Agent: Mutt/2.2.12 (2023-09-09) X-Last-TLS-Session-Version: TLSv1.3 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 Subject: Re: [DistroKit] [PATCH 2/3] tf-a-stm32mp13: use _URL and _SOURCE from tf-a X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de, Ahmad Fatoum Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Hei hei, Am Fri, May 03, 2024 at 12:58:43PM +0200 schrieb Michael Olbrich: > It's already the same source since version and md5 a shared. So make > sure the exact same file is used and downloaded only once. > > Signed-off-by: Michael Olbrich > --- > configs/platform-v7a/rules/tf-a-stm32mp13.make | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configs/platform-v7a/rules/tf-a-stm32mp13.make b/configs/platform-v7a/rules/tf-a-stm32mp13.make > index d8a7e92de073..137dc8de3204 100644 > --- a/configs/platform-v7a/rules/tf-a-stm32mp13.make > +++ b/configs/platform-v7a/rules/tf-a-stm32mp13.make > @@ -19,8 +19,8 @@ TF_A_STM32MP13_VERSION := $(call ptx/config-version, PTXCONF_TF_A) > TF_A_STM32MP13_MD5 := $(call ptx/config-md5, PTXCONF_TF_A) > TF_A_STM32MP13 := tf-a-stm32mp13-$(TF_A_STM32MP13_VERSION) > TF_A_STM32MP13_SUFFIX := tar.gz > -TF_A_STM32MP13_URL := https://git.trustedfirmware.org/TF-A/trusted-firmware-a.git/snapshot/$(TF_A_STM32MP13_VERSION).$(TF_A_STM32MP13_SUFFIX) > -TF_A_STM32MP13_SOURCE := $(SRCDIR)/$(TF_A_STM32MP13).$(TF_A_STM32MP13_SUFFIX) > +TF_A_STM32MP13_URL = $(TF_A_URL) > +TF_A_STM32MP13_SOURCE = $(TF_A_SOURCE) As stated before: this does only work if TF_A is enabled in platformconfig. It will still break if TF_A_STM32MP13 is enabled, but TF_A is not. (This was already broken in that way before this change.) Greets Alex > TF_A_STM32MP13_DIR := $(BUILDDIR)/$(TF_A_STM32MP13) > TF_A_STM32MP13_BUILDDIR := $(TF_A_STM32MP13_DIR)/build > TF_A_STM32MP13_BUILD_OOT := YES > -- > 2.39.2 > >