DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: distrokit@pengutronix.de
Cc: Michael Olbrich <m.olbrich@pengutronix.de>,
	Roland Hieber <rhi@pengutronix.de>
Subject: [DistroKit] [PATCH v3 3/4] binary_inst: remove outdated example
Date: Wed, 19 Jun 2024 14:32:36 +0200	[thread overview]
Message-ID: <20240619123237.1396057-4-rhi@pengutronix.de> (raw)
In-Reply-To: <20240619123237.1396057-1-rhi@pengutronix.de>

The current state of the example is outdated, e.g. the empty stages can
just be left out. The recipe can always be recreated by running
"ptxdist newpackage file" and following the steps of the wizard, as
described in the PTXdist manual.

Reviewed-by: Michael Olbrich <m.olbrich@pengutronix.de>
Signed-off-by: Roland Hieber <rhi@pengutronix.de>
---
 configs/ptxconfig      |  1 -
 rules/binary_inst.in   | 27 ------------
 rules/binary_inst.make | 97 ------------------------------------------
 3 files changed, 125 deletions(-)
 delete mode 100644 rules/binary_inst.in
 delete mode 100644 rules/binary_inst.make

diff --git a/configs/ptxconfig b/configs/ptxconfig
index f5ac373e61d2..c7cdb62e16a5 100644
--- a/configs/ptxconfig
+++ b/configs/ptxconfig
@@ -207,7 +207,6 @@ PTXCONF_STRACE=y
 #
 # Root Filesystem               
 #
-# PTXCONF_BINARY_EXAMPLE is not set
 # PTXCONF_FAKE_OVERLAYFS is not set
 PTXCONF_INITMETHOD=y
 # PTXCONF_INITMETHOD_BBINIT is not set
diff --git a/rules/binary_inst.in b/rules/binary_inst.in
deleted file mode 100644
index bbb989bed379..000000000000
--- a/rules/binary_inst.in
+++ /dev/null
@@ -1,27 +0,0 @@
-## SECTION=rootfs
-#
-# This file is just an example how to install binaries to the root filesystem
-# via ptxdist
-#
-menuconfig BINARY_EXAMPLE
-	bool "binary example                "
-	help
-	  This is an example only how to install binary files and archives.
-	  Refer our "How to become a PTXdist Guru" application note on
-	  how to use it.
-
-if BINARY_EXAMPLE
-
-config BINARY_EXAMPLE_FILE
-	bool "install the binary file"
-	help
-	  This example will install the file 'local_src/binary_example/ptx_logo.png'
-	  from this BSP into target's root filesystem in '/example'
-
-config BINARY_EXAMPLE_ARCHIVE
-	bool "install the binary archive"
-	help
-	  This example will install all files from the 'local_src/archive_example/pictures.tgz'
-	  archive from this BSP into target's root filesystem in '/example'
-
-endif
diff --git a/rules/binary_inst.make b/rules/binary_inst.make
deleted file mode 100644
index aa809936e2b2..000000000000
--- a/rules/binary_inst.make
+++ /dev/null
@@ -1,97 +0,0 @@
-#
-# This is an example rule file to install some kind of binary data only.
-# Only the targetinstall stage will do something. All other stages are skipped.
-# Nothing has to be built at compile time, the files are expected ready for use
-# as part of the BSP.
-#
-
-#
-# We provide this package
-#
-PACKAGES-$(PTXCONF_BINARY_EXAMPLE) += binary_example
-
-#
-# Paths and names
-#
-BINARY_EXAMPLE_VERSION := 1
-
-# ----------------------------------------------------------------------------
-# omit the 'get' stage (due to the fact, the files are already present)
-# ----------------------------------------------------------------------------
-
-$(STATEDIR)/binary_example.get:
-		@$(call targetinfo)
-		@$(call touch)
-
-# ----------------------------------------------------------------------------
-# omit the 'extract' stage (due to the fact, all files are already present)
-# ----------------------------------------------------------------------------
-
-$(STATEDIR)/binary_example.extract:
-		@$(call targetinfo)
-		@$(call touch)
-
-# ----------------------------------------------------------------------------
-# omit the 'prepare' stage (due to the fact, nothing is to be built)
-# ----------------------------------------------------------------------------
-
-$(STATEDIR)/binary_example.prepare:
-		@$(call targetinfo)
-		@$(call touch)
-
-# ----------------------------------------------------------------------------
-# omit the 'compile' stage (due to the fact, nothing is to be built)
-# ----------------------------------------------------------------------------
-
-$(STATEDIR)/binary_example.compile:
-		@$(call targetinfo)
-		@$(call touch)
-
-# ----------------------------------------------------------------------------
-# omit the 'install' stage (due to the fact, nothing is to be installed into the sysroot)
-# ----------------------------------------------------------------------------
-
-$(STATEDIR)/binary_example.install:
-		@$(call targetinfo)
-		@$(call touch)
-
-# ----------------------------------------------------------------------------
-# Target-Install
-# ----------------------------------------------------------------------------
-
-$(STATEDIR)/binary_example.targetinstall:
-	@$(call targetinfo)
-	
-	@$(call install_init, binary_example)
-	@$(call install_fixup, binary_example,PACKAGE,binary_example)
-	@$(call install_fixup, binary_example,PRIORITY,optional)
-	@$(call install_fixup, binary_example,VERSION,$(BINARY_EXAMPLE_VERSION))
-	@$(call install_fixup, binary_example,SECTION,base)
-	@$(call install_fixup, binary_example,AUTHOR,"Juergen Beisert <jbe@pengutronix.de>")
-	@$(call install_fixup, binary_example,DEPENDS,)
-	@$(call install_fixup, binary_example,DESCRIPTION,"A few binary example files")
-
-#
-# Install the single binary file on demand
-#
-ifdef PTXCONF_BINARY_EXAMPLE_FILE
-	@$(call install_copy, binary_example, 0, 0, 0755, /example)
-	@$(call install_copy, binary_example, 0, 0, 0644, \
-		$(PTXDIST_WORKSPACE)/local_src/binary_example/ptx_logo.png, \
-		/example/ptx_logo.png)
-endif
-
-#
-# Install the whole archive on demand
-#
-ifdef PTXCONF_BINARY_EXAMPLE_ARCHIVE
-	@$(call install_archive, binary_example, -, -, \
-		$(PTXDIST_WORKSPACE)/local_src/archive_example/pictures.tgz, \
-		/)
-# note: the third parameter is the 'user id', the forth parameter the 'group id'.
-# If given as '-', the ID from the archive is used. If given as number, this
-# number is used, instead of the ID in the archive.
-endif
-
-	@$(call install_finish, binary_example)
-	@$(call touch)
-- 
2.39.2




  parent reply	other threads:[~2024-06-19 12:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-19 12:32 [DistroKit] [PATCH v3 0/4] recipe cleanup Roland Hieber
2024-06-19 12:32 ` [DistroKit] [PATCH v3 1/4] datapartition: make it selectable Roland Hieber
2024-06-19 12:32 ` [DistroKit] [PATCH v3 2/4] datapartition: rename to repart-config Roland Hieber
2024-06-19 12:32 ` Roland Hieber [this message]
2024-06-19 12:32 ` [DistroKit] [PATCH v3 4/4] ptxconfig: create menu for DistroKit-specific rules Roland Hieber
2024-06-20 10:28   ` Alexander Dahl
2024-06-20 10:48 ` [DistroKit] [PATCH v3 0/4] recipe cleanup Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240619123237.1396057-4-rhi@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    --cc=m.olbrich@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox