DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: distrokit@pengutronix.de
Cc: Ahmad Fatoum <a.fatoum@pengutronix.de>
Subject: [DistroKit] [PATCH 3/4] v7a: barebox: don't use root=PARTUUID= when booting from SD/eMMC
Date: Thu, 11 Jul 2024 13:01:42 +0200	[thread overview]
Message-ID: <20240711110143.470379-3-a.fatoum@pengutronix.de> (raw)
In-Reply-To: <20240711110143.470379-1-a.fatoum@pengutronix.de>

The stm32mp images may be written to both SD and eMMC, so it's important
that barebox identifies the boot medium uses for root= unambiguously and
not via PARTUUID= which may be equal if the exact same image is written
to both SD and eMMC

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 configs/platform-v7a/barebox-stm32mp.config      | 2 +-
 configs/platform-v7a/barebox-stm32mp.config.diff | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/configs/platform-v7a/barebox-stm32mp.config b/configs/platform-v7a/barebox-stm32mp.config
index afba652187a9..0de53381925b 100644
--- a/configs/platform-v7a/barebox-stm32mp.config
+++ b/configs/platform-v7a/barebox-stm32mp.config
@@ -171,7 +171,7 @@ CONFIG_BOOTM_FITIMAGE=y
 # CONFIG_BOOTM_FITIMAGE_SIGNATURE is not set
 CONFIG_BLSPEC=y
 CONFIG_FLEXIBLE_BOOTARGS=y
-# CONFIG_MMCBLKDEV_ROOTARG is not set
+CONFIG_MMCBLKDEV_ROOTARG=y
 CONFIG_BAREBOX_UPDATE=y
 CONFIG_SYSTEM_PARTITIONS=y
 CONFIG_IMD=y
diff --git a/configs/platform-v7a/barebox-stm32mp.config.diff b/configs/platform-v7a/barebox-stm32mp.config.diff
index 6c285c6793bc..23f80f70d3ee 100644
--- a/configs/platform-v7a/barebox-stm32mp.config.diff
+++ b/configs/platform-v7a/barebox-stm32mp.config.diff
@@ -99,7 +99,6 @@ CONFIG_MFD_STM32_TIMERS=y
 CONFIG_MFD_STPMIC1=y
 CONFIG_MFD_SYSCON=y
 CONFIG_MICREL_PHY=y
-# CONFIG_MMCBLKDEV_ROOTARG is not set
 # CONFIG_MTD is not set
 # CONFIG_MTD_CONCAT is undefined
 # CONFIG_MTD_DATAFLASH is undefined
-- 
2.39.2




  parent reply	other threads:[~2024-07-11 11:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-11 11:01 [DistroKit] [PATCH 1/4] v7a: barebox: enable ARM accelerated SHA1 routines Ahmad Fatoum
2024-07-11 11:01 ` [DistroKit] [PATCH 2/4] v7a: barebox: don't activate first console Ahmad Fatoum
2024-07-11 11:01 ` Ahmad Fatoum [this message]
2024-07-11 11:01 ` [DistroKit] [PATCH 4/4] v7a: barebox: am335x-mlo: document some unusual kconfig options Ahmad Fatoum
2024-07-12 14:30 ` [DistroKit] [PATCH 1/4] v7a: barebox: enable ARM accelerated SHA1 routines Robert Schwebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240711110143.470379-3-a.fatoum@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox