[DistroKit] [PATCH] fixup! v7a: barebox: am335x-mlo: document some unusual kconfig options

[DistroKit] [PATCH] fixup! v7a: barebox: am335x-mlo: document some unusual kconfig options

[Ahmad Fatoum]

v7a: barebox: restrict bsp.ref condition to applicable platforms

While barebox can be built for x86_64 and MIPS, we don't currently do so,
so the condition in the bsp.ref shouldn't assume that all platforms
have a barebox config.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 configs/bsp.ref | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/configs/bsp.ref b/configs/bsp.ref
index 5b5b4a763b15..2f64107ef52a 100644
--- a/configs/bsp.ref
+++ b/configs/bsp.ref
@@ -53,7 +53,9 @@ barebox_arm_optimized_string_functions:
     needs to fit into on-chip SRAM to be able to set up DRAM and thus
     we use the smaller C implementation instead.
   variants:
-    - condition: kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE']
+    - condition: |
+        kconfig.have_barebox_config() and
+        kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE']
       value: False
     - value: True
 
@@ -67,7 +69,9 @@ barebox_gpt_support:
     barebox, we only need GPT support later on in the second stage
     barebox-am335x configuration.
   variants:
-    - condition: kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE']
+    - condition: |
+        kconfig.have_barebox_config() and
+        kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE']
       value: False
     - value: True
 
-- 
2.39.2

Re: [DistroKit] [PATCH] fixup! v7a: barebox: am335x-mlo: document some unusual kconfig options

[Robert Schwebel]

Added, next test run is ... well, running ....

On Fri, Jul 12, 2024 at 05:36:27PM +0200, Ahmad Fatoum wrote:
> v7a: barebox: restrict bsp.ref condition to applicable platforms
> 
> While barebox can be built for x86_64 and MIPS, we don't currently do so,
> so the condition in the bsp.ref shouldn't assume that all platforms
> have a barebox config.
> 
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
>  configs/bsp.ref | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/configs/bsp.ref b/configs/bsp.ref
> index 5b5b4a763b15..2f64107ef52a 100644
> --- a/configs/bsp.ref
> +++ b/configs/bsp.ref
> @@ -53,7 +53,9 @@ barebox_arm_optimized_string_functions:
>      needs to fit into on-chip SRAM to be able to set up DRAM and thus
>      we use the smaller C implementation instead.
>    variants:
> -    - condition: kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE']
> +    - condition: |
> +        kconfig.have_barebox_config() and
> +        kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE']
>        value: False
>      - value: True
>  
> @@ -67,7 +69,9 @@ barebox_gpt_support:
>      barebox, we only need GPT support later on in the second stage
>      barebox-am335x configuration.
>    variants:
> -    - condition: kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE']
> +    - condition: |
> +        kconfig.have_barebox_config() and
> +        kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE']
>        value: False
>      - value: True
>  
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |