From mboxrd@z Thu Jan  1 00:00:00 1970
Delivery-date: Mon, 29 Jan 2024 12:53:21 +0100
Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104])
	by lore.white.stw.pengutronix.de with esmtps  (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384
	(Exim 4.96)
	(envelope-from <distrokit-bounces+lore=lore.pengutronix.de@pengutronix.de>)
	id 1rUQCW-009zn6-1t
	for lore@lore.pengutronix.de;
	Mon, 29 Jan 2024 12:53:21 +0100
Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de)
	by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92)
	(envelope-from <distrokit-bounces@pengutronix.de>)
	id 1rUQCX-0007fk-Bs; Mon, 29 Jan 2024 12:53:21 +0100
Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77]
 helo=[IPv6:::1]) by metis.whiteo.stw.pengutronix.de with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92)
 (envelope-from <l.stach@pengutronix.de>)
 id 1rUQCU-0007fF-Jx; Mon, 29 Jan 2024 12:53:18 +0100
Message-ID: <2240a8b0ba51dd4750bafb4317615f9ec4220ee6.camel@pengutronix.de>
From: Lucas Stach <l.stach@pengutronix.de>
To: Michael Olbrich <m.olbrich@pengutronix.de>, Robert Schwebel
 <r.schwebel@pengutronix.de>
Date: Mon, 29 Jan 2024 12:53:18 +0100
In-Reply-To: <Zbdj7QU-qmUklPyv@pengutronix.de>
References: <20240126170432.740899-1-m.olbrich@pengutronix.de>
 <20240126184034.GA176585@pengutronix.de>
 <20240127105848.GC176585@pengutronix.de> <Zbdj7QU-qmUklPyv@pengutronix.de>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.48.4 (3.48.4-1.fc38) 
MIME-Version: 1.0
Subject: Re: [DistroKit] [PATCH v4] platform-v8a: kernelconfig: cleanup
X-BeenThere: distrokit@pengutronix.de
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DistroKit Mailinglist <distrokit.pengutronix.de>
List-Unsubscribe: <https://metis.pengutronix.de/mailman/options/distrokit>,
 <mailto:distrokit-request@pengutronix.de?subject=unsubscribe>
List-Archive: <https://metis.pengutronix.de/mailman/private/distrokit/>
List-Post: <mailto:distrokit@pengutronix.de>
List-Help: <mailto:distrokit-request@pengutronix.de?subject=help>
List-Subscribe: <https://metis.pengutronix.de/mailman/listinfo/distrokit>,
 <mailto:distrokit-request@pengutronix.de?subject=subscribe>
Cc: Marc Kleine-Budde <mkl@pengutronix.de>, distrokit@pengutronix.de,
 Uwe =?ISO-8859-1?Q?Kleine-K=F6nig?= <ukl@pengutronix.de>
Sender: "DistroKit" <distrokit-bounces@pengutronix.de>
X-SA-Exim-Connect-IP: 127.0.0.1
X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de
X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false

Am Montag, dem 29.01.2024 um 09:38 +0100 schrieb Michael Olbrich:
> Hi,
>=20
> On Sat, Jan 27, 2024 at 11:58:48AM +0100, Robert Schwebel wrote:
> > On Fri, Jan 26, 2024 at 07:40:34PM +0100, Robert Schwebel wrote:
> > > Thanks, applied to next.
> >=20
> > The testsuite found two issues:
> >=20
> > - CONFIG_COMPACTION: You switched this off, but 'reason' claims that it
> >   should be on, and the help test for the option does also suggest that
> >   we better enable this. All of our other kernel configs for other
> >   platforms have it enabled.
>=20
> Lucas, Marc, I don't remember why we disabled this. Unless you know and
> have a good reason, I'd say enable it.
>=20
There is no good reason, we simply didn't look close enough. The
reasoning was that only MIGRATION is required for CMA, but we clearly
failed to consider the Kconfig help text when disabling COMPACTION.

Regards,
Lucas