From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 08 Jun 2023 11:27:20 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q7BvO-00FZa2-3j for lore@lore.pengutronix.de; Thu, 08 Jun 2023 11:27:20 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q7BvL-0001SR-Ta; Thu, 08 Jun 2023 11:27:19 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q7BvK-0001SE-HE; Thu, 08 Jun 2023 11:27:18 +0200 Message-ID: <32978e49-0851-55ae-a3ee-5395ee9f8214@pengutronix.de> Date: Thu, 8 Jun 2023 11:27:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: Michael Olbrich , distrokit@pengutronix.de References: <6e79067d-59c5-40b7-da45-cbb00829df20@pengutronix.de> <20230608092528.1529283-1-m.olbrich@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20230608092528.1529283-1-m.olbrich@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [DistroKit] [PATCH v2] firmware-imx: make sure menuconfig works correctly X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On 08.06.23 11:25, Michael Olbrich wrote: > Suboptions are only sorted into a submenu if: > - the suboptions depend on the menuconfig option > - the suboptions are listed immediately after the menuconfig option > > The BAREBOX_DEPENDENCIES in the middle breaks this so move it to the > bottom of the file. > > Signed-off-by: Michael Olbrich Reviewed-by: Ahmad Fatoum Thanks for the explanation! > --- > > I've updated the commit message. It should make more sense now. > > Michael > > configs/platform-v8a/platforms/firmware-imx.in | 11 ++++++----- > 1 file changed, 6 insertions(+), 5 deletions(-) > > diff --git a/configs/platform-v8a/platforms/firmware-imx.in b/configs/platform-v8a/platforms/firmware-imx.in > index 8c76b693d257..19d89ace9821 100644 > --- a/configs/platform-v8a/platforms/firmware-imx.in > +++ b/configs/platform-v8a/platforms/firmware-imx.in > @@ -6,11 +6,6 @@ menuconfig FIRMWARE_IMX > help > Install CODA VPU firmware files from the firmware-imx package. > > -config BAREBOX_DEPENDENCIES > - tristate > - select FIRMWARE_IMX > - select TF_A > - > if FIRMWARE_IMX > > config FIRMWARE_IMX_VPU_IMX27 > @@ -51,3 +46,9 @@ config FIRMWARE_IMX_BOOTIMAGE_IMX8 > firmware used to build a boot image. > > endif > + > +config BAREBOX_DEPENDENCIES > + tristate > + select FIRMWARE_IMX > + select TF_A > + -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |