From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 06 Jul 2023 14:51:00 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qHORq-0007JW-6p for lore@lore.pengutronix.de; Thu, 06 Jul 2023 14:51:00 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qHORo-0005Xy-0h; Thu, 06 Jul 2023 14:51:00 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qHORi-0005WP-8j; Thu, 06 Jul 2023 14:50:54 +0200 Message-ID: <4d7ae788-6e9c-0e4f-bf8c-28e99a5745b4@pengutronix.de> Date: Thu, 6 Jul 2023 14:50:53 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Content-Language: en-US To: Oleksij Rempel , distrokit@pengutronix.de References: <20230706114434.1751248-1-o.rempel@pengutronix.de> <20230706114434.1751248-3-o.rempel@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20230706114434.1751248-3-o.rempel@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [DistroKit] [PATCH v1 3/5] v7a_noneon: add Microchip SAMA5D3 Ethernet Delopment System Board support X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false Hello Oleksij, On 06.07.23 13:44, Oleksij Rempel wrote: > Microchip Technology SAMA5D3 Ethernet Development System (EDS) Board > (DM320114) is an MPU-based platform for evaluating Ethernet Switch and > PHY products. Compatible Ethernet Switch and PHY Evaluation Boards > connect to the SAMA5D3 EDS Board via either an RGMII or RMII connector. > The Microchip Technology SAMA5D3 EDS Board is not intended for > stand-alone use and has no Ethernet capabilities when no daughter board > or an USB Ethernet adapter is connected. [snip] > diff --git a/configs/platform-v7a_noneon/barebox-at91.config b/configs/platform-v7a_noneon/barebox-at91.config > index 584bfae..06a2d96 100644 > --- a/configs/platform-v7a_noneon/barebox-at91.config > +++ b/configs/platform-v7a_noneon/barebox-at91.config Unrelated: barebox NAND driver is disabled, but may be useful to enable it in the defconfig given that the EVB has NAND. > diff --git a/configs/platform-v7a_noneon/platforms/blspec-sama5d3-eds.in b/configs/platform-v7a_noneon/platforms/blspec-sama5d3-eds.in > new file mode 100644 > index 0000000..54ecbf7 > --- /dev/null > +++ b/configs/platform-v7a_noneon/platforms/blspec-sama5d3-eds.in > @@ -0,0 +1,5 @@ > +## SECTION=blspec > + > +config BLSPEC_SAMA5D3_EDS > + tristate > + prompt "/loader/entries/sama5d3-eds.conf bootloader spec entry" > diff --git a/configs/platform-v7a_noneon/platforms/image-sama5d3-eds.in b/configs/platform-v7a_noneon/platforms/image-sama5d3-eds.in Please see commit b7a4fe185852 ("v7a: blspec: convert to ptxdist default entries"). You may be able to drop your blspec rules and files and just have the files automatically generated. > BAREBOX_AT91_IMAGES := \ > images/barebox-microchip-ksz9477-evb.img \ > - images/barebox-microchip-ksz9477-evb-xload-mmc.img > + images/barebox-microchip-ksz9477-evb-xload-mmc.img \ > + images/barebox-microchip-sama5d3-eds.img \ > + images/barebox-microchip-sama5d3-eds-xload-mmc.img This is out of scope for your patch, but just so you know, new versions of the PTXdist barebox rule parse the barebox-flash-images file, so you don't need to hardcode names. Unfortunately, AT91 is not enabled for CONFIG_ARCH_MULTIARCH, but once that's done we could have a single bootloader for the v7a_nonneon boards (like we already do for v8a). Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |