Re: [DistroKit] [PATCH 3/5] v8a: images: generate sparse images from rock3a initramfs, kernel and dtb

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 06.06.23 16:49, Johannes Zink wrote:
> On 6/6/23 16:42, Ahmad Fatoum wrote:
>> On 06.06.23 16:41, Ahmad Fatoum wrote:
>>> On 06.06.23 16:31, Johannes Zink wrote:
>>>> This allows to load the images to barebox using android fastboot, since
>>>> otherwise the sparse header is missing and the image size is not
>>>> properly aligned as required by fastboot.
>>>
>>> IME fastboot just complains and transfers the files anyway. In that
>>> case building sparse images just adds complication. Did your fastboot
>>> command fail without this change?
>>>
>>>>
>>>> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
>>>> ---
>>>>   configs/platform-v8a/config/images/rock3a.config | 21 +++++++++++++++++++++
>>>>   1 file changed, 21 insertions(+)
>>>>
>>>> diff --git a/configs/platform-v8a/config/images/rock3a.config b/configs/platform-v8a/config/images/rock3a.config
>>>> index 522d82cdc9c9..cb0c7c4e575d 100644
>>>> --- a/configs/platform-v8a/config/images/rock3a.config
>>>> +++ b/configs/platform-v8a/config/images/rock3a.config
>>>> @@ -44,3 +44,24 @@ image barebox-rock3a.norimg {
>>>>           image = "barebox-rock3a.img"
>>>>       }
>>>>   }
>>>> +
>>>> +image initramfs-sparse.img {
>>>> +    android-sparse {
>>>> +        image = "root.cpio.gz"
>>>> +        block-size = 4k
>>>> +    }
>>>> +}
>>>> +
>>>> +image kernel-sparse.img {
>>>> +    android-sparse {
>>>> +        image = "linuximage"
>>>> +        block-size = 4k
>>>> +    }
>>>> +}
>>
>> Also, these two aren't rock3a specific, so they shouldn't be here
>> especially not with such generic sounding names.
> 
> ack, gonna move them to a separate config for v2 of this series. Though, I think they should keep their generic names, as they can be used across all other v8a targets.

Their name should be aligned with the file they are in unless
they are removed.

> 
> Johannes
> 
>>
>>>> +
>>>> +image dtb-rock3a-sparse.img {
>>>> +    android-sparse {
>>>> +        image = "rk3568-rock-3a.dtb"
>>>> +        block-size = 4k
>>>> +    }
>>>> +}
>>>>
>>>
>>
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |