From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 08 Jun 2023 11:27:39 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q7Bvg-00FZcO-Ki for lore@lore.pengutronix.de; Thu, 08 Jun 2023 11:27:39 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q7Bve-0001VY-9W; Thu, 08 Jun 2023 11:27:38 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q7Bvc-0001VP-LH for distrokit@pengutronix.de; Thu, 08 Jun 2023 11:27:36 +0200 Message-ID: <92171832-9ff6-1418-428f-822020f374e6@pengutronix.de> Date: Thu, 8 Jun 2023 11:27:36 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.1 Content-Language: en-US To: distrokit@pengutronix.de References: <20230602145957.902307-1-m.olbrich@pengutronix.de> <20230602145957.902307-4-m.olbrich@pengutronix.de> <8d3a9e71-3c0d-a8b5-90b3-3b16ae03effc@pengutronix.de> From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [DistroKit] [PATCH 3/7] platform-v8a: move platform menu files to platforms/ X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On 08.06.23 11:22, Michael Olbrich wrote: > On Fri, Jun 02, 2023 at 06:44:36PM +0200, Ahmad Fatoum wrote: >> On 02.06.23 16:59, Michael Olbrich wrote: >>> Menu files that are only use for the platformconfig and not the >>> ptxconfig belong in platforms/. >> >> What functional change does this introduce? > > No functional change. Originally, all menu files for the platformconfig > where in platforms/ and rules/ was not used. This changed at some point to > make it possible to depend on some host-tools in ptxconfig and > patformconfig. > So now it works both ways, but the policy still it to put anything that is > only used in the platformconfig in platforms/. I see, thanks. Reviewed-by: Ahmad Fatoum > > Michael > >>> >>> Signed-off-by: Michael Olbrich >>> --- >>> configs/platform-v8a/{rules => platforms}/firmware-imx.in | 0 >>> configs/platform-v8a/{rules => platforms}/firmware-rockchip.in | 0 >>> 2 files changed, 0 insertions(+), 0 deletions(-) >>> rename configs/platform-v8a/{rules => platforms}/firmware-imx.in (100%) >>> rename configs/platform-v8a/{rules => platforms}/firmware-rockchip.in (100%) >>> >>> diff --git a/configs/platform-v8a/rules/firmware-imx.in b/configs/platform-v8a/platforms/firmware-imx.in >>> similarity index 100% >>> rename from configs/platform-v8a/rules/firmware-imx.in >>> rename to configs/platform-v8a/platforms/firmware-imx.in >>> diff --git a/configs/platform-v8a/rules/firmware-rockchip.in b/configs/platform-v8a/platforms/firmware-rockchip.in >>> similarity index 100% >>> rename from configs/platform-v8a/rules/firmware-rockchip.in >>> rename to configs/platform-v8a/platforms/firmware-rockchip.in >> >> -- >> Pengutronix e.K. | | >> Steuerwalder Str. 21 | http://www.pengutronix.de/ | >> 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | >> Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | >> >> >> > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |