[DistroKit] [PATCH] v8a: configure MTD SPI-NOR sector sizes consistently

[DistroKit] [PATCH] v8a: configure MTD SPI-NOR sector sizes consistently

[Ahmad Fatoum]

It must be guaranteed that the option MTD_SPI_NOR_USE_4K_SECTORS is set
consistently between barebox and kernel. If this is not the case bad things
can happen (e.g. inconsistencies in barebox state).

The platforms we have use MMC by default, but let's take no chances and
do (one of the) right thing(s) by aligning barebox with the kernel,
which is already built with CONFIG_MTD_SPI_NOR_USE_4K_SECTORS=y.

Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
---
 configs/platform-v8a/barebox.config | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/platform-v8a/barebox.config b/configs/platform-v8a/barebox.config
index a540e307e179..94dc595c30ea 100644
--- a/configs/platform-v8a/barebox.config
+++ b/configs/platform-v8a/barebox.config
@@ -631,7 +631,7 @@ CONFIG_MTD_M25P80=y
 # CONFIG_DRIVER_CFI is not set
 # CONFIG_NAND is not set
 CONFIG_MTD_SPI_NOR=y
-# CONFIG_MTD_SPI_NOR_USE_4K_SECTORS is not set
+CONFIG_MTD_SPI_NOR_USE_4K_SECTORS=y
 # CONFIG_SPI_CADENCE_QUADSPI is not set
 # CONFIG_MTD_UBI is not set
 CONFIG_DISK=y
-- 
2.39.2

Re: [DistroKit] [PATCH] v8a: configure MTD SPI-NOR sector sizes consistently

[Robert Schwebel]

On Wed, May 31, 2023 at 03:20:49PM +0200, Ahmad Fatoum wrote:
> It must be guaranteed that the option MTD_SPI_NOR_USE_4K_SECTORS is set
> consistently between barebox and kernel. If this is not the case bad things
> can happen (e.g. inconsistencies in barebox state).
> 
> The platforms we have use MMC by default, but let's take no chances and
> do (one of the) right thing(s) by aligning barebox with the kernel,
> which is already built with CONFIG_MTD_SPI_NOR_USE_4K_SECTORS=y.

Thanks, now also testing in next...

rsc
-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |