From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 01 Jun 2023 09:05:30 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q4cNI-005RnI-0C for lore@lore.pengutronix.de; Thu, 01 Jun 2023 09:05:30 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q4cNF-0007fn-Ht; Thu, 01 Jun 2023 09:05:29 +0200 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4cN8-0007eI-BA; Thu, 01 Jun 2023 09:05:22 +0200 Received: from mol by pty.hi.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q4cN7-005t2e-Sd; Thu, 01 Jun 2023 09:05:21 +0200 Date: Thu, 1 Jun 2023 09:05:21 +0200 From: Michael Olbrich To: Ahmad Fatoum Message-ID: Mail-Followup-To: Ahmad Fatoum , "distrokit@pengutronix.de" References: <20230601064811.628050-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [DistroKit] [PATCH] v8a: barebox: add missing dependency on TF_A for i.MX X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "distrokit@pengutronix.de" Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Thu, Jun 01, 2023 at 08:49:38AM +0200, Ahmad Fatoum wrote: > On 01.06.23 08:48, Ahmad Fatoum wrote: > > Unlike firmware-rockchip, firmware-imx doesn't ship BL31 (TF-A). Instead > > we configure the upstream TF-A rule to build images for i.MX8M Quad, > > Mini and Plus. > > > > With the switch to the upstream barebox rule, this dependency on TF-A > > got lost breaking less-parallel fresh builds, so let's add it back. > > > > Preferably, TF_A would be selected directly from the barebox rule's > > Kconfig. There's a BAREBOX_DEPENDENCIES option for that, but I don't > > know if it's possible to extend barebox.in without having to duplicate > > it fully, so adding it to firmware-imx should suffice for now. > > Is there something like post/barebox-fixup.make, but for Kconfig files > that I should be using instead? This looks fine. We need the special stuff in make, because you cannot extend a make target in another makefile. It's easier with Kconfig: All occurrences of a symbol are merged so you just need to make sure that the file with you're new dependency is actually loaded. Michael > > Signed-off-by: Ahmad Fatoum > > --- > > configs/platform-v8a/rules/firmware-imx.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/configs/platform-v8a/rules/firmware-imx.in b/configs/platform-v8a/rules/firmware-imx.in > > index 5f06a44416fa..c756b963e5dc 100644 > > --- a/configs/platform-v8a/rules/firmware-imx.in > > +++ b/configs/platform-v8a/rules/firmware-imx.in > > @@ -10,6 +10,7 @@ menuconfig FIRMWARE_IMX > > config BAREBOX_DEPENDENCIES > > tristate > > select FIRMWARE_IMX > > + select TF_A > > > > if FIRMWARE_IMX > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |