From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Tue, 13 Jun 2023 09:21:00 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q8yKr-004sAs-Uk for lore@lore.pengutronix.de; Tue, 13 Jun 2023 09:21:00 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q8yKp-0008LG-Ho; Tue, 13 Jun 2023 09:20:59 +0200 Received: from pty.hi.pengutronix.de ([2001:67c:670:100:1d::c5]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8yKg-0008K6-I0; Tue, 13 Jun 2023 09:20:50 +0200 Received: from mol by pty.hi.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1q8yKg-007F4W-3I; Tue, 13 Jun 2023 09:20:50 +0200 Date: Tue, 13 Jun 2023 09:20:50 +0200 From: Michael Olbrich To: Ahmad Fatoum Message-ID: Mail-Followup-To: Ahmad Fatoum , Robert Schwebel , distrokit@pengutronix.de References: <20230106115424.2180991-1-m.olbrich@pengutronix.de> <49e05dca-d89a-cb15-124c-0608b293630e@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <49e05dca-d89a-cb15-124c-0608b293630e@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [DistroKit] [PATCH] patches: move TF-A patches to the platforms X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Mon, Jun 12, 2023 at 02:25:08PM +0200, Ahmad Fatoum wrote: > On 12.06.23 14:23, Robert Schwebel wrote: > > could you rebase the series? Upstream has 2.8 meanwhile. > > We should be using the same package for both platforms, so this patch shouldn't > be necessary anymore. There are other platforms that don't build tf-a at all, so ptxdist lint will fail for those. And you need to update tf-a for both platform in lock-step. If that's ok, then we can leave it as it is. I only use v7a and v8a to test ptxdist itself, so I don't mind lint failures for other platforms. Michael > > On Fri, Jan 06, 2023 at 12:54:24PM +0100, Michael Olbrich wrote: > >> On all other platforms "ptxdist lint" complains because they are unused. > >> > >> These patches are platform specific so they should be in the platform. > >> Move the patches into the correct platform to fix this. > >> > >> Signed-off-by: Michael Olbrich > >> --- > >> ...001-fix-stm32mp1-fdts-stm32mp1-align-DDR-regulators-with.patch | 0 > >> .../0002-build-makefile-add-helper-to-detect-linker-options.patch | 0 > >> .../0003-feat-build-add-support-for-new-binutils-versions.patch | 0 > >> .../tf-a-v2.7/0004-makefile-link-with-z-noexecstack.patch | 0 > >> {patches => configs/platform-v7a/patches}/tf-a-v2.7/series | 0 > >> .../0001-build-makefile-add-helper-to-detect-linker-options.patch | 0 > >> ...002-build-makefile-avoid-gcc-warning-that-triggers-with-.patch | 0 > >> .../0003-feat-build-add-support-for-new-binutils-versions.patch | 0 > >> .../0004-makefile-link-with-z-noexecstack.patch | 0 > >> .../platform-v8a/patches}/imx-atf-imx_5.4.24_2.1.0/series | 0 > >> 10 files changed, 0 insertions(+), 0 deletions(-) > >> rename {patches => configs/platform-v7a/patches}/tf-a-v2.7/0001-fix-stm32mp1-fdts-stm32mp1-align-DDR-regulators-with.patch (100%) > >> rename {patches => configs/platform-v7a/patches}/tf-a-v2.7/0002-build-makefile-add-helper-to-detect-linker-options.patch (100%) > >> rename {patches/imx-atf-imx_5.4.24_2.1.0 => configs/platform-v7a/patches/tf-a-v2.7}/0003-feat-build-add-support-for-new-binutils-versions.patch (100%) > >> rename {patches => configs/platform-v7a/patches}/tf-a-v2.7/0004-makefile-link-with-z-noexecstack.patch (100%) > >> rename {patches => configs/platform-v7a/patches}/tf-a-v2.7/series (100%) > >> rename {patches => configs/platform-v8a/patches}/imx-atf-imx_5.4.24_2.1.0/0001-build-makefile-add-helper-to-detect-linker-options.patch (100%) > >> rename {patches => configs/platform-v8a/patches}/imx-atf-imx_5.4.24_2.1.0/0002-build-makefile-avoid-gcc-warning-that-triggers-with-.patch (100%) > >> rename {patches/tf-a-v2.7 => configs/platform-v8a/patches/imx-atf-imx_5.4.24_2.1.0}/0003-feat-build-add-support-for-new-binutils-versions.patch (100%) > >> rename {patches => configs/platform-v8a/patches}/imx-atf-imx_5.4.24_2.1.0/0004-makefile-link-with-z-noexecstack.patch (100%) > >> rename {patches => configs/platform-v8a/patches}/imx-atf-imx_5.4.24_2.1.0/series (100%) > >> > >> diff --git a/patches/tf-a-v2.7/0001-fix-stm32mp1-fdts-stm32mp1-align-DDR-regulators-with.patch b/configs/platform-v7a/patches/tf-a-v2.7/0001-fix-stm32mp1-fdts-stm32mp1-align-DDR-regulators-with.patch > >> similarity index 100% > >> rename from patches/tf-a-v2.7/0001-fix-stm32mp1-fdts-stm32mp1-align-DDR-regulators-with.patch > >> rename to configs/platform-v7a/patches/tf-a-v2.7/0001-fix-stm32mp1-fdts-stm32mp1-align-DDR-regulators-with.patch > >> diff --git a/patches/tf-a-v2.7/0002-build-makefile-add-helper-to-detect-linker-options.patch b/configs/platform-v7a/patches/tf-a-v2.7/0002-build-makefile-add-helper-to-detect-linker-options.patch > >> similarity index 100% > >> rename from patches/tf-a-v2.7/0002-build-makefile-add-helper-to-detect-linker-options.patch > >> rename to configs/platform-v7a/patches/tf-a-v2.7/0002-build-makefile-add-helper-to-detect-linker-options.patch > >> diff --git a/patches/imx-atf-imx_5.4.24_2.1.0/0003-feat-build-add-support-for-new-binutils-versions.patch b/configs/platform-v7a/patches/tf-a-v2.7/0003-feat-build-add-support-for-new-binutils-versions.patch > >> similarity index 100% > >> rename from patches/imx-atf-imx_5.4.24_2.1.0/0003-feat-build-add-support-for-new-binutils-versions.patch > >> rename to configs/platform-v7a/patches/tf-a-v2.7/0003-feat-build-add-support-for-new-binutils-versions.patch > >> diff --git a/patches/tf-a-v2.7/0004-makefile-link-with-z-noexecstack.patch b/configs/platform-v7a/patches/tf-a-v2.7/0004-makefile-link-with-z-noexecstack.patch > >> similarity index 100% > >> rename from patches/tf-a-v2.7/0004-makefile-link-with-z-noexecstack.patch > >> rename to configs/platform-v7a/patches/tf-a-v2.7/0004-makefile-link-with-z-noexecstack.patch > >> diff --git a/patches/tf-a-v2.7/series b/configs/platform-v7a/patches/tf-a-v2.7/series > >> similarity index 100% > >> rename from patches/tf-a-v2.7/series > >> rename to configs/platform-v7a/patches/tf-a-v2.7/series > >> diff --git a/patches/imx-atf-imx_5.4.24_2.1.0/0001-build-makefile-add-helper-to-detect-linker-options.patch b/configs/platform-v8a/patches/imx-atf-imx_5.4.24_2.1.0/0001-build-makefile-add-helper-to-detect-linker-options.patch > >> similarity index 100% > >> rename from patches/imx-atf-imx_5.4.24_2.1.0/0001-build-makefile-add-helper-to-detect-linker-options.patch > >> rename to configs/platform-v8a/patches/imx-atf-imx_5.4.24_2.1.0/0001-build-makefile-add-helper-to-detect-linker-options.patch > >> diff --git a/patches/imx-atf-imx_5.4.24_2.1.0/0002-build-makefile-avoid-gcc-warning-that-triggers-with-.patch b/configs/platform-v8a/patches/imx-atf-imx_5.4.24_2.1.0/0002-build-makefile-avoid-gcc-warning-that-triggers-with-.patch > >> similarity index 100% > >> rename from patches/imx-atf-imx_5.4.24_2.1.0/0002-build-makefile-avoid-gcc-warning-that-triggers-with-.patch > >> rename to configs/platform-v8a/patches/imx-atf-imx_5.4.24_2.1.0/0002-build-makefile-avoid-gcc-warning-that-triggers-with-.patch > >> diff --git a/patches/tf-a-v2.7/0003-feat-build-add-support-for-new-binutils-versions.patch b/configs/platform-v8a/patches/imx-atf-imx_5.4.24_2.1.0/0003-feat-build-add-support-for-new-binutils-versions.patch > >> similarity index 100% > >> rename from patches/tf-a-v2.7/0003-feat-build-add-support-for-new-binutils-versions.patch > >> rename to configs/platform-v8a/patches/imx-atf-imx_5.4.24_2.1.0/0003-feat-build-add-support-for-new-binutils-versions.patch > >> diff --git a/patches/imx-atf-imx_5.4.24_2.1.0/0004-makefile-link-with-z-noexecstack.patch b/configs/platform-v8a/patches/imx-atf-imx_5.4.24_2.1.0/0004-makefile-link-with-z-noexecstack.patch > >> similarity index 100% > >> rename from patches/imx-atf-imx_5.4.24_2.1.0/0004-makefile-link-with-z-noexecstack.patch > >> rename to configs/platform-v8a/patches/imx-atf-imx_5.4.24_2.1.0/0004-makefile-link-with-z-noexecstack.patch > >> diff --git a/patches/imx-atf-imx_5.4.24_2.1.0/series b/configs/platform-v8a/patches/imx-atf-imx_5.4.24_2.1.0/series > >> similarity index 100% > >> rename from patches/imx-atf-imx_5.4.24_2.1.0/series > >> rename to configs/platform-v8a/patches/imx-atf-imx_5.4.24_2.1.0/series > >> -- > >> 2.30.2 > >> > >> > >> > > > > -- > Pengutronix e.K. | | > Steuerwalder Str. 21 | http://www.pengutronix.de/ | > 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | > Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | > > > -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |