From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 15 Sep 2023 16:00:28 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qh9Mz-00GIKH-3s for lore@lore.pengutronix.de; Fri, 15 Sep 2023 16:00:28 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qh9Mx-0007YB-3g; Fri, 15 Sep 2023 16:00:27 +0200 Received: from pty.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::c5]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qh9Mo-0007Vo-Kq; Fri, 15 Sep 2023 16:00:19 +0200 Received: from rsc by pty.whiteo.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1qh9Mo-003kcW-8Y; Fri, 15 Sep 2023 16:00:18 +0200 Date: Fri, 15 Sep 2023 16:00:18 +0200 From: Robert Schwebel To: Roland Hieber Message-ID: References: <20230828123248.1366357-1-rhi@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230828123248.1366357-1-rhi@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on metis.whiteo.stw.pengutronix.de X-Spam-Level: X-Spam-Status: No, score=-1.0 required=4.0 tests=AWL,BAYES_00,SPF_HELO_NONE, SPF_SOFTFAIL autolearn=no autolearn_force=no version=3.4.2 Subject: Re: [DistroKit] [PATCH] fixup! v7a: barebox: enable loading kernel, dtb and initrd via fastboot X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de, jbe@pengutronix.de, jlu@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Ported to current -next, folded into the original patch. On Mon, Aug 28, 2023 at 02:32:48PM +0200, Roland Hieber wrote: > Signed-off-by: Roland Hieber > --- > On Mon, Aug 28, 2023 at 08:11:07AM +0200, Robert Schwebel wrote: > > Jan, what's the best way to catch this in 'reason'? I tried to match on > > 'PLATFORM' and use value: 'v7a', but this doesn't work. Matching on ARCH_ARM > > isn't an option, as we have platform-rpi1. > > I don't know how your condition looked, but the patch below works for > me. A similar expression is already a few lines further above in the > kernel_dtb_partitions check (although the .get() should not be needed > here as PTXCONF_PLATFORM is always defined). > > configs/bsp.ref | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configs/bsp.ref b/configs/bsp.ref > index cb91c780516f..d20eb70afd45 100644 > --- a/configs/bsp.ref > +++ b/configs/bsp.ref > @@ -29,7 +29,7 @@ kernel_initrd: > Initrd support is not needed on most embedded systems. > For v8a, we use an initrd for the fastboot usecase. > variants: > - - condition: kconfig.PTXPlatformConfig()['ARCH_ARM64'] > + - condition: kconfig.PTXPlatformConfig().options['PLATFORM'] in ('v8a', 'v7a') > value: True > - value: False > > -- > 2.39.2 > > > -- Pengutronix e.K. | Dipl.-Ing. Robert Schwebel | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |