Re: [DistroKit] [PATCH v2 3/4] ptxconfig: create menu for DistroKit-specific rules

[Michael Olbrich <m.olbrich@pengutronix.de>]

On Mon, Jun 17, 2024 at 11:48:17AM +0200, Roland Hieber wrote:
> This way the main menu doesn't get cluttered up with random recipes.
> 
> Link: https://lore.distrokit.org/distrokit/20240613-whenever-enduring-698a9b93370b@thorsis.com/
> Suggested-by: Alexander Dahl <ada@thorsis.com>
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
> New patch in v2.
> ---
>  configs/ptxconfig      | 6 +++++-
>  rules/binary_inst.in   | 2 +-
>  rules/distrokit.in     | 5 +++++
>  rules/rauc-udev.in     | 2 +-
>  rules/repart-config.in | 2 +-
>  5 files changed, 13 insertions(+), 4 deletions(-)
>  create mode 100644 rules/distrokit.in
> 
> diff --git a/configs/ptxconfig b/configs/ptxconfig
> index f5ac373e61d2..fda7d198e6de 100644
> --- a/configs/ptxconfig
> +++ b/configs/ptxconfig
> @@ -2,8 +2,13 @@
>  # Automatically generated file; DO NOT EDIT.
>  # PTXdist 2024.05.0
>  #
> +
> +#
> +# DistroKit                     
> +#
>  PTXCONF_RAUC_UDEV=y
>  PTXCONF_REPART_CONFIG=y
> +# end of DistroKit                     
>  
>  #
>  # ------------------------------------
> @@ -207,7 +212,6 @@ PTXCONF_STRACE=y
>  #
>  # Root Filesystem               
>  #
> -# PTXCONF_BINARY_EXAMPLE is not set

Nit: this hunk should be in the next patch.

With that, for the whole series:

Reviewed-by: Michael Olbrich <m.olbrich@pengutronix.de>

Michael

>  # PTXCONF_FAKE_OVERLAYFS is not set
>  PTXCONF_INITMETHOD=y
>  # PTXCONF_INITMETHOD_BBINIT is not set
> diff --git a/rules/binary_inst.in b/rules/binary_inst.in
> index bbb989bed379..92c72baccbbe 100644
> --- a/rules/binary_inst.in
> +++ b/rules/binary_inst.in
> @@ -1,4 +1,4 @@
> -## SECTION=rootfs
> +## SECTION=distrokit
>  #
>  # This file is just an example how to install binaries to the root filesystem
>  # via ptxdist
> diff --git a/rules/distrokit.in b/rules/distrokit.in
> new file mode 100644
> index 000000000000..559a5bde0ecd
> --- /dev/null
> +++ b/rules/distrokit.in
> @@ -0,0 +1,5 @@
> +## SECTION=project_specific
> +
> +menu "DistroKit                     "
> +source "generated/distrokit.in"
> +endmenu
> diff --git a/rules/rauc-udev.in b/rules/rauc-udev.in
> index f960c537f58f..d18f1c3197d5 100644
> --- a/rules/rauc-udev.in
> +++ b/rules/rauc-udev.in
> @@ -1,4 +1,4 @@
> -## SECTION=project_specific
> +## SECTION=distrokit
>  
>  config RAUC_UDEV
>  	tristate
> diff --git a/rules/repart-config.in b/rules/repart-config.in
> index db9828f669f2..ea803c015978 100644
> --- a/rules/repart-config.in
> +++ b/rules/repart-config.in
> @@ -1,4 +1,4 @@
> -## SECTION=project_specific
> +## SECTION=distrokit
>  
>  config REPART_CONFIG
>  	tristate "repart-config"
> -- 
> 2.39.2
> 
> 
> 

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |