From: Robert Schwebel <r.schwebel@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH 1/4] v7a: barebox: enable ARM accelerated SHA1 routines
Date: Fri, 12 Jul 2024 16:30:45 +0200 [thread overview]
Message-ID: <ZpE-FZhgYujxfLQe@pengutronix.de> (raw)
In-Reply-To: <20240711110143.470379-1-a.fatoum@pengutronix.de>
series applied to next
On Thu, Jul 11, 2024 at 01:01:40PM +0200, Ahmad Fatoum wrote:
> All barebox defconfigs that enable generic SHA1 support also enable
> ARM-optimized SHA256 support. Enable ARM-optimized SHA1 as well for
> improved performance.
>
> It would be nice if we could disable generic SHA1 now, but that's not
> possible yet, because generic SHA1 support is selected by
> CONFIG_CMD_SHA1SUM, which we enable.
>
> Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de>
> ---
> configs/platform-v7a/barebox-am335x.config | 2 +-
> configs/platform-v7a/barebox-am335x.config.diff | 2 +-
> configs/platform-v7a/barebox-at91.config | 2 +-
> configs/platform-v7a/barebox-at91.config.diff | 2 +-
> configs/platform-v7a/barebox-mx6.config | 2 +-
> configs/platform-v7a/barebox-mx6.config.diff | 2 +-
> configs/platform-v7a/barebox-rpi2.config | 2 +-
> configs/platform-v7a/barebox-rpi2.config.diff | 2 +-
> configs/platform-v7a/barebox-stm32mp.config | 2 +-
> configs/platform-v7a/barebox-stm32mp.config.diff | 2 +-
> configs/platform-v7a/barebox-vexpress.config | 2 +-
> configs/platform-v7a/barebox-vexpress.config.diff | 2 +-
> configs/platform-v7a/barebox.config | 2 +-
> 13 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/configs/platform-v7a/barebox-am335x.config b/configs/platform-v7a/barebox-am335x.config
> index aeaf1192bdbb..61c17f70896d 100644
> --- a/configs/platform-v7a/barebox-am335x.config
> +++ b/configs/platform-v7a/barebox-am335x.config
> @@ -1038,7 +1038,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y
> # CONFIG_DIGEST_SHA384_GENERIC is not set
> # CONFIG_DIGEST_SHA512_GENERIC is not set
> CONFIG_DIGEST_HMAC_GENERIC=y
> -# CONFIG_DIGEST_SHA1_ARM is not set
> +CONFIG_DIGEST_SHA1_ARM=y
> CONFIG_DIGEST_SHA256_ARM=y
> CONFIG_CRYPTO_KEYSTORE=y
> # end of Crypto support
> diff --git a/configs/platform-v7a/barebox-am335x.config.diff b/configs/platform-v7a/barebox-am335x.config.diff
> index 8c6e7959fedf..f1d46b41cf9a 100644
> --- a/configs/platform-v7a/barebox-am335x.config.diff
> +++ b/configs/platform-v7a/barebox-am335x.config.diff
> @@ -1,4 +1,4 @@
> -dcf5e1fcb2504dfaa2c1441bc71bbdd2
> +e68dcd40a22e40e08bfbabe8f90da935
> # CONFIG_AM33XX_NET_BOOT is not set
> CONFIG_ARCH_AM33XX=y
> # CONFIG_ARCH_BCM283X is not set
> diff --git a/configs/platform-v7a/barebox-at91.config b/configs/platform-v7a/barebox-at91.config
> index dec985bc8a9e..c3aeee7125fe 100644
> --- a/configs/platform-v7a/barebox-at91.config
> +++ b/configs/platform-v7a/barebox-at91.config
> @@ -1042,7 +1042,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y
> # CONFIG_DIGEST_SHA384_GENERIC is not set
> # CONFIG_DIGEST_SHA512_GENERIC is not set
> # CONFIG_DIGEST_HMAC_GENERIC is not set
> -# CONFIG_DIGEST_SHA1_ARM is not set
> +CONFIG_DIGEST_SHA1_ARM=y
> CONFIG_DIGEST_SHA256_ARM=y
> # CONFIG_CRYPTO_KEYSTORE is not set
> # end of Crypto support
> diff --git a/configs/platform-v7a/barebox-at91.config.diff b/configs/platform-v7a/barebox-at91.config.diff
> index 9ebfb4771860..2aca21897016 100644
> --- a/configs/platform-v7a/barebox-at91.config.diff
> +++ b/configs/platform-v7a/barebox-at91.config.diff
> @@ -1,4 +1,4 @@
> -dcf5e1fcb2504dfaa2c1441bc71bbdd2
> +e68dcd40a22e40e08bfbabe8f90da935
> CONFIG_ARCH_AT91=y
> # CONFIG_ARCH_BCM283X is not set
> # CONFIG_ARCH_IMX is undefined
> diff --git a/configs/platform-v7a/barebox-mx6.config b/configs/platform-v7a/barebox-mx6.config
> index 945b4a903463..2a144c674e0a 100644
> --- a/configs/platform-v7a/barebox-mx6.config
> +++ b/configs/platform-v7a/barebox-mx6.config
> @@ -1226,7 +1226,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y
> # CONFIG_DIGEST_SHA384_GENERIC is not set
> # CONFIG_DIGEST_SHA512_GENERIC is not set
> CONFIG_DIGEST_HMAC_GENERIC=y
> -# CONFIG_DIGEST_SHA1_ARM is not set
> +CONFIG_DIGEST_SHA1_ARM=y
> CONFIG_DIGEST_SHA256_ARM=y
> CONFIG_CRYPTO_KEYSTORE=y
> # end of Crypto support
> diff --git a/configs/platform-v7a/barebox-mx6.config.diff b/configs/platform-v7a/barebox-mx6.config.diff
> index af14a2eed749..291a35edc4b9 100644
> --- a/configs/platform-v7a/barebox-mx6.config.diff
> +++ b/configs/platform-v7a/barebox-mx6.config.diff
> @@ -1,4 +1,4 @@
> -dcf5e1fcb2504dfaa2c1441bc71bbdd2
> +e68dcd40a22e40e08bfbabe8f90da935
> # CONFIG_ARCH_BCM283X is not set
> CONFIG_ARCH_HAS_FEC_IMX=y
> CONFIG_ARCH_HAS_IMX_GPT=y
> diff --git a/configs/platform-v7a/barebox-rpi2.config b/configs/platform-v7a/barebox-rpi2.config
> index b00b8f7b29a5..63035910c2a3 100644
> --- a/configs/platform-v7a/barebox-rpi2.config
> +++ b/configs/platform-v7a/barebox-rpi2.config
> @@ -1008,7 +1008,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y
> # CONFIG_DIGEST_SHA384_GENERIC is not set
> # CONFIG_DIGEST_SHA512_GENERIC is not set
> # CONFIG_DIGEST_HMAC_GENERIC is not set
> -# CONFIG_DIGEST_SHA1_ARM is not set
> +CONFIG_DIGEST_SHA1_ARM=y
> CONFIG_DIGEST_SHA256_ARM=y
> # CONFIG_CRYPTO_KEYSTORE is not set
> # end of Crypto support
> diff --git a/configs/platform-v7a/barebox-rpi2.config.diff b/configs/platform-v7a/barebox-rpi2.config.diff
> index 82fa555afacc..b2b34df1d863 100644
> --- a/configs/platform-v7a/barebox-rpi2.config.diff
> +++ b/configs/platform-v7a/barebox-rpi2.config.diff
> @@ -1,4 +1,4 @@
> -dcf5e1fcb2504dfaa2c1441bc71bbdd2
> +e68dcd40a22e40e08bfbabe8f90da935
> CONFIG_ARM_ASM_UNIFIED=y
> # CONFIG_CMD_NVMEM is not set
> CONFIG_DRIVER_NET_BCMGENET=y
> diff --git a/configs/platform-v7a/barebox-stm32mp.config b/configs/platform-v7a/barebox-stm32mp.config
> index 898d8ed979c3..afba652187a9 100644
> --- a/configs/platform-v7a/barebox-stm32mp.config
> +++ b/configs/platform-v7a/barebox-stm32mp.config
> @@ -990,7 +990,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y
> # CONFIG_DIGEST_SHA384_GENERIC is not set
> # CONFIG_DIGEST_SHA512_GENERIC is not set
> CONFIG_DIGEST_HMAC_GENERIC=y
> -# CONFIG_DIGEST_SHA1_ARM is not set
> +CONFIG_DIGEST_SHA1_ARM=y
> CONFIG_DIGEST_SHA256_ARM=y
> # CONFIG_CRYPTO_KEYSTORE is not set
> # end of Crypto support
> diff --git a/configs/platform-v7a/barebox-stm32mp.config.diff b/configs/platform-v7a/barebox-stm32mp.config.diff
> index 1d31bc529248..be07a2a27b1f 100644
> --- a/configs/platform-v7a/barebox-stm32mp.config.diff
> +++ b/configs/platform-v7a/barebox-stm32mp.config.diff
> @@ -1,4 +1,4 @@
> -dcf5e1fcb2504dfaa2c1441bc71bbdd2
> +e68dcd40a22e40e08bfbabe8f90da935
> # CONFIG_ARCH_BCM283X is not set
> CONFIG_ARCH_HAS_RESET_CONTROLLER=y
> CONFIG_ARCH_NR_GPIO=416
> diff --git a/configs/platform-v7a/barebox-vexpress.config b/configs/platform-v7a/barebox-vexpress.config
> index 2c45042c62b7..ac4bff2d9a9d 100644
> --- a/configs/platform-v7a/barebox-vexpress.config
> +++ b/configs/platform-v7a/barebox-vexpress.config
> @@ -949,7 +949,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y
> # CONFIG_DIGEST_SHA384_GENERIC is not set
> # CONFIG_DIGEST_SHA512_GENERIC is not set
> # CONFIG_DIGEST_HMAC_GENERIC is not set
> -# CONFIG_DIGEST_SHA1_ARM is not set
> +CONFIG_DIGEST_SHA1_ARM=y
> CONFIG_DIGEST_SHA256_ARM=y
> # CONFIG_CRYPTO_KEYSTORE is not set
> # end of Crypto support
> diff --git a/configs/platform-v7a/barebox-vexpress.config.diff b/configs/platform-v7a/barebox-vexpress.config.diff
> index a5f70ff8f594..103a9e77df62 100644
> --- a/configs/platform-v7a/barebox-vexpress.config.diff
> +++ b/configs/platform-v7a/barebox-vexpress.config.diff
> @@ -1,4 +1,4 @@
> -dcf5e1fcb2504dfaa2c1441bc71bbdd2
> +e68dcd40a22e40e08bfbabe8f90da935
> CONFIG_AMBA_SP804=y
> # CONFIG_ARCH_BCM283X is not set
> CONFIG_ARCH_VEXPRESS=y
> diff --git a/configs/platform-v7a/barebox.config b/configs/platform-v7a/barebox.config
> index e678fff7e57b..a562d8e8bf73 100644
> --- a/configs/platform-v7a/barebox.config
> +++ b/configs/platform-v7a/barebox.config
> @@ -1002,7 +1002,7 @@ CONFIG_DIGEST_SHA1_GENERIC=y
> # CONFIG_DIGEST_SHA384_GENERIC is not set
> # CONFIG_DIGEST_SHA512_GENERIC is not set
> # CONFIG_DIGEST_HMAC_GENERIC is not set
> -# CONFIG_DIGEST_SHA1_ARM is not set
> +CONFIG_DIGEST_SHA1_ARM=y
> CONFIG_DIGEST_SHA256_ARM=y
> # CONFIG_CRYPTO_KEYSTORE is not set
> # end of Crypto support
> --
> 2.39.2
>
>
>
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
prev parent reply other threads:[~2024-07-12 14:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-11 11:01 Ahmad Fatoum
2024-07-11 11:01 ` [DistroKit] [PATCH 2/4] v7a: barebox: don't activate first console Ahmad Fatoum
2024-07-11 11:01 ` [DistroKit] [PATCH 3/4] v7a: barebox: don't use root=PARTUUID= when booting from SD/eMMC Ahmad Fatoum
2024-07-11 11:01 ` [DistroKit] [PATCH 4/4] v7a: barebox: am335x-mlo: document some unusual kconfig options Ahmad Fatoum
2024-07-12 14:30 ` Robert Schwebel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZpE-FZhgYujxfLQe@pengutronix.de \
--to=r.schwebel@pengutronix.de \
--cc=a.fatoum@pengutronix.de \
--cc=distrokit@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox