From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 12 Jul 2024 17:41:22 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sSIOg-0048ch-1J for lore@lore.pengutronix.de; Fri, 12 Jul 2024 17:41:22 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sSIOf-0004UW-Vq; Fri, 12 Jul 2024 17:41:21 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sSIOd-0004UB-FG; Fri, 12 Jul 2024 17:41:19 +0200 Received: from [2a0a:edc0:2:b01:1d::c5] (helo=pty.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sSIOd-0091yb-2D; Fri, 12 Jul 2024 17:41:19 +0200 Received: from rsc by pty.whiteo.stw.pengutronix.de with local (Exim 4.96) (envelope-from ) id 1sSIOc-00CM3B-38; Fri, 12 Jul 2024 17:41:18 +0200 Date: Fri, 12 Jul 2024 17:41:18 +0200 From: Robert Schwebel To: Ahmad Fatoum Message-ID: References: <20240712153627.58995-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240712153627.58995-1-a.fatoum@pengutronix.de> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain Subject: Re: [DistroKit] [PATCH] fixup! v7a: barebox: am335x-mlo: document some unusual kconfig options X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false Added, next test run is ... well, running .... On Fri, Jul 12, 2024 at 05:36:27PM +0200, Ahmad Fatoum wrote: > v7a: barebox: restrict bsp.ref condition to applicable platforms > > While barebox can be built for x86_64 and MIPS, we don't currently do so, > so the condition in the bsp.ref shouldn't assume that all platforms > have a barebox config. > > Signed-off-by: Ahmad Fatoum > --- > configs/bsp.ref | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/configs/bsp.ref b/configs/bsp.ref > index 5b5b4a763b15..2f64107ef52a 100644 > --- a/configs/bsp.ref > +++ b/configs/bsp.ref > @@ -53,7 +53,9 @@ barebox_arm_optimized_string_functions: > needs to fit into on-chip SRAM to be able to set up DRAM and thus > we use the smaller C implementation instead. > variants: > - - condition: kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE'] > + - condition: | > + kconfig.have_barebox_config() and > + kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE'] > value: False > - value: True > > @@ -67,7 +69,9 @@ barebox_gpt_support: > barebox, we only need GPT support later on in the second stage > barebox-am335x configuration. > variants: > - - condition: kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE'] > + - condition: | > + kconfig.have_barebox_config() and > + kconfig.BareboxConfig()['ARCH_OMAP'] and kconfig.BareboxConfig()['SHELL_NONE'] > value: False > - value: True > > -- > 2.39.2 > > > -- Pengutronix e.K. | Dipl.-Ing. Robert Schwebel | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |