Re: [DistroKit] [PATCH 1/5] v8a: enable initrd generation

[Johannes Zink <j.zink@pengutronix.de>]

Hi Ahmad,

On 6/6/23 16:37, Ahmad Fatoum wrote:
> On 06.06.23 16:31, Johannes Zink wrote:
>> also generate rootfs as cpio.gz, as this allows loading it as initramfs.
> 
> You enable both CONFIG_RD_GZIP and CONFIG_RD_ZSTD (which I am fine with),
> but you decide here for cpio.gz. Any particular reason?

afaik ZSTD support is rather new and I wanted to have maximum flexibility when 
reusing the initramfs, even with older kernels - i.e. being able to mix a 
ptxdist-built initramfs with older kernels. I opted to also support zstd, to 
allow booting future initramfs' on current kernels, should gzip support ever be 
dropped in the future.

However, I think we could probably drop the zstd support, if you are concerned 
about image size.

Johannes

> 
>>
>> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
>> ---
>>   configs/platform-v8a/platformconfig | 10 +++++++++-
>>   1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/configs/platform-v8a/platformconfig b/configs/platform-v8a/platformconfig
>> index 4e479660f6b7..4d7dfeae9d66 100644
>> --- a/configs/platform-v8a/platformconfig
>> +++ b/configs/platform-v8a/platformconfig
>> @@ -261,7 +261,15 @@ PTXCONF_IMAGE_KERNEL_INSTALL_EARLY=y
>>   
>>   # PTXCONF_IMAGE_RAUC is not set
>>   PTXCONF_IMAGE_ROCK3A=y
>> -# PTXCONF_IMAGE_ROOT_CPIO is not set
>> +PTXCONF_IMAGE_ROOT_CPIO=y
>> +# PTXCONF_IMAGE_ROOT_CPIO_COMPRESSION_MODE_NONE is not set
>> +PTXCONF_IMAGE_ROOT_CPIO_COMPRESSION_MODE_GZ=y
>> +# PTXCONF_IMAGE_ROOT_CPIO_COMPRESSION_MODE_ZSTD is not set
>> +# PTXCONF_IMAGE_ROOT_CPIO_COMPRESSION_MODE_XZ is not set
>> +# PTXCONF_IMAGE_ROOT_CPIO_COMPRESSION_MODE_LZOP is not set
>> +# PTXCONF_IMAGE_ROOT_CPIO_CUSTOM_COMPRESSION is not set
>> +PTXCONF_IMAGE_ROOT_CPIO_COMPRESSION_SUFFIX=".gz"
>> +PTXCONF_IMAGE_ROOT_CPIO_COMPRESSION_UTIL="gzip"
>>   PTXCONF_IMAGE_ROOT_EXT=y
>>   PTXCONF_IMAGE_ROOT_EXT_SIZE="125%"
>>   # PTXCONF_IMAGE_ROOT_EXT_EXT2 is not set
>>
> 

-- 
Pengutronix e.K.                | Johannes Zink                  |
Steuerwalder Str. 21            | https://www.pengutronix.de/    |
31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |