* [DistroKit] [PATCH] rauc-udev: Add missing comma between tokens in rules file
@ 2025-09-18 11:54 Alexander Dahl
2025-09-18 12:02 ` Robert Schwebel
0 siblings, 1 reply; 2+ messages in thread
From: Alexander Dahl @ 2025-09-18 11:54 UTC (permalink / raw)
To: distrokit; +Cc: Leonard Göhrs, Fabian Pflug
`udevadm verify` threw warnings like this:
/usr/lib/udev/rules.d/90-rauc-partitions.rules:19 style: a comma between tokens is expected.
/usr/lib/udev/rules.d/90-rauc-partitions.rules: udev rules have style issues.
Fixes: bc056fb67ed5 ("rauc-udev: add entry for TQ MBa8MPxL board")
Fixes: 3efb9034d430 ("v8a: tqma93: Add boot_disk")
Signed-off-by: Alexander Dahl <ada@thorsis.com>
---
projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules b/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules
index f78c3e4..c5930c7 100644
--- a/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules
+++ b/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules
@@ -16,8 +16,8 @@ ENV{OF_BASE_COMPATIBLE}=="*ti,am335x-bone-black*", ENV{ID_PATH}=="platform-48060
ENV{OF_BASE_COMPATIBLE}=="*raspberrypi,3-model-b*", ENV{ID_PATH}=="platform-3f202000.mmc", TAG+="boot_disk"
ENV{OF_BASE_COMPATIBLE}=="*riot,imx6s-riotboard*", ENV{ID_PATH}=="platform-2198000.mmc", TAG+="boot_disk"
ENV{OF_BASE_COMPATIBLE}=="*radxa,rock3a*", ENV{ID_PATH}=="platform-fe2b0000.mmc", TAG+="boot_disk"
-ENV{OF_BASE_COMPATIBLE}=="*tq,imx8mp-tqma8mpql-mba8mpxl*" ENV{ID_PATH}=="platform-30b50000.mmc", TAG+="boot_disk"
-ENV{OF_BASE_COMPATIBLE}=="*tq,imx93-tqma9352-mba93xxca*" ENV{ID_PATH}=="platform-42860000.mmc", TAG+="boot_disk"
+ENV{OF_BASE_COMPATIBLE}=="*tq,imx8mp-tqma8mpql-mba8mpxl*", ENV{ID_PATH}=="platform-30b50000.mmc", TAG+="boot_disk"
+ENV{OF_BASE_COMPATIBLE}=="*tq,imx93-tqma9352-mba93xxca*", ENV{ID_PATH}=="platform-42860000.mmc", TAG+="boot_disk"
# second part: create /dev/disk/by-usage/ symlinks
ENV{DEVTYPE}!="partition", GOTO="rauc_partitions_end"
base-commit: 9f9ad1e35708f324f6838311dc22f5f0871a5846
--
2.39.5
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [DistroKit] [PATCH] rauc-udev: Add missing comma between tokens in rules file
2025-09-18 11:54 [DistroKit] [PATCH] rauc-udev: Add missing comma between tokens in rules file Alexander Dahl
@ 2025-09-18 12:02 ` Robert Schwebel
0 siblings, 0 replies; 2+ messages in thread
From: Robert Schwebel @ 2025-09-18 12:02 UTC (permalink / raw)
To: Alexander Dahl; +Cc: Leonard Göhrs, distrokit, Fabian Pflug
Applied to next
On Thu, Sep 18, 2025 at 01:54:35PM +0200, Alexander Dahl wrote:
> `udevadm verify` threw warnings like this:
>
> /usr/lib/udev/rules.d/90-rauc-partitions.rules:19 style: a comma between tokens is expected.
> /usr/lib/udev/rules.d/90-rauc-partitions.rules: udev rules have style issues.
>
> Fixes: bc056fb67ed5 ("rauc-udev: add entry for TQ MBa8MPxL board")
> Fixes: 3efb9034d430 ("v8a: tqma93: Add boot_disk")
> Signed-off-by: Alexander Dahl <ada@thorsis.com>
> ---
> projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules b/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules
> index f78c3e4..c5930c7 100644
> --- a/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules
> +++ b/projectroot/usr/lib/udev/rules.d/90-rauc-partitions.rules
> @@ -16,8 +16,8 @@ ENV{OF_BASE_COMPATIBLE}=="*ti,am335x-bone-black*", ENV{ID_PATH}=="platform-48060
> ENV{OF_BASE_COMPATIBLE}=="*raspberrypi,3-model-b*", ENV{ID_PATH}=="platform-3f202000.mmc", TAG+="boot_disk"
> ENV{OF_BASE_COMPATIBLE}=="*riot,imx6s-riotboard*", ENV{ID_PATH}=="platform-2198000.mmc", TAG+="boot_disk"
> ENV{OF_BASE_COMPATIBLE}=="*radxa,rock3a*", ENV{ID_PATH}=="platform-fe2b0000.mmc", TAG+="boot_disk"
> -ENV{OF_BASE_COMPATIBLE}=="*tq,imx8mp-tqma8mpql-mba8mpxl*" ENV{ID_PATH}=="platform-30b50000.mmc", TAG+="boot_disk"
> -ENV{OF_BASE_COMPATIBLE}=="*tq,imx93-tqma9352-mba93xxca*" ENV{ID_PATH}=="platform-42860000.mmc", TAG+="boot_disk"
> +ENV{OF_BASE_COMPATIBLE}=="*tq,imx8mp-tqma8mpql-mba8mpxl*", ENV{ID_PATH}=="platform-30b50000.mmc", TAG+="boot_disk"
> +ENV{OF_BASE_COMPATIBLE}=="*tq,imx93-tqma9352-mba93xxca*", ENV{ID_PATH}=="platform-42860000.mmc", TAG+="boot_disk"
>
> # second part: create /dev/disk/by-usage/ symlinks
> ENV{DEVTYPE}!="partition", GOTO="rauc_partitions_end"
>
> base-commit: 9f9ad1e35708f324f6838311dc22f5f0871a5846
> --
> 2.39.5
>
>
>
--
Pengutronix e.K. | Dipl.-Ing. Robert Schwebel |
Steuerwalder Str. 21 | https://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-9 |
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-18 12:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-18 11:54 [DistroKit] [PATCH] rauc-udev: Add missing comma between tokens in rules file Alexander Dahl
2025-09-18 12:02 ` Robert Schwebel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox