DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Johannes Zink <j.zink@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>, distrokit@pengutronix.de
Cc: patchwork-jzi@pengutronix.de
Subject: Re: [DistroKit] [PATCH 3/5] v8a: images: generate sparse images from rock3a initramfs, kernel and dtb
Date: Tue, 6 Jun 2023 16:49:26 +0200	[thread overview]
Message-ID: <b3b2d96f-0f35-60c2-4e8d-a9f5ceefa250@pengutronix.de> (raw)
In-Reply-To: <dcf1fc63-810c-5bb3-0e6a-15358c80539c@pengutronix.de>

On 6/6/23 16:42, Ahmad Fatoum wrote:
> On 06.06.23 16:41, Ahmad Fatoum wrote:
>> On 06.06.23 16:31, Johannes Zink wrote:
>>> This allows to load the images to barebox using android fastboot, since
>>> otherwise the sparse header is missing and the image size is not
>>> properly aligned as required by fastboot.
>>
>> IME fastboot just complains and transfers the files anyway. In that
>> case building sparse images just adds complication. Did your fastboot
>> command fail without this change?
>>
>>>
>>> Signed-off-by: Johannes Zink <j.zink@pengutronix.de>
>>> ---
>>>   configs/platform-v8a/config/images/rock3a.config | 21 +++++++++++++++++++++
>>>   1 file changed, 21 insertions(+)
>>>
>>> diff --git a/configs/platform-v8a/config/images/rock3a.config b/configs/platform-v8a/config/images/rock3a.config
>>> index 522d82cdc9c9..cb0c7c4e575d 100644
>>> --- a/configs/platform-v8a/config/images/rock3a.config
>>> +++ b/configs/platform-v8a/config/images/rock3a.config
>>> @@ -44,3 +44,24 @@ image barebox-rock3a.norimg {
>>>   		image = "barebox-rock3a.img"
>>>   	}
>>>   }
>>> +
>>> +image initramfs-sparse.img {
>>> +	android-sparse {
>>> +		image = "root.cpio.gz"
>>> +		block-size = 4k
>>> +	}
>>> +}
>>> +
>>> +image kernel-sparse.img {
>>> +	android-sparse {
>>> +		image = "linuximage"
>>> +		block-size = 4k
>>> +	}
>>> +}
> 
> Also, these two aren't rock3a specific, so they shouldn't be here
> especially not with such generic sounding names.

ack, gonna move them to a separate config for v2 of this series. Though, I 
think they should keep their generic names, as they can be used across all 
other v8a targets.

Johannes

> 
>>> +
>>> +image dtb-rock3a-sparse.img {
>>> +	android-sparse {
>>> +		image = "rk3568-rock-3a.dtb"
>>> +		block-size = 4k
>>> +	}
>>> +}
>>>
>>
> 

-- 
Pengutronix e.K.                | Johannes Zink                  |
Steuerwalder Str. 21            | https://www.pengutronix.de/    |
31137 Hildesheim, Germany       | Phone: +49-5121-206917-0       |
Amtsgericht Hildesheim, HRA 2686| Fax:   +49-5121-206917-5555    |




  reply	other threads:[~2023-06-06 14:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-06 14:31 [DistroKit] [PATCH 0/5] enable uploading kernel, dtb and initramfs over fastboot and boot it on Rock3A Johannes Zink
2023-06-06 14:31 ` [DistroKit] [PATCH 1/5] v8a: enable initrd generation Johannes Zink
2023-06-06 14:37   ` Ahmad Fatoum
2023-06-06 14:44     ` Johannes Zink
2023-06-06 14:59       ` Jan Lübbe
2023-06-06 15:02         ` Johannes Zink
2023-06-06 14:31 ` [DistroKit] [PATCH 2/5] v8a: kernel: enable initramfs in kernel config Johannes Zink
2023-06-06 14:37   ` Ahmad Fatoum
2023-06-06 14:31 ` [DistroKit] [PATCH 3/5] v8a: images: generate sparse images from rock3a initramfs, kernel and dtb Johannes Zink
2023-06-06 14:41   ` Ahmad Fatoum
2023-06-06 14:42     ` Ahmad Fatoum
2023-06-06 14:49       ` Johannes Zink [this message]
2023-06-06 14:54         ` Ahmad Fatoum
2023-06-06 14:47     ` Johannes Zink
2023-06-06 14:51       ` Ahmad Fatoum
2023-06-06 15:04         ` Johannes Zink
2023-06-06 15:26           ` Ahmad Fatoum
2023-06-08  7:28             ` Ahmad Fatoum
2023-06-06 14:31 ` [DistroKit] [PATCH 4/5] v8a: barebox: enable loading kernel, dtb and initrd via fastboot Johannes Zink
2023-06-06 14:44   ` Ahmad Fatoum
2023-06-06 14:54     ` Johannes Zink
2023-06-08  7:36       ` Ahmad Fatoum
2023-06-09  6:26         ` Johannes Zink
2023-06-06 15:04     ` Jan Lübbe
2023-06-06 15:14       ` Johannes Zink
2023-06-06 15:16         ` Jan Lübbe
2023-06-06 14:31 ` [DistroKit] [PATCH 5/5] v8a: barebox: add a boot target for fastboot loaded image files Johannes Zink
2023-06-06 14:47   ` Ahmad Fatoum
2023-06-06 15:07     ` Jan Lübbe
2023-06-06 15:13       ` Johannes Zink
2023-06-09  9:53       ` Johannes Zink

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=b3b2d96f-0f35-60c2-4e8d-a9f5ceefa250@pengutronix.de \
    --to=j.zink@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    --cc=patchwork-jzi@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox