Re: [DistroKit] [PATCH v2 6/7] v7a_noneon: barebox-at91: enable DSA support

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

On 07.07.23 13:08, Oleksij Rempel wrote:
> Enable DSA support and related KSZ9477 switch driver. At least KSZ9477 EVB need
> it for proper netboot support.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

> ---
>  .../platform-v7a_noneon/barebox-at91.config   | 45 ++++++++++++++++++-
>  .../barebox-at91.config.diff                  | 39 +++++-----------
>  2 files changed, 54 insertions(+), 30 deletions(-)
> 
> diff --git a/configs/platform-v7a_noneon/barebox-at91.config b/configs/platform-v7a_noneon/barebox-at91.config
> index 8736816..d66e099 100644
> --- a/configs/platform-v7a_noneon/barebox-at91.config
> +++ b/configs/platform-v7a_noneon/barebox-at91.config
> @@ -418,6 +418,7 @@ CONFIG_CMD_MW=y
>  CONFIG_CMD_DETECT=y
>  CONFIG_CMD_FLASH=y
>  CONFIG_CMD_GPIO=y
> +# CONFIG_CMD_I2C is not set
>  CONFIG_CMD_LED=y
>  CONFIG_CMD_NAND=y
>  # CONFIG_CMD_NANDTEST is not set
> @@ -466,6 +467,9 @@ CONFIG_NET_FASTBOOT=y
>  #
>  # Drivers
>  #
> +CONFIG_REGMAP_FORMATTED=y
> +CONFIG_REGMAP_I2C=y
> +CONFIG_REGMAP_SPI=y
>  CONFIG_OFTREE=y
>  CONFIG_OFTREE_MEM_GENERIC=y
>  CONFIG_DTC=y
> @@ -538,7 +542,11 @@ CONFIG_NET_USB_ASIX=y
>  CONFIG_USB_NET_AX88179_178A=y
>  CONFIG_NET_USB_SMSC95XX=y
>  CONFIG_NET_USB_RTL8152=y
> -# CONFIG_DSA is not set
> +CONFIG_DSA=y
> +# CONFIG_DRIVER_NET_KSZ8873 is not set
> +CONFIG_DRIVER_NET_KSZ9477=y
> +# CONFIG_DRIVER_NET_SJA1105 is not set
> +# CONFIG_DRIVER_NET_DSA_REALTEK is not set
>  # end of Network drivers
>  
>  #
> @@ -553,7 +561,18 @@ CONFIG_SPI_ATMEL_QUADSPI=y
>  # CONFIG_DRIVER_SPI_LITEX_SPIFLASH is not set
>  # end of SPI drivers
>  
> -# CONFIG_I2C is not set
> +CONFIG_I2C=y
> +
> +#
> +# I2C Hardware Bus support
> +#
> +# CONFIG_I2C_GPIO is not set
> +# CONFIG_I2C_AT91 is not set
> +# CONFIG_I2C_DESIGNWARE is not set
> +# CONFIG_I2C_MV64XXX is not set
> +# end of I2C Hardware Bus support
> +
> +# CONFIG_I2C_MUX is not set
>  CONFIG_MTD=y
>  CONFIG_MTD_WRITE=y
>  CONFIG_MTD_OOB_DEVICE=y
> @@ -624,7 +643,9 @@ CONFIG_USB_OHCI_AT91=y
>  #
>  # USB Miscellaneous drivers
>  #
> +# CONFIG_USB_HUB_USB251XB is not set
>  # CONFIG_USB_ONBOARD_HUB is not set
> +# CONFIG_TYPEC_TUSB320 is not set
>  CONFIG_USB_GADGET=y
>  CONFIG_USB_GADGET_DUALSPEED=y
>  CONFIG_USB_GADGET_DRIVER_AT91=y
> @@ -680,9 +701,23 @@ CONFIG_CLOCKSOURCE_ARM_ARCHITECTED_TIMER=y
>  #
>  # Multifunction device drivers
>  #
> +# CONFIG_MFD_ACT8846 is not set
> +# CONFIG_MFD_DA9053 is not set
> +# CONFIG_MFD_DA9063 is not set
> +# CONFIG_MFD_LP3972 is not set
>  # CONFIG_MFD_MC13XXX is not set
> +# CONFIG_MFD_MC34704 is not set
> +# CONFIG_MFD_MC9SDZ60 is not set
> +# CONFIG_MFD_STMPE is not set
>  CONFIG_MFD_SYSCON=y
> +# CONFIG_MFD_TWL4030 is not set
> +# CONFIG_MFD_TWL6030 is not set
> +# CONFIG_MFD_STPMIC1 is not set
> +# CONFIG_MFD_RN568PMIC is not set
>  # CONFIG_MFD_ATMEL_FLEXCOM is not set
> +# CONFIG_MFD_RK808 is not set
> +# CONFIG_MFD_AXP20X_I2C is not set
> +# CONFIG_MFD_ROHM_BD718XX is not set
>  CONFIG_MFD_ATMEL_SMC=y
>  # end of Multifunction device drivers
>  
> @@ -702,17 +737,20 @@ CONFIG_LED_GPIO_OF=y
>  # CONFIG_LED_GPIO_RGB is not set
>  # CONFIG_LED_GPIO_BICOLOR is not set
>  CONFIG_LED_TRIGGERS=y
> +# CONFIG_LED_PCA955X is not set
>  
>  #
>  # EEPROM support
>  #
>  # CONFIG_EEPROM_AT25 is not set
> +# CONFIG_EEPROM_AT24 is not set
>  # end of EEPROM support
>  
>  #
>  # Input device support
>  #
>  # CONFIG_KEYBOARD_GPIO is not set
> +# CONFIG_KEYBOARD_QT1070 is not set
>  # CONFIG_KEYBOARD_USB is not set
>  # CONFIG_INPUT_SPECIALKEYS is not set
>  # end of Input device support
> @@ -734,7 +772,10 @@ CONFIG_GPIOLIB=y
>  # CONFIG_GPIO_74164 is not set
>  # CONFIG_GPIO_74XX_MMIO is not set
>  # CONFIG_GPIO_GENERIC_PLATFORM is not set
> +# CONFIG_GPIO_PCA953X is not set
> +# CONFIG_GPIO_PCF857X is not set
>  # CONFIG_GPIO_DESIGNWARE is not set
> +# CONFIG_GPIO_SX150X is not set
>  # CONFIG_GPIO_SIFIVE is not set
>  # CONFIG_GPIO_LATCH is not set
>  # end of GPIO
> diff --git a/configs/platform-v7a_noneon/barebox-at91.config.diff b/configs/platform-v7a_noneon/barebox-at91.config.diff
> index 635e39d..2958432 100644
> --- a/configs/platform-v7a_noneon/barebox-at91.config.diff
> +++ b/configs/platform-v7a_noneon/barebox-at91.config.diff
> @@ -29,7 +29,7 @@ CONFIG_CMD_AT91_BOOT_TEST=y
>  # CONFIG_CMD_BOOTZ is not set
>  # CONFIG_CMD_BTHREAD is not set
>  # CONFIG_CMD_CLK is not set
> -# CONFIG_CMD_I2C is undefined
> +# CONFIG_CMD_I2C is not set
>  # CONFIG_CMD_IMD is not set
>  # CONFIG_CMD_MEMTEST is not set
>  # CONFIG_CMD_MENU is not set
> @@ -61,24 +61,25 @@ CONFIG_DEBUG_AT91_UART_BASE=0xffffee00
>  # CONFIG_DEBUG_PBL is not set
>  # CONFIG_DEFAULT_ENVIRONMENT_GENERIC_NEW_MENU is undefined
>  # CONFIG_DIGEST_SHA1_GENERIC is not set
> +# CONFIG_DRIVER_NET_DSA_REALTEK is not set
> +# CONFIG_DRIVER_NET_KSZ8873 is not set
> +CONFIG_DRIVER_NET_KSZ9477=y
>  CONFIG_DRIVER_NET_MACB=y
>  CONFIG_DRIVER_NET_MICREL=y
> +# CONFIG_DRIVER_NET_SJA1105 is not set
>  CONFIG_DRIVER_SERIAL_ATMEL=y
>  CONFIG_DRIVER_SPI_ATMEL=y
>  # CONFIG_DRIVER_SPI_FSL_QUADSPI is not set
>  # CONFIG_DRIVER_SPI_GPIO is not set
> -# CONFIG_EEPROM_AT24 is undefined
> +CONFIG_DSA=y
>  # CONFIG_FIRMWARE is undefined
>  CONFIG_FS_UBIFS=y
>  CONFIG_FS_UBIFS_COMPRESSION_LZO=y
>  # CONFIG_FS_UBIFS_COMPRESSION_ZLIB is not set
>  CONFIG_FS_UBIFS_COMPRESSION_ZSTD=y
>  CONFIG_GENERIC_ALLOCATOR=y
> -# CONFIG_GPIO_PCA953X is undefined
> -# CONFIG_GPIO_PCF857X is undefined
>  # CONFIG_GPIO_PL061 is undefined
>  # CONFIG_GPIO_RASPBERRYPI_EXP is undefined
> -# CONFIG_GPIO_SX150X is undefined
>  # CONFIG_GPIO_WATCHDOG is undefined
>  CONFIG_HAS_MACB=y
>  CONFIG_HAVE_AT91SAM9_RST=y
> @@ -88,18 +89,13 @@ CONFIG_HAVE_AT91_USB_CLK=y
>  CONFIG_HAVE_AT91_UTMI=y
>  # CONFIG_HAVE_DIGEST_SHA1 is undefined
>  # CONFIG_HWRNG is not set
> -# CONFIG_I2C is not set
>  # CONFIG_I2C_ALGOBIT is undefined
> +# CONFIG_I2C_AT91 is not set
>  # CONFIG_I2C_BCM283X is undefined
> -# CONFIG_I2C_DESIGNWARE is undefined
> -# CONFIG_I2C_GPIO is undefined
> -# CONFIG_I2C_MUX is undefined
> -# CONFIG_I2C_MV64XXX is undefined
> +# CONFIG_I2C_GPIO is not set
>  # CONFIG_IMAGE_COMPRESSION_LZO is not set
>  CONFIG_IMAGE_COMPRESSION_NONE=y
>  CONFIG_IMD_TARGET=y
> -# CONFIG_KEYBOARD_QT1070 is undefined
> -# CONFIG_LED_PCA955X is undefined
>  # CONFIG_LIBFDT is undefined
>  CONFIG_LIBSCAN=y
>  CONFIG_LIBUBIGEN=y
> @@ -131,22 +127,8 @@ CONFIG_MCI_SDHCI=y
>  # CONFIG_MCI_STARTUP is not set
>  # CONFIG_MEMTEST is undefined
>  # CONFIG_MENUTREE is undefined
> -# CONFIG_MFD_ACT8846 is undefined
>  CONFIG_MFD_ATMEL_SMC=y
> -# CONFIG_MFD_AXP20X_I2C is undefined
> -# CONFIG_MFD_DA9053 is undefined
> -# CONFIG_MFD_DA9063 is undefined
> -# CONFIG_MFD_LP3972 is undefined
> -# CONFIG_MFD_MC34704 is undefined
> -# CONFIG_MFD_MC9SDZ60 is undefined
> -# CONFIG_MFD_RK808 is undefined
> -# CONFIG_MFD_RN568PMIC is undefined
> -# CONFIG_MFD_ROHM_BD718XX is undefined
> -# CONFIG_MFD_STMPE is undefined
> -# CONFIG_MFD_STPMIC1 is undefined
>  CONFIG_MFD_SYSCON=y
> -# CONFIG_MFD_TWL4030 is undefined
> -# CONFIG_MFD_TWL6030 is undefined
>  CONFIG_MICREL_PHY=y
>  # CONFIG_MMUINFO is undefined
>  CONFIG_MTD_M25P80=y
> @@ -175,6 +157,9 @@ CONFIG_PINCTRL_AT91=y
>  CONFIG_PINCTRL_AT91PIO4=y
>  # CONFIG_PINCTRL_BCM283X is undefined
>  CONFIG_PROMPT="barebox:"
> +CONFIG_REGMAP_FORMATTED=y
> +CONFIG_REGMAP_I2C=y
> +CONFIG_REGMAP_SPI=y
>  # CONFIG_REGULATOR_ANATOP is not set
>  # CONFIG_REGULATOR_BCM283X is undefined
>  CONFIG_REGULATOR_FIXED=y
> @@ -193,12 +178,10 @@ CONFIG_SPI_MEM=y
>  # CONFIG_SYSTEMD_OF_WATCHDOG is undefined
>  CONFIG_SYSTEM_PARTITIONS=y
>  # CONFIG_THUMB2_BAREBOX is undefined
> -# CONFIG_TYPEC_TUSB320 is undefined
>  CONFIG_UBIFORMAT=y
>  CONFIG_USB_EHCI_ATMEL=y
>  CONFIG_USB_GADGET_DRIVER_AT91=y
>  CONFIG_USB_GADGET_DUALSPEED=y
> -# CONFIG_USB_HUB_USB251XB is undefined
>  CONFIG_USB_NET_AX88179_178A=y
>  CONFIG_USB_OHCI_AT91=y
>  # CONFIG_USB_STORAGE is not set

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |