From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 01 Aug 2024 12:13:13 +0200 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1sZSo5-00564O-1Q for lore@lore.pengutronix.de; Thu, 01 Aug 2024 12:13:13 +0200 Received: from localhost ([127.0.0.1] helo=metis.whiteo.stw.pengutronix.de) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sZSo4-0005sU-NS; Thu, 01 Aug 2024 12:13:12 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.whiteo.stw.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1sZSo2-0005sD-6k; Thu, 01 Aug 2024 12:13:10 +0200 Message-ID: Date: Thu, 1 Aug 2024 12:13:09 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird To: =?UTF-8?Q?Uwe_Kleine-K=C3=B6nig?= References: <20240731223538.3008673-2-uwe@kleine-koenig.org> <1d45ce6b-4bcf-4460-82b2-e2f5eaa37d6c@pengutronix.de> Content-Language: en-US From: Ahmad Fatoum In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: [DistroKit] [PATCH v2] v7a: kernel: Enable I/O expander driver for STM32MP135F-DK X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: distrokit@pengutronix.de Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false On 01.08.24 12:12, Uwe Kleine-König wrote: > Hello Ahmad, > > On Thu, Aug 01, 2024 at 11:50:17AM +0200, Ahmad Fatoum wrote: >> On 01.08.24 00:35, Uwe Kleine-König wrote: >>> +CONFIG_PINCTRL_MCP23S08_I2C=y >>> +CONFIG_PINCTRL_MCP23S08_SPI=y >> >> Nit: We don't seem to actually need the SPI driver. > > PINCTRL_MCP23S08_SPI wasn't explicitly enabled. That's a hidden symbol > enabled by > > config PINCTRL_MCP23S08 > ... > select PINCTRL_MCP23S08_SPI if SPI_MASTER > > . So not enabling this would require a kernel patch to make the SPI > variant explicitly selectable. Ok, thanks for checking. In this case, the patch looks good to me, no nits. Cheers, Ahmad > > Best regards > Uwe -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |