[DistroKit] [PATCH v2] v7a: kernel: Enable I/O expander driver for STM32MP135F-DK

[DistroKit] [PATCH v2] v7a: kernel: Enable I/O expander driver for STM32MP135F-DK

[Uwe Kleine-König]

From: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

The i2c I/O expander MCP23S08 provides GPIOs to reset various components
(ethernet phy, display bridge, camera). The I/O expander is configured
as built-in as it is needed for nfs-root operation (once the kernel
contains the needed adaptions for the stmmac to support the stm32mp13x).

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
---
Hello,

(implicit) v1 of this patch had a different subject as some more drivers
were enabled, see
https://lore.pengutronix.de/distrokit/20240730150915.2397723-2-u.kleine-koenig@baylibre.com/
. Ahmad requested to only enable the I/O expander as display and camera
are not supported in Distrokit userspace anyhow.

Best regards
Uwe

 configs/platform-v7a/kernelconfig | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/configs/platform-v7a/kernelconfig b/configs/platform-v7a/kernelconfig
index e6fadf500da3..5f12b549580c 100644
--- a/configs/platform-v7a/kernelconfig
+++ b/configs/platform-v7a/kernelconfig
@@ -1208,6 +1208,7 @@ CONFIG_GENERIC_CPU_VULNERABILITIES=y
 CONFIG_SOC_BUS=y
 CONFIG_REGMAP=y
 CONFIG_REGMAP_I2C=y
+CONFIG_REGMAP_SPI=y
 CONFIG_REGMAP_MMIO=y
 CONFIG_REGMAP_IRQ=y
 CONFIG_DMA_SHARED_BUFFER=y
@@ -2100,7 +2101,9 @@ CONFIG_GENERIC_PINCONF=y
 CONFIG_PINCTRL_AT91=y
 CONFIG_PINCTRL_AT91PIO4=y
 # CONFIG_PINCTRL_CY8C95X0 is not set
-# CONFIG_PINCTRL_MCP23S08 is not set
+CONFIG_PINCTRL_MCP23S08_I2C=y
+CONFIG_PINCTRL_MCP23S08_SPI=y
+CONFIG_PINCTRL_MCP23S08=y
 # CONFIG_PINCTRL_MICROCHIP_SGPIO is not set
 # CONFIG_PINCTRL_OCELOT is not set
 # CONFIG_PINCTRL_PALMAS is not set

base-commit: 747926d7f2936451c93f72b8dc0cfc58c7bb3122
-- 
2.43.0

Re: [DistroKit] [PATCH v2] v7a: kernel: Enable I/O expander driver for STM32MP135F-DK

[Ahmad Fatoum]

Hello Uwe,

On 01.08.24 00:35, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Thanks for your patch.

> 
> The i2c I/O expander MCP23S08 provides GPIOs to reset various components
> (ethernet phy, display bridge, camera). The I/O expander is configured
> as built-in as it is needed for nfs-root operation (once the kernel
> contains the needed adaptions for the stmmac to support the stm32mp13x).
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>

Reviewed-by: Ahmad Fatoum <a.fatoum@pengutronix.de>

Just a small nit below:

> +CONFIG_PINCTRL_MCP23S08_I2C=y
> +CONFIG_PINCTRL_MCP23S08_SPI=y

Nit: We don't seem to actually need the SPI driver.

Cheers,
Ahmad

> +CONFIG_PINCTRL_MCP23S08=y
>  # CONFIG_PINCTRL_MICROCHIP_SGPIO is not set
>  # CONFIG_PINCTRL_OCELOT is not set
>  # CONFIG_PINCTRL_PALMAS is not set
> 
> base-commit: 747926d7f2936451c93f72b8dc0cfc58c7bb3122

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [DistroKit] [PATCH v2] v7a: kernel: Enable I/O expander driver for STM32MP135F-DK

[Uwe Kleine-König]

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

Hello Ahmad,

On Thu, Aug 01, 2024 at 11:50:17AM +0200, Ahmad Fatoum wrote:
> On 01.08.24 00:35, Uwe Kleine-König wrote:
> > +CONFIG_PINCTRL_MCP23S08_I2C=y
> > +CONFIG_PINCTRL_MCP23S08_SPI=y
> 
> Nit: We don't seem to actually need the SPI driver.

PINCTRL_MCP23S08_SPI wasn't explicitly enabled. That's a hidden symbol
enabled by

config PINCTRL_MCP23S08
	...
	select PINCTRL_MCP23S08_SPI if SPI_MASTER

. So not enabling this would require a kernel patch to make the SPI
variant explicitly selectable.

Best regards
Uwe

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: [DistroKit] [PATCH v2] v7a: kernel: Enable I/O expander driver for STM32MP135F-DK

[Ahmad Fatoum]

On 01.08.24 12:12, Uwe Kleine-König wrote:
> Hello Ahmad,
> 
> On Thu, Aug 01, 2024 at 11:50:17AM +0200, Ahmad Fatoum wrote:
>> On 01.08.24 00:35, Uwe Kleine-König wrote:
>>> +CONFIG_PINCTRL_MCP23S08_I2C=y
>>> +CONFIG_PINCTRL_MCP23S08_SPI=y
>>
>> Nit: We don't seem to actually need the SPI driver.
> 
> PINCTRL_MCP23S08_SPI wasn't explicitly enabled. That's a hidden symbol
> enabled by
> 
> config PINCTRL_MCP23S08
> 	...
> 	select PINCTRL_MCP23S08_SPI if SPI_MASTER
> 
> . So not enabling this would require a kernel patch to make the SPI
> variant explicitly selectable.

Ok, thanks for checking.
In this case, the patch looks good to me, no nits.

Cheers,
Ahmad

> 
> Best regards
> Uwe

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |

Re: [DistroKit] [PATCH v2] v7a: kernel: Enable I/O expander driver for STM32MP135F-DK

[Robert Schwebel]

applied to next

On Thu, Aug 01, 2024 at 12:35:39AM +0200, Uwe Kleine-König wrote:
> From: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> 
> The i2c I/O expander MCP23S08 provides GPIOs to reset various components
> (ethernet phy, display bridge, camera). The I/O expander is configured
> as built-in as it is needed for nfs-root operation (once the kernel
> contains the needed adaptions for the stmmac to support the stm32mp13x).
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Hello,
> 
> (implicit) v1 of this patch had a different subject as some more drivers
> were enabled, see
> https://lore.pengutronix.de/distrokit/20240730150915.2397723-2-u.kleine-koenig@baylibre.com/
> . Ahmad requested to only enable the I/O expander as display and camera
> are not supported in Distrokit userspace anyhow.
> 
> Best regards
> Uwe
> 
>  configs/platform-v7a/kernelconfig | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/configs/platform-v7a/kernelconfig b/configs/platform-v7a/kernelconfig
> index e6fadf500da3..5f12b549580c 100644
> --- a/configs/platform-v7a/kernelconfig
> +++ b/configs/platform-v7a/kernelconfig
> @@ -1208,6 +1208,7 @@ CONFIG_GENERIC_CPU_VULNERABILITIES=y
>  CONFIG_SOC_BUS=y
>  CONFIG_REGMAP=y
>  CONFIG_REGMAP_I2C=y
> +CONFIG_REGMAP_SPI=y
>  CONFIG_REGMAP_MMIO=y
>  CONFIG_REGMAP_IRQ=y
>  CONFIG_DMA_SHARED_BUFFER=y
> @@ -2100,7 +2101,9 @@ CONFIG_GENERIC_PINCONF=y
>  CONFIG_PINCTRL_AT91=y
>  CONFIG_PINCTRL_AT91PIO4=y
>  # CONFIG_PINCTRL_CY8C95X0 is not set
> -# CONFIG_PINCTRL_MCP23S08 is not set
> +CONFIG_PINCTRL_MCP23S08_I2C=y
> +CONFIG_PINCTRL_MCP23S08_SPI=y
> +CONFIG_PINCTRL_MCP23S08=y
>  # CONFIG_PINCTRL_MICROCHIP_SGPIO is not set
>  # CONFIG_PINCTRL_OCELOT is not set
>  # CONFIG_PINCTRL_PALMAS is not set
> 
> base-commit: 747926d7f2936451c93f72b8dc0cfc58c7bb3122
> -- 
> 2.43.0
> 
> 
> 

-- 
Pengutronix e.K.                           | Dipl.-Ing. Robert Schwebel  |
Steuerwalder Str. 21                       | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-9    |