From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Fri, 02 Jun 2023 18:45:29 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q57u6-007ZyV-9l for lore@lore.pengutronix.de; Fri, 02 Jun 2023 18:45:28 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q57u4-0002er-30; Fri, 02 Jun 2023 18:45:28 +0200 Received: from ptz.office.stw.pengutronix.de ([2a0a:edc0:0:900:1d::77] helo=[127.0.0.1]) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q57u2-0002eS-HN; Fri, 02 Jun 2023 18:45:26 +0200 Message-ID: Date: Fri, 2 Jun 2023 18:45:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Content-Language: en-US To: Michael Olbrich , distrokit@pengutronix.de References: <20230602145957.902307-1-m.olbrich@pengutronix.de> <20230602145957.902307-6-m.olbrich@pengutronix.de> From: Ahmad Fatoum In-Reply-To: <20230602145957.902307-6-m.olbrich@pengutronix.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [DistroKit] [PATCH 5/7] firmware-imx: use foreach and ptx/nl X-BeenThere: distrokit@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: DistroKit Mailinglist List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "DistroKit" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: distrokit-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On 02.06.23 16:59, Michael Olbrich wrote: > Combining multiple commands with ';' hides errors. So use $(foreach ...) > and $(ptx/nl) to create separate commands that are executed individually > and all errors are caught. > > Signed-off-by: Michael Olbrich Reviewed-by: Ahmad Fatoum > --- > configs/platform-v8a/rules/firmware-imx.make | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/configs/platform-v8a/rules/firmware-imx.make b/configs/platform-v8a/rules/firmware-imx.make > index 7bf1701b3ce1..56c8e24ecd69 100644 > --- a/configs/platform-v8a/rules/firmware-imx.make > +++ b/configs/platform-v8a/rules/firmware-imx.make > @@ -59,11 +59,11 @@ ifdef PTXCONF_FIRMWARE_IMX_BOOTIMAGE_IMX8 > @$(foreach f, lpddr4_pmu_train_1d_dmem.bin lpddr4_pmu_train_1d_imem.bin \ > lpddr4_pmu_train_2d_dmem.bin lpddr4_pmu_train_2d_imem.bin, \ > install -v -D -m644 $(FIRMWARE_IMX_PKGDIR)/firmware/ddr/synopsys/$(f) \ > - $(PTXCONF_SYSROOT_TARGET)/usr/lib/firmware/ddr/synopsys/$(f);) > + $(PTXCONF_SYSROOT_TARGET)/usr/lib/firmware/ddr/synopsys/$(f)$(ptx/nl)) > > @$(foreach f, signed_dp_imx8m.bin signed_hdmi_imx8m.bin, \ > install -v -D -m644 $(FIRMWARE_IMX_PKGDIR)/firmware/hdmi/cadence/$(f) \ > - $(PTXCONF_SYSROOT_TARGET)/usr/lib/firmware/hdmi/cadence/$(f);) > + $(PTXCONF_SYSROOT_TARGET)/usr/lib/firmware/hdmi/cadence/$(f)$(ptx/nl)) > endif > > @$(call touch) > @@ -86,10 +86,10 @@ $(STATEDIR)/firmware-imx.targetinstall: > @$(call install_fixup, firmware-imx,SECTION,base) > @$(call install_fixup, firmware-imx,AUTHOR,"Philipp Zabel ") > @$(call install_fixup, firmware-imx,DESCRIPTION,missing) > - @for f in $(FIRMWARE_IMX_INSTALL-y); do \ > + @$(foreach f,$(FIRMWARE_IMX_INSTALL-y), \ > $(call install_copy, firmware-imx, 0, 0, 0644, \ > - $(FIRMWARE_IMX_PKGDIR)/firmware/vpu/$$f, /usr/lib/firmware/$$f); \ > - done > + $(FIRMWARE_IMX_PKGDIR)/firmware/vpu/$(f), \ > + /usr/lib/firmware/$(f))$(ptx/nl)) > @$(call install_finish, firmware-imx) > > @$(call touch) -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |