Re: [DistroKit] [PATCH 03/10] treewide: images: remove size specifications for root partitions

[Ahmad Fatoum <a.fatoum@pengutronix.de>]

Hello Roland,

On 03.11.23 19:24, Roland Hieber wrote:
> With current rootfs sizes of below 200 MiB there is no need to have a
> 512 MiB root partition, which will be a lot larger than the file system
> it contains, and which will also all have to be written to the SD card.
> Let genimage determine the partition size based on the file system image
> it contains, thereby reducing the size of the generated disk images.

Does that mean that there will be no free space on the partition whatsoever?
It's beneficial for testing to either have some spare space to remount the
rootfs r/w and place some drop-in configuration files or an overlay that
achieves the same.

Cheers,
Ahmad

> 
> Signed-off-by: Roland Hieber <rhi@pengutronix.de>
> ---
>  configs/platform-mips/config/images/ar9331.config         | 1 -
>  configs/platform-mips/config/images/malta.config          | 1 -
>  configs/platform-mipsel/config/images/malta.config        | 1 -
>  configs/platform-v7a/config/images/vexpress.config        | 1 -
>  configs/platform-v7a_noneon/config/images/vexpress.config | 1 -
>  configs/platform-v8a/config/images/espressobin.config     | 1 -
>  6 files changed, 6 deletions(-)
> 
> diff --git a/configs/platform-mips/config/images/ar9331.config b/configs/platform-mips/config/images/ar9331.config
> index f26627f84cc0..7685781d231a 100644
> --- a/configs/platform-mips/config/images/ar9331.config
> +++ b/configs/platform-mips/config/images/ar9331.config
> @@ -9,7 +9,6 @@ image @IMAGE@ {
>  	partition root-A {
>  		image = root.ext2
>  		partition-type-uuid = e9434544-6e2c-47cc-bae2-12d6deafb44c # root-mips
> -		size = 512M
>  	}
>  	partition data {
>  		autoresize = true
> diff --git a/configs/platform-mips/config/images/malta.config b/configs/platform-mips/config/images/malta.config
> index f26627f84cc0..7685781d231a 100644
> --- a/configs/platform-mips/config/images/malta.config
> +++ b/configs/platform-mips/config/images/malta.config
> @@ -9,7 +9,6 @@ image @IMAGE@ {
>  	partition root-A {
>  		image = root.ext2
>  		partition-type-uuid = e9434544-6e2c-47cc-bae2-12d6deafb44c # root-mips
> -		size = 512M
>  	}
>  	partition data {
>  		autoresize = true
> diff --git a/configs/platform-mipsel/config/images/malta.config b/configs/platform-mipsel/config/images/malta.config
> index c873c7e8b724..71e367276072 100644
> --- a/configs/platform-mipsel/config/images/malta.config
> +++ b/configs/platform-mipsel/config/images/malta.config
> @@ -9,7 +9,6 @@ image @IMAGE@ {
>  	partition root-A {
>  		image = root.ext2
>  		partition-type-uuid = 37c58c8a-d913-4156-a25f-48b1b64e07f0 # root-mips-le
> -		size = 512M
>  	}
>  	partition data {
>  		autoresize = true
> diff --git a/configs/platform-v7a/config/images/vexpress.config b/configs/platform-v7a/config/images/vexpress.config
> index 87eaedfe8b82..67c7638a59b8 100644
> --- a/configs/platform-v7a/config/images/vexpress.config
> +++ b/configs/platform-v7a/config/images/vexpress.config
> @@ -9,7 +9,6 @@ image @IMAGE@ {
>  	partition root-A {
>  		image = root.ext2
>  		partition-type-uuid = 69dad710-2ce4-4e3c-b16c-21a1d49abed3 # root-arm
> -		size = 96M
>  	}
>  	partition root-B {
>  		image = root.ext2
> diff --git a/configs/platform-v7a_noneon/config/images/vexpress.config b/configs/platform-v7a_noneon/config/images/vexpress.config
> index 0712ad82ce96..4200f95b7725 100644
> --- a/configs/platform-v7a_noneon/config/images/vexpress.config
> +++ b/configs/platform-v7a_noneon/config/images/vexpress.config
> @@ -9,7 +9,6 @@ image @IMAGE@ {
>  	partition root-A {
>  		image = root.ext2
>  		partition-type-uuid = 69dad710-2ce4-4e3c-b16c-21a1d49abed3 # root-arm
> -		size = 192M
>  	}
>  	partition data {
>  		autoresize = true
> diff --git a/configs/platform-v8a/config/images/espressobin.config b/configs/platform-v8a/config/images/espressobin.config
> index 188bb9ae4d9e..e9f4460c9a9a 100644
> --- a/configs/platform-v8a/config/images/espressobin.config
> +++ b/configs/platform-v8a/config/images/espressobin.config
> @@ -6,7 +6,6 @@ image @IMAGE@ {
>  	partition root-A {
>  		image = root.ext2
>  		partition-type-uuid = 69dad710-2ce4-4e3c-b16c-21a1d49abed3 # root-arm
> -		size = 512M
>  	}
>  	partition data {
>  		size = 512M

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |