From: "Jan Lübbe" <jlu@pengutronix.de>
To: Oleksij Rempel <o.rempel@pengutronix.de>
Cc: distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH v1 4/4] mipsel: kernel: version bump 6.4.0 -> 6.4.10
Date: Thu, 17 Aug 2023 11:54:25 +0200 [thread overview]
Message-ID: <e5e8bba8f511ce8a4d7e95a3ade2c2f9d5aeb3f6.camel@pengutronix.de> (raw)
In-Reply-To: <20230817074643.GE28787@pengutronix.de>
On Thu, 2023-08-17 at 09:46 +0200, Oleksij Rempel wrote:
> On Thu, Aug 17, 2023 at 09:42:17AM +0200, Jan Lübbe wrote:
> > On Wed, 2023-08-16 at 13:43 +0200, Oleksij Rempel wrote:
> > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> > > ---
> > > configs/platform-mipsel/kernelconfig | 529 +++++-------------
> > > configs/platform-mipsel/kernelconfig-malta | 80 +--
> > > .../platform-mipsel/kernelconfig-malta.diff | 454 ++++++++-------
> > > configs/platform-mipsel/platformconfig | 4 +-
> > > 4 files changed, 425 insertions(+), 642 deletions(-)
> > ^ ^
> >
> > This is more than a simple stable kernel update, so it should either be
> > split up
> > or needs a better explanation.
>
> kernelconfig is not used for actual targets. It is a common kernel
> config without real effect.
Even in that case, the commit should explain why the change is needed.
On the other hand, why does it exist if it has no effect?
Jan
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2023-08-17 9:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 11:43 [DistroKit] [PATCH v1 0/4] MIPS maintenance Oleksij Rempel
2023-08-16 11:43 ` [DistroKit] [PATCH v1 1/4] mips: run: make network work on systems with multiple QEMU instances Oleksij Rempel
2023-08-16 11:43 ` [DistroKit] [PATCH v1 2/4] mips: kernel: version bump 6.4.0 -> 6.4.10 Oleksij Rempel
2023-08-16 11:43 ` [DistroKit] [PATCH v1 3/4] mipsel: run: make network work on systems with multiple QEMU instances Oleksij Rempel
2023-08-16 11:43 ` [DistroKit] [PATCH v1 4/4] mipsel: kernel: version bump 6.4.0 -> 6.4.10 Oleksij Rempel
2023-08-17 7:42 ` Jan Lübbe
2023-08-17 7:46 ` Oleksij Rempel
2023-08-17 9:54 ` Jan Lübbe [this message]
2023-08-17 7:38 ` [DistroKit] [PATCH v1 0/4] MIPS maintenance Robert Schwebel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e5e8bba8f511ce8a4d7e95a3ade2c2f9d5aeb3f6.camel@pengutronix.de \
--to=jlu@pengutronix.de \
--cc=distrokit@pengutronix.de \
--cc=o.rempel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox