DistroKit Mailinglist
 help / color / mirror / Atom feed
From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: "Uwe Kleine-König" <u.kleine-koenig@baylibre.com>,
	distrokit@pengutronix.de
Subject: Re: [DistroKit] [PATCH] v7a: kernel: Enable drivers for STM32MP135F-DK
Date: Wed, 31 Jul 2024 10:47:06 +0200	[thread overview]
Message-ID: <e8cdb702-d335-44ff-bea1-f753e339c462@pengutronix.de> (raw)
In-Reply-To: <20240730150915.2397723-2-u.kleine-koenig@baylibre.com>

Hello Uwe,

On 30.07.24 17:09, Uwe Kleine-König wrote:
> Enable drivers for display bridge and camera.

I don't think these should be enabled in DistroKit:

  - We don't have any userspace enabled to make use of the camera
  - We don't enable the camera interface for existing platforms
    either like the i.MX
  - We don't even enable CONFIG_DRM

> The i2c I/O expander MCP23S08 provides GPIOs to reset various components
> (ethernet phy, display bridge, camera). The I/O expander is configured
> as built-in as it is needed for nfs-root operation (once the kernel
> contains the needed adaptions for the stmmac to support the stm32mp13x).

This change is fine though.

Can you resend with only the I/O expander parts?

Thanks,
Ahmad

> The other two are configured as modules.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@baylibre.com>
> ---
> Hello,
> 
> I couldn't test the camera and display, the corresponding i2c bus
> doesn't show any devices on my board. Didn't try to debug that. With a
> newer kernel (6.11-rc1) PINCTRL_MCP23S08 is good enough to enable
> nfs-root though.
> 
> Best regards
> Uwe
> 
>  configs/platform-v7a/kernelconfig | 273 +++++++++++++++++++++++++++++-
>  1 file changed, 271 insertions(+), 2 deletions(-)
> 
> diff --git a/configs/platform-v7a/kernelconfig b/configs/platform-v7a/kernelconfig
> index e6fadf500da3..ade6f67c96dd 100644
> --- a/configs/platform-v7a/kernelconfig
> +++ b/configs/platform-v7a/kernelconfig
> @@ -1208,6 +1208,7 @@ CONFIG_GENERIC_CPU_VULNERABILITIES=y
>  CONFIG_SOC_BUS=y
>  CONFIG_REGMAP=y
>  CONFIG_REGMAP_I2C=y
> +CONFIG_REGMAP_SPI=y
>  CONFIG_REGMAP_MMIO=y
>  CONFIG_REGMAP_IRQ=y
>  CONFIG_DMA_SHARED_BUFFER=y
> @@ -2100,7 +2101,9 @@ CONFIG_GENERIC_PINCONF=y
>  CONFIG_PINCTRL_AT91=y
>  CONFIG_PINCTRL_AT91PIO4=y
>  # CONFIG_PINCTRL_CY8C95X0 is not set
> -# CONFIG_PINCTRL_MCP23S08 is not set
> +CONFIG_PINCTRL_MCP23S08_I2C=y
> +CONFIG_PINCTRL_MCP23S08_SPI=y
> +CONFIG_PINCTRL_MCP23S08=y
>  # CONFIG_PINCTRL_MICROCHIP_SGPIO is not set
>  # CONFIG_PINCTRL_OCELOT is not set
>  # CONFIG_PINCTRL_PALMAS is not set
> @@ -2590,7 +2593,273 @@ CONFIG_REGULATOR_TPS65217=y
>  # CONFIG_MEDIA_CEC_SUPPORT is not set
>  # end of CEC support
>  
> -# CONFIG_MEDIA_SUPPORT is not set
> +CONFIG_MEDIA_SUPPORT=y
> +CONFIG_MEDIA_SUPPORT_FILTER=y
> +# CONFIG_MEDIA_SUBDRV_AUTOSELECT is not set
> +
> +#
> +# Media device types
> +#
> +CONFIG_MEDIA_CAMERA_SUPPORT=y
> +# CONFIG_MEDIA_ANALOG_TV_SUPPORT is not set
> +# CONFIG_MEDIA_DIGITAL_TV_SUPPORT is not set
> +# CONFIG_MEDIA_RADIO_SUPPORT is not set
> +# CONFIG_MEDIA_SDR_SUPPORT is not set
> +# CONFIG_MEDIA_PLATFORM_SUPPORT is not set
> +# CONFIG_MEDIA_TEST_SUPPORT is not set
> +# end of Media device types
> +
> +CONFIG_VIDEO_DEV=y
> +CONFIG_MEDIA_CONTROLLER=y
> +
> +#
> +# Video4Linux options
> +#
> +CONFIG_VIDEO_V4L2_I2C=y
> +CONFIG_VIDEO_V4L2_SUBDEV_API=y
> +# CONFIG_VIDEO_ADV_DEBUG is not set
> +# CONFIG_VIDEO_FIXED_MINOR_RANGES is not set
> +CONFIG_V4L2_FWNODE=y
> +CONFIG_V4L2_ASYNC=y
> +CONFIG_V4L2_CCI=m
> +CONFIG_V4L2_CCI_I2C=m
> +# end of Video4Linux options
> +
> +#
> +# Media controller options
> +#
> +# end of Media controller options
> +
> +#
> +# Media drivers
> +#
> +
> +#
> +# Drivers filtered as selected at 'Filter media drivers'
> +#
> +
> +#
> +# Media drivers
> +#
> +# CONFIG_MEDIA_USB_SUPPORT is not set
> +# end of Media drivers
> +
> +#
> +# Media ancillary drivers
> +#
> +CONFIG_VIDEO_CAMERA_SENSOR=y
> +# CONFIG_VIDEO_ALVIUM_CSI2 is not set
> +# CONFIG_VIDEO_AR0521 is not set
> +# CONFIG_VIDEO_GC0308 is not set
> +CONFIG_VIDEO_GC2145=m
> +# CONFIG_VIDEO_HI556 is not set
> +# CONFIG_VIDEO_HI846 is not set
> +# CONFIG_VIDEO_HI847 is not set
> +# CONFIG_VIDEO_IMX208 is not set
> +# CONFIG_VIDEO_IMX214 is not set
> +# CONFIG_VIDEO_IMX219 is not set
> +# CONFIG_VIDEO_IMX258 is not set
> +# CONFIG_VIDEO_IMX274 is not set
> +# CONFIG_VIDEO_IMX290 is not set
> +# CONFIG_VIDEO_IMX296 is not set
> +# CONFIG_VIDEO_IMX319 is not set
> +# CONFIG_VIDEO_IMX334 is not set
> +# CONFIG_VIDEO_IMX335 is not set
> +# CONFIG_VIDEO_IMX355 is not set
> +# CONFIG_VIDEO_IMX412 is not set
> +# CONFIG_VIDEO_IMX415 is not set
> +# CONFIG_VIDEO_MT9M001 is not set
> +# CONFIG_VIDEO_MT9M111 is not set
> +# CONFIG_VIDEO_MT9M114 is not set
> +# CONFIG_VIDEO_MT9P031 is not set
> +# CONFIG_VIDEO_MT9T112 is not set
> +# CONFIG_VIDEO_MT9V011 is not set
> +# CONFIG_VIDEO_MT9V032 is not set
> +# CONFIG_VIDEO_MT9V111 is not set
> +# CONFIG_VIDEO_OG01A1B is not set
> +# CONFIG_VIDEO_OV01A10 is not set
> +# CONFIG_VIDEO_OV02A10 is not set
> +# CONFIG_VIDEO_OV08D10 is not set
> +# CONFIG_VIDEO_OV08X40 is not set
> +# CONFIG_VIDEO_OV13858 is not set
> +# CONFIG_VIDEO_OV13B10 is not set
> +# CONFIG_VIDEO_OV2640 is not set
> +# CONFIG_VIDEO_OV2659 is not set
> +# CONFIG_VIDEO_OV2680 is not set
> +# CONFIG_VIDEO_OV2685 is not set
> +# CONFIG_VIDEO_OV4689 is not set
> +# CONFIG_VIDEO_OV5640 is not set
> +# CONFIG_VIDEO_OV5645 is not set
> +# CONFIG_VIDEO_OV5647 is not set
> +# CONFIG_VIDEO_OV5648 is not set
> +# CONFIG_VIDEO_OV5670 is not set
> +# CONFIG_VIDEO_OV5675 is not set
> +# CONFIG_VIDEO_OV5693 is not set
> +# CONFIG_VIDEO_OV5695 is not set
> +# CONFIG_VIDEO_OV64A40 is not set
> +# CONFIG_VIDEO_OV6650 is not set
> +# CONFIG_VIDEO_OV7251 is not set
> +# CONFIG_VIDEO_OV7640 is not set
> +# CONFIG_VIDEO_OV7670 is not set
> +# CONFIG_VIDEO_OV772X is not set
> +# CONFIG_VIDEO_OV7740 is not set
> +# CONFIG_VIDEO_OV8856 is not set
> +# CONFIG_VIDEO_OV8858 is not set
> +# CONFIG_VIDEO_OV8865 is not set
> +# CONFIG_VIDEO_OV9282 is not set
> +# CONFIG_VIDEO_OV9640 is not set
> +# CONFIG_VIDEO_OV9650 is not set
> +# CONFIG_VIDEO_RDACM20 is not set
> +# CONFIG_VIDEO_RDACM21 is not set
> +# CONFIG_VIDEO_RJ54N1 is not set
> +# CONFIG_VIDEO_S5C73M3 is not set
> +# CONFIG_VIDEO_S5K5BAF is not set
> +# CONFIG_VIDEO_S5K6A3 is not set
> +# CONFIG_VIDEO_ST_VGXY61 is not set
> +# CONFIG_VIDEO_CCS is not set
> +# CONFIG_VIDEO_ET8EK8 is not set
> +
> +#
> +# Camera ISPs
> +#
> +# CONFIG_VIDEO_THP7312 is not set
> +# end of Camera ISPs
> +
> +#
> +# Lens drivers
> +#
> +# CONFIG_VIDEO_AD5820 is not set
> +# CONFIG_VIDEO_AK7375 is not set
> +# CONFIG_VIDEO_DW9714 is not set
> +# CONFIG_VIDEO_DW9719 is not set
> +# CONFIG_VIDEO_DW9768 is not set
> +# CONFIG_VIDEO_DW9807_VCM is not set
> +# end of Lens drivers
> +
> +#
> +# Flash devices
> +#
> +# CONFIG_VIDEO_ADP1653 is not set
> +# CONFIG_VIDEO_LM3560 is not set
> +# CONFIG_VIDEO_LM3646 is not set
> +# end of Flash devices
> +
> +#
> +# Audio decoders, processors and mixers
> +#
> +# CONFIG_VIDEO_CS3308 is not set
> +# CONFIG_VIDEO_CS5345 is not set
> +# CONFIG_VIDEO_CS53L32A is not set
> +# CONFIG_VIDEO_MSP3400 is not set
> +# CONFIG_VIDEO_SONY_BTF_MPX is not set
> +# CONFIG_VIDEO_TDA7432 is not set
> +# CONFIG_VIDEO_TDA9840 is not set
> +# CONFIG_VIDEO_TEA6415C is not set
> +# CONFIG_VIDEO_TEA6420 is not set
> +# CONFIG_VIDEO_TLV320AIC23B is not set
> +# CONFIG_VIDEO_TVAUDIO is not set
> +# CONFIG_VIDEO_UDA1342 is not set
> +# CONFIG_VIDEO_VP27SMPX is not set
> +# CONFIG_VIDEO_WM8739 is not set
> +# CONFIG_VIDEO_WM8775 is not set
> +# end of Audio decoders, processors and mixers
> +
> +#
> +# RDS decoders
> +#
> +# CONFIG_VIDEO_SAA6588 is not set
> +# end of RDS decoders
> +
> +#
> +# Video decoders
> +#
> +# CONFIG_VIDEO_ADV7180 is not set
> +# CONFIG_VIDEO_ADV7183 is not set
> +# CONFIG_VIDEO_ADV748X is not set
> +# CONFIG_VIDEO_ADV7604 is not set
> +# CONFIG_VIDEO_ADV7842 is not set
> +# CONFIG_VIDEO_BT819 is not set
> +# CONFIG_VIDEO_BT856 is not set
> +# CONFIG_VIDEO_BT866 is not set
> +# CONFIG_VIDEO_ISL7998X is not set
> +# CONFIG_VIDEO_KS0127 is not set
> +# CONFIG_VIDEO_ML86V7667 is not set
> +# CONFIG_VIDEO_SAA7110 is not set
> +# CONFIG_VIDEO_SAA711X is not set
> +# CONFIG_VIDEO_TC358743 is not set
> +# CONFIG_VIDEO_TC358746 is not set
> +# CONFIG_VIDEO_TVP514X is not set
> +# CONFIG_VIDEO_TVP5150 is not set
> +# CONFIG_VIDEO_TVP7002 is not set
> +# CONFIG_VIDEO_TW2804 is not set
> +# CONFIG_VIDEO_TW9900 is not set
> +# CONFIG_VIDEO_TW9903 is not set
> +# CONFIG_VIDEO_TW9906 is not set
> +# CONFIG_VIDEO_TW9910 is not set
> +# CONFIG_VIDEO_VPX3220 is not set
> +
> +#
> +# Video and audio decoders
> +#
> +# CONFIG_VIDEO_SAA717X is not set
> +# CONFIG_VIDEO_CX25840 is not set
> +# end of Video decoders
> +
> +#
> +# Video encoders
> +#
> +# CONFIG_VIDEO_ADV7170 is not set
> +# CONFIG_VIDEO_ADV7175 is not set
> +# CONFIG_VIDEO_ADV7343 is not set
> +# CONFIG_VIDEO_ADV7393 is not set
> +# CONFIG_VIDEO_ADV7511 is not set
> +# CONFIG_VIDEO_AK881X is not set
> +# CONFIG_VIDEO_SAA7127 is not set
> +# CONFIG_VIDEO_SAA7185 is not set
> +# CONFIG_VIDEO_THS8200 is not set
> +# end of Video encoders
> +
> +#
> +# Video improvement chips
> +#
> +# CONFIG_VIDEO_UPD64031A is not set
> +# CONFIG_VIDEO_UPD64083 is not set
> +# end of Video improvement chips
> +
> +#
> +# Audio/Video compression chips
> +#
> +# CONFIG_VIDEO_SAA6752HS is not set
> +# end of Audio/Video compression chips
> +
> +#
> +# SDR tuner chips
> +#
> +# end of SDR tuner chips
> +
> +#
> +# Miscellaneous helper chips
> +#
> +# CONFIG_VIDEO_I2C is not set
> +# CONFIG_VIDEO_M52790 is not set
> +CONFIG_VIDEO_ST_MIPID02=m
> +# CONFIG_VIDEO_THS7303 is not set
> +# end of Miscellaneous helper chips
> +
> +#
> +# Video serializers and deserializers
> +#
> +# CONFIG_VIDEO_DS90UB913 is not set
> +# CONFIG_VIDEO_DS90UB953 is not set
> +# CONFIG_VIDEO_DS90UB960 is not set
> +# end of Video serializers and deserializers
> +
> +#
> +# Media SPI Adapters
> +#
> +# CONFIG_VIDEO_GS1662 is not set
> +# end of Media SPI Adapters
> +# end of Media ancillary drivers
>  
>  #
>  # Graphics support
> 
> base-commit: 747926d7f2936451c93f72b8dc0cfc58c7bb3122

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |




      parent reply	other threads:[~2024-07-31  8:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-30 15:09 Uwe Kleine-König
2024-07-31  8:39 ` Robert Schwebel
2024-07-31  8:47 ` Ahmad Fatoum [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e8cdb702-d335-44ff-bea1-f753e339c462@pengutronix.de \
    --to=a.fatoum@pengutronix.de \
    --cc=distrokit@pengutronix.de \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox