Re: [OSS-Tools] [PATCH microcom] main: error out on positional arguments

[Roland Hieber <rhi@pengutronix.de>]

On Sat, Jan 04, 2025 at 04:17:25PM +0100, Jonas Rebmann wrote:
> As microcom makes no use of positional arguments, error out and show
> usage if a positional argument is presented.
> 
> Without this patch, invalid usage involving a positional such as
> microcom /dev/ttyUSB0 is silently ignored.
> 
> Signed-off-by: Jonas Rebmann <jre@pengutronix.de>

For the record, microcom uses GiHub and this has been merged in
<https://github.com/pengutronix/microcom/pull/48>.


> ---
>  microcom.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/microcom.c b/microcom.c
> index 2b3d484..974c0cf 100644
> --- a/microcom.c
> +++ b/microcom.c
> @@ -183,6 +183,10 @@ int main(int argc, char *argv[])
>  		}
>  	}
>  
> +	if (optind < argc) {
> +		main_usage(1, "", "");
> +	}
> +
>  	if (answerback) {
>  		ret = asprintf(&answerback, "%s\n", answerback);
>  		if (ret < 0)
> -- 
> 2.39.5
> 
> 
> 

-- 
Roland Hieber, Pengutronix e.K.          | rhi@pengutronix.de          |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |