mailarchive of the pengutronix oss-tools mailing list
 help / color / mirror / Atom feed
From: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
To: Pengutronix Public Open-Source-Development <oss-tools@pengutronix.de>
Cc: "Ulrich Ölmann" <u.oelmann@pengutronix.de>, entwicklung@pengutronix.de
Subject: [OSS-Tools] [PATCH dt-utils 03/12] barebox-state: fix usage of multiple state instances
Date: Sun,  3 Feb 2019 22:47:58 +0100	[thread overview]
Message-ID: <20190203214807.13643-4-u.oelmann@pengutronix.de> (raw)
In-Reply-To: <20190203214807.13643-1-u.oelmann@pengutronix.de>

Let's assume there are two state instances named "blue" (with variable "x") and
"yellow" (with variable "y") then

  $ barebox-state --name blue --get x
  $ barebox-state --name yellow --get y

would both work, whereas only exactly one of the alternative calls

  $ barebox-state --get blue.x
  $ barebox-state --get yellow.y

would succeed. This commit fixes that bug.

Signed-off-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
---
 src/barebox-state.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/barebox-state.c b/src/barebox-state.c
index 3e6c26003462..76d047559a4f 100644
--- a/src/barebox-state.c
+++ b/src/barebox-state.c
@@ -581,9 +581,10 @@ int main(int argc, char *argv[])
 
 			list_for_each_entry(state, &state_list.list, list) {
 				if (strlen(state->name) == statename_len &&
-				    !strncmp(state->name, sg->arg, statename_len))
+				    !strncmp(state->name, sg->arg, statename_len)) {
 					arg = statename_end + 1;
 					break;
+				}
 			}
 		}
 		if (state == &state_list) {
-- 
2.20.1


_______________________________________________
OSS-Tools mailing list
OSS-Tools@pengutronix.de

  parent reply	other threads:[~2019-02-03 21:47 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-03 21:47 [OSS-Tools] [PATCH dt-utils 00/12] Diverse patches mainly removing bugs and warnings Ulrich Ölmann
2019-02-03 21:47 ` [OSS-Tools] [PATCH dt-utils 01/12] common: align declarations of dev_add_param_*() functions with barebox Ulrich Ölmann
2019-02-03 21:47 ` [OSS-Tools] [PATCH dt-utils 02/12] of_get_devicepath: again correct comment Ulrich Ölmann
2019-02-03 21:47 ` Ulrich Ölmann [this message]
2019-02-03 21:47 ` [OSS-Tools] [PATCH dt-utils 04/12] barebox-state: complete cmdline options Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 05/12] barebox-state: add cmdline option "--version" Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 06/12] barebox-state: remove declaration of __state_uint8_get() Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 07/12] barebox-state: remove unused variables Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 08/12] keystore-blob: remove unused variable Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 09/12] base64: " Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 10/12] base64: remove duplicate ‘const’ declaration specifier Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 11/12] state: fix formatting of "off_t" variables Ulrich Ölmann
2019-02-04  7:54   ` Juergen Borleis
2019-02-04  9:06     ` Uwe Kleine-König
2019-02-06  6:25       ` Ulrich Ölmann
2019-02-03 21:48 ` [OSS-Tools] [PATCH dt-utils 12/12] state: fix formatting of "uint32_t" variables Ulrich Ölmann
2019-02-07 11:43 ` [OSS-Tools] [PATCH dt-utils 00/12] Diverse patches mainly removing bugs and warnings Roland Hieber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190203214807.13643-4-u.oelmann@pengutronix.de \
    --to=u.oelmann@pengutronix.de \
    --cc=entwicklung@pengutronix.de \
    --cc=oss-tools@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox