mailarchive of the pengutronix oss-tools mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: "Ulrich Ölmann" <u.oelmann@pengutronix.de>
Cc: "Pengutronix Public Open-Source-Development"
	<oss-tools@pengutronix.de>, "Kim Christensen" <kch@skov.dk>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [OSS-Tools] [PATCH dt-utils] state: backend_bucket_circular: fix double free()
Date: Mon, 23 Sep 2019 10:31:35 +0200
Message-ID: <20190923083135.mdm4ckjieffizgyp@pengutronix.de> (raw)
In-Reply-To: <6ref0cuar0.fsf@pengutronix.de>

On Thu, Sep 19, 2019 at 07:16:03AM +0200, Ulrich Ölmann wrote:
> On Wed, Sep 18 2019 at 22:23 +0200, Uwe Kleine-König <u.kleine-koenig@pengutronix.de> wrote:
> > On Wed, Sep 18, 2019 at 04:48:23PM +0200, Ulrich Ölmann wrote:
> >> From: Kim Christensen <kch@skov.dk>
> >>
> >> The function state_mtd_peb_read() is only a user of buf and not its owner, hence
> >> it may not deallocate it.
> >>
> >> Signed-off-by: Kim Christensen <kch@skov.dk>
> >> Acked-by: Ulrich Ölmann <u.oelmann@pengutronix.de>
> >
> > Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> 
> Just saw that I erroneously only documented an ACK while I actually did
> a review to approve the patch. So while applying please replace my
> "Acked-by" by an "Reviewed-by".

Did so while applying, thanks!

 - Roland

-- 
Roland Hieber                     | r.hieber@pengutronix.de     |
Pengutronix e.K.                  | https://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim | Phone: +49-5121-206917-5086 |
Amtsgericht Hildesheim, HRA 2686  | Fax:   +49-5121-206917-5555 |

_______________________________________________
OSS-Tools mailing list
OSS-Tools@pengutronix.de

      reply	other threads:[~2019-09-23  8:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-18 14:48 Ulrich Ölmann
2019-09-18 20:23 ` Uwe Kleine-König
2019-09-19  5:16   ` Ulrich Ölmann
2019-09-23  8:31     ` Roland Hieber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190923083135.mdm4ckjieffizgyp@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=kch@skov.dk \
    --cc=oss-tools@pengutronix.de \
    --cc=u.kleine-koenig@pengutronix.de \
    --cc=u.oelmann@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

mailarchive of the pengutronix oss-tools mailing list

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://lore.pengutronix.de/oss-tools/0 oss-tools/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 oss-tools oss-tools/ https://lore.pengutronix.de/oss-tools \
		oss-tools@pengutronix.de
	public-inbox-index oss-tools

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git