From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Tue, 30 Mar 2021 14:55:33 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= Message-ID: <20210330125533.75xdis36flv2dxbu@pengutronix.de> References: <20210326210647.8648-1-rhi@pengutronix.de> <20210326210647.8648-3-rhi@pengutronix.de> MIME-Version: 1.0 In-Reply-To: <20210326210647.8648-3-rhi@pengutronix.de> Subject: Re: [OSS-Tools] [PATCH dt-utils 3/4] treewide: add SPDX identifier to files with Zlib license List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2083201490==" Errors-To: oss-tools-bounces@pengutronix.de Sender: "OSS-Tools" To: Roland Hieber Cc: oss-tools@pengutronix.de --===============2083201490== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="vyh7lah37s67mc4x" Content-Disposition: inline --vyh7lah37s67mc4x Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Mar 26, 2021 at 10:06:46PM +0100, Roland Hieber wrote: > Signed-off-by: Roland Hieber > --- > src/crc32.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/src/crc32.c b/src/crc32.c > index 8d4dddcf6129..6d534c996050 100644 > --- a/src/crc32.c > +++ b/src/crc32.c > @@ -1,3 +1,4 @@ > +/* SPDX-License-Identifier: Zlib */ > /* > * This file is derived from crc32.c from the zlib-1.1.3 distribution > * by Jean-loup Gailly and Mark Adler. > @@ -5,7 +6,6 @@ > =20 > /* crc32.c -- compute the CRC-32 of a data stream > * Copyright (C) 1995-1998 Mark Adler > - * For conditions of distribution and use, see copyright notice in zlib.h > */ Interesting hunk separation. I wonder if this is worth to be reported to the git list because diff --git a/src/crc32.c b/src/crc32.c index 8d4dddcf6129..6d534c996050 100644 --- a/src/crc32.c +++ b/src/crc32.c @@ -1,11 +1,11 @@ +/* SPDX-License-Identifier: Zlib */ /* * This file is derived from crc32.c from the zlib-1.1.3 distribution * by Jean-loup Gailly and Mark Adler. */ =20 /* crc32.c -- compute the CRC-32 of a data stream * Copyright (C) 1995-1998 Mark Adler - * For conditions of distribution and use, see copyright notice in zlib.h */ =20 #include should be equivalent and isn't any longer. Or is it only me who considers this obviously better? Other than that: Reviewed-by: Uwe Kleine-K=F6nig Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --vyh7lah37s67mc4x Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEfnIqFpAYrP8+dKQLwfwUeK3K7AkFAmBjH8IACgkQwfwUeK3K 7Al/swf/aa8T7rfCN03zBSj/UUEkXFCmw57oUGynlIFaKxb+346dmH/JNyYUx6zw 74Krlnb//sIvhJJNUjCtXlUknEILD8Qc/cRD71OciOs8I2glYT1+Nsf5hpcfrMya c/UMucl5STHr3513h6sbufIkwHLpoW+jlR3WOh7Oe4ziIUr/xDdxdDLKsx5WzQDt F5lvrGXAc5QFsT+PgL4ZH1BdqfzIEYDNjOoasWfCrRbVLTHodcG2guhn00vA8ZnS 2Fso/ey4+GJkzJ7r/YdAt0ruJXYINqbWUY4jNyYB5ibMGY2zlDckdgRhDfw6eO/j IdTwBAvPTf9JtWPW/0I2NeojcrCPuQ== =erIG -----END PGP SIGNATURE----- --vyh7lah37s67mc4x-- --===============2083201490== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ OSS-Tools mailing list OSS-Tools@pengutronix.de --===============2083201490==--