From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Wed, 11 May 2022 10:21:40 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nohbI-009PgL-0N for lore@lore.pengutronix.de; Wed, 11 May 2022 10:21:40 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1nohbG-0002jT-Fy; Wed, 11 May 2022 10:21:38 +0200 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nohbE-0002i6-P9; Wed, 11 May 2022 10:21:36 +0200 Received: from [2a0a:edc0:0:1101:1d::39] (helo=dude03.red.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1nohbF-001eQh-BQ; Wed, 11 May 2022 10:21:35 +0200 Received: from mol by dude03.red.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1nohbC-00HZwD-T6; Wed, 11 May 2022 10:21:34 +0200 From: Michael Olbrich To: oss-tools@pengutronix.de Date: Wed, 11 May 2022 10:21:23 +0200 Message-Id: <20220511082125.4187531-2-m.olbrich@pengutronix.de> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20220511082125.4187531-1-m.olbrich@pengutronix.de> References: <20220511082125.4187531-1-m.olbrich@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [OSS-Tools] [PATCH v4 1/3] libdt: only requires a partname for mtd X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Olbrich Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false It's not used anywhere else. Signed-off-by: Michael Olbrich --- No changes in v3 and v4. src/libdt.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/src/libdt.c b/src/libdt.c index 59e76d336d8d..48c31931e8a1 100644 --- a/src/libdt.c +++ b/src/libdt.c @@ -2381,7 +2381,6 @@ int of_get_devicepath(struct device_node *partition_node, char **devpath, off_t { struct device_node *node; struct udev_device *dev, *partdev, *mtd; - const char *partname; int ret; *offset = 0; @@ -2451,16 +2450,18 @@ int of_get_devicepath(struct device_node *partition_node, char **devpath, off_t return -ENODEV; } - /* find the name of the partition... */ - ret = of_property_read_string(partition_node, "label", &partname); - if (ret) { - fprintf(stderr, "%s: no 'label' property found in %s\n", __func__, - partition_node->full_name); - return ret; - } - mtd = of_find_mtd_device(dev); if (mtd) { + const char *partname; + + /* find the name of the partition... */ + ret = of_property_read_string(partition_node, "label", &partname); + if (ret) { + fprintf(stderr, "%s: no 'label' property found in %s\n", __func__, + partition_node->full_name); + return ret; + } + /* ...find the udev_device by partition name... */ partdev = device_find_mtd_partition(dev, partname); if (!partdev) -- 2.30.2