From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 05 Jun 2023 11:15:46 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1q66JX-00BbFv-SD for lore@lore.pengutronix.de; Mon, 05 Jun 2023 11:15:46 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1q66JU-000354-GU; Mon, 05 Jun 2023 11:15:44 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q66JS-00034Z-8l; Mon, 05 Jun 2023 11:15:42 +0200 Received: from rhi by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1q66JS-0007bx-1Q; Mon, 05 Jun 2023 11:15:42 +0200 Date: Mon, 5 Jun 2023 11:15:42 +0200 From: Roland Hieber To: Ahmad Fatoum Message-ID: <20230605091542.zuis5fyxssefyv4v@pengutronix.de> References: <20220511082125.4187531-3-m.olbrich@pengutronix.de> <20230531151333.1407290-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230531151333.1407290-1-a.fatoum@pengutronix.de> User-Agent: NeoMutt/20180716 Subject: Re: [OSS-Tools] [PATCH fixup 1/2] libdt: remove ultimately unused variables X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: oss-tools@pengutronix.de Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Wed, May 31, 2023 at 05:13:32PM +0200, Ahmad Fatoum wrote: > These variables were recently added, but are unused. Drop them. > > Signed-off-by: Ahmad Fatoum > --- > src/libdt.c | 7 ++----- > 1 file changed, 2 insertions(+), 5 deletions(-) > > diff --git a/src/libdt.c b/src/libdt.c > index 44491a5e739b..302ca7a76375 100644 > --- a/src/libdt.c > +++ b/src/libdt.c > @@ -2365,7 +2365,6 @@ static struct udev_device *of_find_device_by_uuid(struct udev_device *parent, > struct udev *udev; > struct udev_enumerate *enumerate; > struct udev_list_entry *devices, *dev_list_entry; > - int ret = 0; > > udev = udev_new(); > if (!udev) { > @@ -2380,7 +2379,7 @@ static struct udev_device *of_find_device_by_uuid(struct udev_device *parent, > udev_enumerate_scan_devices(enumerate); > devices = udev_enumerate_get_list_entry(enumerate); > udev_list_entry_foreach(dev_list_entry, devices) { > - const char *path, *devtype, *outpath, *dev_uuid; > + const char *path, *devtype, *dev_uuid; > struct udev_device *device; > const char *property; > > @@ -2400,10 +2399,8 @@ static struct udev_device *of_find_device_by_uuid(struct udev_device *parent, > property = "ID_PART_ENTRY_UUID"; I'm not completely sure which version of the code you are referencing here because I cannot find that context, but … > dev_uuid = udev_device_get_property_value(device, property); > - if (dev_uuid && !strcasecmp(dev_uuid, uuid)) { > - outpath = udev_device_get_devnode(device); in mol's v4 patch there's another "outpath" occurrence in the 'if (!strcmp(devtype, "disk"))' block above that. - Roland > + if (dev_uuid && !strcasecmp(dev_uuid, uuid)) > return device; > - } > } > return NULL; > } > -- > 2.39.2 > > > -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |