mailarchive of the pengutronix oss-tools mailing list
 help / color / mirror / Atom feed
From: Roland Hieber <rhi@pengutronix.de>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: oss-tools@pengutronix.de
Subject: Re: [OSS-Tools] [PATCH 0/5] Add meson support and first test suite
Date: Mon, 5 Jun 2023 12:17:41 +0200	[thread overview]
Message-ID: <20230605101741.nv7pmd2xzdfjfj4i@pengutronix.de> (raw)
In-Reply-To: <20230531153125.1408092-1-a.fatoum@pengutronix.de>

On Wed, May 31, 2023 at 05:31:20PM +0200, Ahmad Fatoum wrote:
> The barebox,state binding is quite complex and we have a lot of udev
> parsing code that can only be exercised by manually running
> barebox-state on the target. Make development less error prone, by
> adding tests for the block device bindings. EEPROM and MTD can
> follow later.
> 
> Tests are executed by meson as a runner. Patches to teach autotools
> to do the same are welcome, although I think we should follow RAUC's
> steps and eventually deprecate autotools once meson is on par.

Yes.

> The obvious wart is that we build with -fvisibility=hidden on autotools,
> but with meson the same visibility option results in linker errors.
> 
> I have no idea why yet, but that should only make meson-built
> libdt-utils a bit slower without functional change.
> 
> Ahmad Fatoum (5):
>   Add meson as build system
>   state: add option to lock device node
>   meson: add simple integration test
>   libdt: add CONFIG_TEST_LOOPBACK
>   test: add barebox-state loop block device tests

For all:
Tested-by: Roland Hieber <rhi@pengutronix.de>

> 
>  .gitignore                                    |   2 +
>  README                                        |  21 +
>  check-news.sh                                 |  82 ++
>  configure.ac                                  |  11 +
>  meson.build                                   | 163 ++++
>  meson_options.txt                             |  25 +
>  src/barebox-state.c                           |  30 +-
>  src/barebox-state/state.c                     |   4 +
>  src/barebox-state/state.h                     |  21 +
>  src/dt/dt.h                                   |   1 -
>  src/libdt.c                                   |  50 +-
>  test/01-fixed-partition-no-gpt.dts            |  34 +
>  ...2-fixed-partition-before-gpt-partition.dts |  34 +
>  test/03-fixed-partition-is-gpt-partition.dts  |  34 +
>  test/04-gpt-partition-by-partuuid.dts         |  31 +
>  test/05-gpt-partition-by-typeuuid.dts         |  23 +
>  test/06-fixed-partition-by-diskuuid.dts       |  33 +
>  test/07-raw-disk-fail.dts                     |  18 +
>  test/08-gpt-disk-no-typeuuid-fail.dts         |  18 +
>  ...-partition-overlaps-two-gpt-partitions.dts |  34 +
>  ...-overlaps-two-gpt-partitions-partially.dts |  34 +
>  ...-fixed-partition-part-of-gpt-partition.dts |  34 +
>  test/barebox-state.dtsi                       |  53 ++
>  test/barebox-state.t                          | 229 +++++
>  test/crc32.c                                  |  18 +
>  test/gpt-no-typeuuid.config                   |  33 +
>  test/gpt.config                               |  35 +
>  test/meson.build                              |  36 +
>  test/raw.config                               |  24 +
>  test/sharness.sh                              | 857 ++++++++++++++++++
>  version-gen                                   |   3 +
>  version.h.in                                  |   3 +
>  32 files changed, 2012 insertions(+), 16 deletions(-)
>  create mode 100755 check-news.sh
>  create mode 100644 meson.build
>  create mode 100644 meson_options.txt
>  create mode 100644 test/01-fixed-partition-no-gpt.dts
>  create mode 100644 test/02-fixed-partition-before-gpt-partition.dts
>  create mode 100644 test/03-fixed-partition-is-gpt-partition.dts
>  create mode 100644 test/04-gpt-partition-by-partuuid.dts
>  create mode 100644 test/05-gpt-partition-by-typeuuid.dts
>  create mode 100644 test/06-fixed-partition-by-diskuuid.dts
>  create mode 100644 test/07-raw-disk-fail.dts
>  create mode 100644 test/08-gpt-disk-no-typeuuid-fail.dts
>  create mode 100644 test/31-fixed-partition-overlaps-two-gpt-partitions.dts
>  create mode 100644 test/32-fixed-partition-overlaps-two-gpt-partitions-partially.dts
>  create mode 100644 test/33-fixed-partition-part-of-gpt-partition.dts
>  create mode 100644 test/barebox-state.dtsi
>  create mode 100755 test/barebox-state.t
>  create mode 100644 test/crc32.c
>  create mode 100644 test/gpt-no-typeuuid.config
>  create mode 100644 test/gpt.config
>  create mode 100644 test/meson.build
>  create mode 100644 test/raw.config
>  create mode 100755 test/sharness.sh
>  create mode 100755 version-gen
>  create mode 100644 version.h.in
> 
> -- 
> 2.39.2
> 
> 
> 

-- 
Roland Hieber, Pengutronix e.K.          | r.hieber@pengutronix.de     |
Steuerwalder Str. 21                     | https://www.pengutronix.de/ |
31137 Hildesheim, Germany                | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686         | Fax:   +49-5121-206917-5555 |



  parent reply	other threads:[~2023-06-05 10:17 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-31 15:31 Ahmad Fatoum
2023-05-31 15:31 ` [OSS-Tools] [PATCH 1/5] Add meson as build system Ahmad Fatoum
2023-05-31 15:31 ` [OSS-Tools] [PATCH 2/5] state: add option to lock device node Ahmad Fatoum
2023-05-31 15:31 ` [OSS-Tools] [PATCH 3/5] meson: add simple integration test Ahmad Fatoum
2023-05-31 15:31 ` [OSS-Tools] [PATCH 4/5] libdt: add CONFIG_TEST_LOOPBACK Ahmad Fatoum
2023-06-12 11:56   ` Ahmad Fatoum
2023-05-31 15:31 ` [OSS-Tools] [PATCH 5/5] test: add barebox-state loop block device tests Ahmad Fatoum
2023-06-05 10:17 ` Roland Hieber [this message]
2023-06-12 11:57   ` [OSS-Tools] [PATCH 0/5] Add meson support and first test suite Ahmad Fatoum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230605101741.nv7pmd2xzdfjfj4i@pengutronix.de \
    --to=rhi@pengutronix.de \
    --cc=a.fatoum@pengutronix.de \
    --cc=oss-tools@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox