From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Mon, 03 Jul 2023 14:23:27 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qGIaX-00DVZK-1Z for lore@lore.pengutronix.de; Mon, 03 Jul 2023 14:23:27 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qGIaT-0004xH-K6; Mon, 03 Jul 2023 14:23:25 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qGIaR-0004x1-40; Mon, 03 Jul 2023 14:23:23 +0200 Received: from rhi by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qGIaQ-0006Zk-Sv; Mon, 03 Jul 2023 14:23:22 +0200 Date: Mon, 3 Jul 2023 14:23:22 +0200 From: Roland Hieber To: Ahmad Fatoum Message-ID: <20230703122322.n7rsawdeybau6iow@pengutronix.de> References: <20230607121628.3180139-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230607121628.3180139-1-a.fatoum@pengutronix.de> User-Agent: NeoMutt/20180716 Subject: Re: [OSS-Tools] [PATCH v2 0/8] state: allow lookup of barebox state partition by Type GUID X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: oss-tools@pengutronix.de Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Wed, Jun 07, 2023 at 02:16:20PM +0200, Ahmad Fatoum wrote: > This implements the binding extension introduced to barebox here: > https://lore.barebox.org/barebox/20230607120714.3083182-1-a.fatoum@pengutronix.de/T/#t > > With this, barebox,state backend can optionally point at a device > instead of a partition. If this device is GPT-partitioned and has > a partition with a specific partition type GUID of > > 4778ed65-bf42-45fa-9c5b-287a1dc4aab1 > > It will be taken. > > This series also fixes an annoying issue of barebox-state triggering > udev on every access, because the root block device corresponding > to the device tree node was opened r/w. > > barebox-state will now open the disk read-only if possible and if > a partition exists that fits the barebox state location, it will > be opened instead. > > v1 -> v2: > - added Uwe's Reviewed-by > - fix typo spotted by Roland > - Rebase on top of next > - Sync with v2 of barebox series: > - fix typo (Sascha) > - define new cdev_find_child_by_gpt_typeuuid helper (Marco) > - handle case of iterating over partitions before disk in > cdev_from_block_device Looks good to me now. Reviewed-by: Roland Hieber > > Ahmad Fatoum (8): > state: backend: direct: open block device in read-only mode if > possible > libdt: factor out u64 sysattr parsing into helper > libdt: drop broken if-branch > libdt: factor out __of_cdev_find helper > libdt: use block device partition instead of parent if found > state: align with barebox use of of_cdev_find > libdt: use of_find_device_by_uuid for partuuid lookup > state: allow lookup of barebox state partition by Type GUID > > src/barebox-state/backend_bucket_direct.c | 5 +- > src/barebox-state/backend_storage.c | 2 +- > src/barebox-state/state.c | 52 +++- > src/barebox-state/state.h | 3 +- > src/dt/common.h | 8 + > src/dt/dt.h | 7 + > src/libdt-utils.sym | 4 + > src/libdt.c | 336 ++++++++++++++++++---- > src/linux/uuid.h | 24 ++ > src/state.h | 4 + > 10 files changed, 368 insertions(+), 77 deletions(-) > create mode 100644 src/linux/uuid.h > > -- > 2.39.2 > > > -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |