From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 27 Jul 2023 10:23:34 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qOwHX-00Bsqv-JJ for lore@lore.pengutronix.de; Thu, 27 Jul 2023 10:23:34 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qOwHT-0003WR-Uw; Thu, 27 Jul 2023 10:23:31 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOwHQ-0003W3-Qn; Thu, 27 Jul 2023 10:23:28 +0200 Received: from rhi by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qOwHQ-0002yJ-IK; Thu, 27 Jul 2023 10:23:28 +0200 Date: Thu, 27 Jul 2023 10:23:28 +0200 From: Roland Hieber To: Ahmad Fatoum Message-ID: <20230727082328.vd4utty3y2wj7p54@pengutronix.de> References: <20230612120754.896995-1-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230612120754.896995-1-a.fatoum@pengutronix.de> User-Agent: NeoMutt/20180716 Subject: Re: [OSS-Tools] [PATCH 1/3] meson: options: use defaults of type boolean for boolean options X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: oss-tools@pengutronix.de Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Mon, Jun 12, 2023 at 02:07:52PM +0200, Ahmad Fatoum wrote: > From: Ahmad Fatoum > > Building with newer meson versions alerts us that specifying defaults > with a string type for non-string types is deprecated. This type > confusion was not intentional, so fix that. > > Signed-off-by: Ahmad Fatoum > --- Reviewed-by: Roland Hieber > meson_options.txt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/meson_options.txt b/meson_options.txt > index f80643aa6c73..04d9854a4b1b 100644 > --- a/meson_options.txt > +++ b/meson_options.txt > @@ -2,24 +2,24 @@ > option( > 'state-backward-compatibility', > type : 'boolean', > - value : 'false', > + value : false, > description : 'barebox-state: when using the "direct" storage backend, keep the on-disk format readable by barebox <= v2016.08.0') > > option( > 'lock-device', > type : 'boolean', > - value : 'false', > + value : false, > description : 'lock device node instead of creating lockfile in /run') > > # build options > option( > 'barebox-state', > type : 'boolean', > - value : 'true', > + value : true, > description : 'Build barebox-state utility') > > option( > 'tests', > type : 'boolean', > - value : 'true', > + value : true, > description : 'Enable/Disable test suite') > -- > 2.39.2 > > > -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |