From mboxrd@z Thu Jan 1 00:00:00 1970 Delivery-date: Thu, 27 Jul 2023 10:23:41 +0200 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by lore.white.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qOwHe-00BsrX-HU for lore@lore.pengutronix.de; Thu, 27 Jul 2023 10:23:41 +0200 Received: from localhost ([127.0.0.1] helo=metis.ext.pengutronix.de) by metis.ext.pengutronix.de with esmtp (Exim 4.92) (envelope-from ) id 1qOwHb-0003Zh-1n; Thu, 27 Jul 2023 10:23:39 +0200 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qOwHa-0003ZH-4b; Thu, 27 Jul 2023 10:23:38 +0200 Received: from rhi by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1qOwHZ-0002zZ-Sw; Thu, 27 Jul 2023 10:23:37 +0200 Date: Thu, 27 Jul 2023 10:23:37 +0200 From: Roland Hieber To: Ahmad Fatoum Message-ID: <20230727082337.hwkamj6ofjruszmh@pengutronix.de> References: <20230612120754.896995-1-a.fatoum@pengutronix.de> <20230612120754.896995-2-a.fatoum@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230612120754.896995-2-a.fatoum@pengutronix.de> User-Agent: NeoMutt/20180716 Subject: Re: [OSS-Tools] [PATCH 2/3] test: add test case with non-existent /dev/file X-BeenThere: oss-tools@pengutronix.de X-Mailman-Version: 2.1.29 Precedence: list List-Id: Pengutronix Public Open-Source-Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: oss-tools@pengutronix.de Sender: "OSS-Tools" X-SA-Exim-Connect-IP: 127.0.0.1 X-SA-Exim-Mail-From: oss-tools-bounces@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false On Mon, Jun 12, 2023 at 02:07:53PM +0200, Ahmad Fatoum wrote: > From: Ahmad Fatoum > > When backend points at a device that couldn't be resolved, barebox-state > should fail instead of taking another device. > > This is meant to address issues like the one fixed by commit > e7d71f099659 ("libdt: fix of_get_devicepath looking up sibling if > device unavailable"), but the error case there can't be reproduced > exactly, because loop devices have no common parent. Still one test > is better than no test until we start testing in Qemu. > > Signed-off-by: Ahmad Fatoum Reviewed-by: Roland Hieber > --- > test/09-no-disk-fail.dts | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 test/09-no-disk-fail.dts > > diff --git a/test/09-no-disk-fail.dts b/test/09-no-disk-fail.dts > new file mode 100644 > index 000000000000..49cfa852525d > --- /dev/null > +++ b/test/09-no-disk-fail.dts > @@ -0,0 +1,26 @@ > +/dts-v1/; > + > +#include "barebox-state.dtsi" > + > +/ { > + expected-dev = ""; > + > + disk: loopfile0 { > + compatible = "barebox,hostfile"; > + barebox,filename = "/dev/barebox-state-dev-does-not-exist"; > + barebox,blockdev; > + }; > + > + otherdisk: loopfile1 { > + compatible = "barebox,hostfile"; > + barebox,filename = __GPT_LOOPDEV__; > + barebox,blockdev; > + }; > +}; > + > +&state { > + backend = <&disk>; > + backend-type = "raw"; > + backend-stridesize = <0x40>; > + backend-storage-type = "direct"; > +}; > -- > 2.39.2 > > > -- Roland Hieber, Pengutronix e.K. | r.hieber@pengutronix.de | Steuerwalder Str. 21 | https://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |